mosaicstack/stack
25
0 Fork 1
Code Issues 404 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

Bus cannot boot after a credentialed agent is added when secrets/agents is missing (F3 defect l) #1886

New Issue
Closed
opened 2026-11-09 22:47:52 +00:00 by jason.woltje · 1 comment
jason.woltje commented 2026-11-09 22:47:52 +00:00
Owner
Copy link
Copy source

Found during F3 (#1873; report org-f3-build.md row l and section 8.1). Pre-existing, not an F3 regression.

On an instance with no <configDir>/secrets/agents, adding an agent definition that declares a store credential (for example companion or gitea) leaves the bus unable to boot. The next bus restart fails with broker refused to start: credential-file. packages/bus/src/credentials.mjs #read calls privateDir(this.#storeRoot) without { missing: true }. The store root is created only by issue(), which needs a running bus. Only scripts/case2/launch.mjs creates the root, so dev and org instances do not have it.

This conflicts with runtime.mjs ("issue works after the restart") and design D3a (a store reference with no file yet reads as null). But credential-store.test.mjs T1 deliberately pins "a missing store root refuses start" (row 199, cb5fdb064). Fixing it therefore means choosing a design, not just changing a line:

  1. The bus creates <configDir>/secrets/agents (0700, checked) at boot before Credentials opens, and keeps refusing a root that exists with bad modes or is a symlink. T1 changes from "missing root refuses" to "missing root is created private".
  2. #read treats a missing root as no file yet (null), like the model path at :198. T1 changes the same way.

Recommendation: option 1. It keeps a single place that decides the root's modes, and every later read still sees an existing private root.

Workaround until fixed: do not press Restart bus after adding a credentialed agent on a dev or org instance. The uiorg test guide says so.

Found during F3 (#1873; report org-f3-build.md row l and section 8.1). Pre-existing, not an F3 regression. On an instance with no `<configDir>/secrets/agents`, adding an agent definition that declares a store credential (for example `companion` or gitea) leaves the bus unable to boot. The next bus restart fails with `broker refused to start: credential-file`. `packages/bus/src/credentials.mjs` `#read` calls `privateDir(this.#storeRoot)` without `{ missing: true }`. The store root is created only by `issue()`, which needs a running bus. Only `scripts/case2/launch.mjs` creates the root, so dev and org instances do not have it. This conflicts with `runtime.mjs` ("issue works after the restart") and design D3a (a store reference with no file yet reads as null). But `credential-store.test.mjs` T1 deliberately pins "a missing store root refuses start" (row 199, cb5fdb064). Fixing it therefore means choosing a design, not just changing a line: 1. The bus creates `<configDir>/secrets/agents` (0700, checked) at boot before Credentials opens, and keeps refusing a root that exists with bad modes or is a symlink. T1 changes from "missing root refuses" to "missing root is created private". 2. `#read` treats a missing root as no file yet (null), like the model path at `:198`. T1 changes the same way. Recommendation: option 1. It keeps a single place that decides the root's modes, and every later read still sees an existing private root. Workaround until fixed: do not press Restart bus after adding a credentialed agent on a dev or org instance. The uiorg test guide says so.
jason.woltje commented 2026-11-09 23:14:52 +00:00
Author
Owner
Copy link
Copy source

Fixed by PR #1888, merged as 7a97cfc4f. Bus start now creates the private store root when a reference names the store. A root with loose modes or that is a symlink still refuses start.

Fixed by PR #1888, merged as 7a97cfc4f. Bus start now creates the private store root when a reference names the store. A root with loose modes or that is a symlink still refuses start.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1886