mosaicstack/stack
1
0
Fork 0
Code Issues 13 Pull Requests Actions Packages Projects Releases 11 Wiki Activity

fix(mosaic): mask password input in TUI login prompt #449

Merged
jason.woltje merged 1 commits from fix/tui-password-mask into main 2026-04-06 00:33:54 +00:00
Conversation 0 Commits 1 Files Changed 1 +3 -7
jason.woltje commented 2026-04-06 00:29:27 +00:00
Owner
Copy Link

Summary

The mosaic tui login prompt used a plain readline.question() for the password field, which echoed characters visibly to the terminal. Replaced with the existing promptSecret() helper that uses TTY raw mode — the same function already used by mosaic gateway login.

Test plan

  • pnpm --filter @mosaicstack/mosaic test — 260 tests pass
  • Typecheck clean
  • lint-staged passed
## Summary The `mosaic tui` login prompt used a plain `readline.question()` for the password field, which echoed characters visibly to the terminal. Replaced with the existing `promptSecret()` helper that uses TTY raw mode — the same function already used by `mosaic gateway login`. ## Test plan - [x] `pnpm --filter @mosaicstack/mosaic test` — 260 tests pass - [x] Typecheck clean - [x] lint-staged passed
jason.woltje added 1 commit 2026-04-06 00:29:28 +00:00
fix(mosaic): mask password input in TUI login prompt
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
dd42b6079f 
The TUI login flow used a plain readline.question() for the password
prompt, which echoed characters to the terminal. Replaced with the
existing promptSecret() helper that uses TTY raw mode to suppress
echo — the same function already used by `mosaic gateway login`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jason.woltje merged commit d08b969918 into main 2026-04-06 00:33:54 +00:00
jason.woltje deleted branch fix/tui-password-mask 2026-04-06 00:33:55 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#449
Delete Branch "fix/tui-password-mask"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?