mosaicstack/stack
1
0
Fork 0
Code Issues 42 Pull Requests Actions Packages Projects Releases 15 Wiki Activity

fix(tools/git/pr-ci-wait): stdin collision in python3 here-doc caused wrapper to always return unknown #513

Closed
jason.woltje wants to merge 0 commits from fix/pr-ci-wait-stdin-collision into main
pull from: fix/pr-ci-wait-stdin-collision
merge into: mosaicstack:main
Conversation 1 Commits - Files Changed -
jason.woltje commented 2026-05-13 23:31:26 +00:00
Owner
Copy Link

See commit a4cbd4b for full diagnosis. Heredoc-bound stdin consumed Python program text; json.load(sys.stdin) then saw EOF and bailed to unknown. Fix: capture stdin to local var before heredoc; pass via PR_CI_STATUS_JSON env. Same fix applied to both extract_state_from_status_json and print_status_summary.

See commit a4cbd4b for full diagnosis. Heredoc-bound stdin consumed Python program text; json.load(sys.stdin) then saw EOF and bailed to unknown. Fix: capture stdin to local var before heredoc; pass via PR_CI_STATUS_JSON env. Same fix applied to both extract_state_from_status_json and print_status_summary.
jason.woltje added 1 commit 2026-05-13 23:31:27 +00:00
fix(tools/git/pr-ci-wait): stdin collision in python3 - <<PY made wrapper always return "unknown" a4cbd4be51 
When the wrapper invoked `python3 - <<'PY' ... PY` inside a function that
was being fed JSON via a pipe (`printf '%s' "$STATUS_JSON" |
extract_state_from_status_json`), the heredoc bound stdin to the Python
program text. The `-` argument tells Python to read its program from
stdin, so the program consumed stdin before json.load(sys.stdin) ran —
which then saw EOF and bailed to the "unknown" branch every time.

Result: pr-ci-wait.sh hung the full timeout (default 30 min) even when
the upstream Gitea status was already 'success', because every poll
returned 'unknown' and the loop kept retrying.

Fix: capture the piped JSON into a local variable with `payload=$(cat)`
BEFORE invoking python, then pass it via env (PR_CI_STATUS_JSON). The
heredoc still drives the Python program, but the payload is now read
from the environment instead of a stdin that's already been consumed.

Same fix applied to print_status_summary() which has the identical
pattern.

Verified locally:
  $ echo '{"state":"success"}' | extract_state_from_status_json → success
  $ echo '' | extract_state_from_status_json → unknown
  $ echo '{"state":null,"statuses":[{"state":"success"}]}' | … → success
  $ echo '{"state":"pending"}' | extract_state_from_status_json → pending
  $ echo '{"state":"failure"}' | extract_state_from_status_json → failure

Reported in screenshot from operator session 2026-05-13 — wrapper was
stuck waiting on a PR whose underlying Gitea status was already
success. Operator workaround was to bypass the wrapper and use the raw
Gitea API.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
jason.woltje force-pushed fix/pr-ci-wait-stdin-collision from a4cbd4be51 to 59b611ba8a 2026-06-11 18:20:12 +00:00 Compare
jason.woltje commented 2026-06-11 18:21:00 +00:00
Author
Owner
Copy Link

Closing as superseded by #524 (rollup, merged 2026-05-26 as 821e19d). Verified during orchestration rebase: the pr-ci-wait.sh stdin-collision fix is already present on current main in both extract_state_from_status_json() and print_status_summary(); rebasing this branch drops its commit as already-upstream (net-zero diff vs main). The underlying bug is fixed in main — no code action needed. — orchestrator (mos)

Closing as **superseded by #524** (rollup, merged 2026-05-26 as 821e19d). Verified during orchestration rebase: the pr-ci-wait.sh stdin-collision fix is already present on current main in both extract_state_from_status_json() and print_status_summary(); rebasing this branch drops its commit as already-upstream (net-zero diff vs main). The underlying bug is fixed in main — no code action needed. — orchestrator (mos)
jason.woltje closed this pull request 2026-06-11 18:21:00 +00:00
Some checks failed
ci/woodpecker/push/ci Pipeline was canceled
Details
ci/woodpecker/push/publish Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#513
Delete Branch "fix/pr-ci-wait-stdin-collision"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?