mosaicstack/stack
1
0
Fork 0
Code Issues 13 Pull Requests Actions Packages Projects Releases 11 Wiki Activity

fix: call piSession.dispose() in AgentService.destroySession #62

New Issue
Closed
opened 2026-03-13 01:35:58 +00:00 by jason.woltje · 0 comments
jason.woltje commented 2026-03-13 01:35:58 +00:00
Owner
Copy Link

Problem

AgentService.destroySession() calls session.unsubscribe() and clears listeners, but never calls session.piSession.dispose(). The Pi SDK's dispose() method is the intended shutdown path — it removes all internal listeners and disconnects from the agent. Without it, the Pi AgentSession object and its underlying agent remain in memory with internal subscriptions alive, preventing GC and potentially leaving background work running.

Location

apps/gateway/src/agent/agent.service.ts — destroySession() method

Fix

Add session.piSession.dispose() after unsubscribe() in the destroy path. Wrap in try-catch consistent with existing error handling.

Found by

Gatekeeper review (communication spine PR #61)

## Problem `AgentService.destroySession()` calls `session.unsubscribe()` and clears listeners, but never calls `session.piSession.dispose()`. The Pi SDK's `dispose()` method is the intended shutdown path — it removes all internal listeners and disconnects from the agent. Without it, the Pi `AgentSession` object and its underlying agent remain in memory with internal subscriptions alive, preventing GC and potentially leaving background work running. ## Location `apps/gateway/src/agent/agent.service.ts` — `destroySession()` method ## Fix Add `session.piSession.dispose()` after `unsubscribe()` in the destroy path. Wrap in try-catch consistent with existing error handling. ## Found by Gatekeeper review (communication spine PR #61)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#62
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?