mosaicstack/stack
1
0
Fork 0
Code Issues 36 Pull Requests Actions Packages Projects Releases 15 Wiki Activity

feat(installer): add next integration lane #686

Merged
jason.woltje merged 1 commits from feat/installer-next-lane into next 2026-06-25 05:14:33 +00:00
Conversation 1 Commits 1 Files Changed 6 +174 -15
jason.woltje commented 2026-06-25 04:48:18 +00:00
Owner
Copy Link

Summary

  • add tools/install.sh --next / MOSAIC_NEXT=1 prerelease source-build lane targeting next
  • keep explicit --ref / MOSAIC_REF precedence over the next lane
  • document stable/latest, prerelease/next, and contributor/dev install flows

Verification

  • bash -n tools/install.sh
  • ShellCheck (koalaman/shellcheck)
  • precedence smokes for --next, --ref, MOSAIC_NEXT, MOSAIC_REF
  • pnpm typecheck
  • pnpm lint
  • pnpm format:check
  • Codex code review: approve, 0 findings

Closes #8

## Summary - add `tools/install.sh --next` / `MOSAIC_NEXT=1` prerelease source-build lane targeting `next` - keep explicit `--ref` / `MOSAIC_REF` precedence over the next lane - document stable/latest, prerelease/next, and contributor/dev install flows ## Verification - `bash -n tools/install.sh` - ShellCheck (`koalaman/shellcheck`) - precedence smokes for `--next`, `--ref`, `MOSAIC_NEXT`, `MOSAIC_REF` - `pnpm typecheck` - `pnpm lint` - `pnpm format:check` - Codex code review: approve, 0 findings Closes #8
jason.woltje added 1 commit 2026-06-25 04:48:19 +00:00
feat(installer): add next integration lane
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
3a5c12a539
jason.woltje commented 2026-06-25 05:04:56 +00:00
Author
Owner
Copy Link

REVIEW-OF-RECORD — APPROVE (#686, head 3a5c12a539). I reviewed the installer --next lane source/docs and found no blockers.

Installer behavior: --next sets source-build mode (FLAG_DEV=true) and targets GIT_REF=next only when no explicit ref is present. Explicit refs win in both argument orders: --next --ref feature-x and --ref feature-before --next both display the explicit ref with "--next requested, explicit ref wins". Env parity is present: MOSAIC_NEXT=1 mirrors --next, while MOSAIC_REF wins over it. Source display lines correctly distinguish the pure next lane from explicit-ref override cases.

Docs: the top installer flag/env block documents --next and MOSAIC_NEXT; README, framework defaults README, and user guide accurately describe the three lanes: stable npm @latest + main framework, prerelease --next source build from next, and contributor --dev --ref X source build. The npm @next dist-tag pipeline note is clearly marked PLANNED / not yet built, so it does not imply current behavior.

Reviewer verification on head 3a5c12a5: bash -n tools/install.sh pass; ShellCheck pass; precedence smokes pass for --next, --next --ref, --ref --next, MOSAIC_NEXT=1, and MOSAIC_NEXT=1 MOSAIC_REF=...; pnpm typecheck pass (41/41); pnpm lint pass (23/23); pnpm format:check pass. PR CI reported green on pipeline 1626. APPROVE.

REVIEW-OF-RECORD — APPROVE (#686, head 3a5c12a5391a934e70954be633e48a8536144fe7). I reviewed the installer --next lane source/docs and found no blockers. Installer behavior: `--next` sets source-build mode (`FLAG_DEV=true`) and targets `GIT_REF=next` only when no explicit ref is present. Explicit refs win in both argument orders: `--next --ref feature-x` and `--ref feature-before --next` both display the explicit ref with "--next requested, explicit ref wins". Env parity is present: `MOSAIC_NEXT=1` mirrors `--next`, while `MOSAIC_REF` wins over it. Source display lines correctly distinguish the pure next lane from explicit-ref override cases. Docs: the top installer flag/env block documents `--next` and `MOSAIC_NEXT`; README, framework defaults README, and user guide accurately describe the three lanes: stable npm `@latest` + main framework, prerelease `--next` source build from `next`, and contributor `--dev --ref X` source build. The npm `@next` dist-tag pipeline note is clearly marked `PLANNED / not yet built`, so it does not imply current behavior. Reviewer verification on head 3a5c12a5: `bash -n tools/install.sh` pass; ShellCheck pass; precedence smokes pass for `--next`, `--next --ref`, `--ref --next`, `MOSAIC_NEXT=1`, and `MOSAIC_NEXT=1 MOSAIC_REF=...`; `pnpm typecheck` pass (41/41); `pnpm lint` pass (23/23); `pnpm format:check` pass. PR CI reported green on pipeline 1626. APPROVE.
jason.woltje merged commit 94d6538061 into next 2026-06-25 05:14:33 +00:00
jason.woltje deleted branch feat/installer-next-lane 2026-06-25 05:14:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#686
Delete Branch "feat/installer-next-lane"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?