mosaicstack/stack
1
0
Fork 0
Code Issues 42 Pull Requests Actions Packages Projects Releases 15 Wiki Activity

Fixes #703 #705

Merged
jason.woltje merged 2 commits from fix/703-wrapper-interactive-auth into main 2026-07-12 20:49:44 +00:00
Conversation 1 Commits 2 Files Changed 7 +198
jason.woltje commented 2026-07-12 14:54:27 +00:00
Owner
Copy Link

Summary

  • add issue-create interactive support through -i and --interactive
  • validate the configured Tea login through the target-host current-user endpoint before mutation
  • route stale Tea user failures to the existing host-scoped Gitea API fallback for issues and PRs
  • add shell regression coverage and deployment verification evidence

Verification

  • shell wrapper regression harnesses passed, including stale Tea GetUserByName fallback simulation
  • deployed framework re-seeded; interactive issue create verification #704 opened and was closed
  • pnpm typecheck, lint, and format:check passed
  • pnpm test ran 995 passing tests but one unrelated gateway integration suite requires PostgreSQL at localhost:5433, which was unavailable locally; CI supplies that service

Fixes #703

## Summary - add issue-create interactive support through -i and --interactive - validate the configured Tea login through the target-host current-user endpoint before mutation - route stale Tea user failures to the existing host-scoped Gitea API fallback for issues and PRs - add shell regression coverage and deployment verification evidence ## Verification - shell wrapper regression harnesses passed, including stale Tea GetUserByName fallback simulation - deployed framework re-seeded; interactive issue create verification #704 opened and was closed - pnpm typecheck, lint, and format:check passed - pnpm test ran 995 passing tests but one unrelated gateway integration suite requires PostgreSQL at localhost:5433, which was unavailable locally; CI supplies that service Fixes #703
jason.woltje added 2 commits 2026-07-12 14:54:28 +00:00
fix(framework): restore interactive resilient Git wrappers bab87fa72e
docs: record wrapper deployment verification
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
d1b43f8fb4
jason.woltje commented 2026-07-12 18:06:11 +00:00
Author
Owner
Copy Link

VERIFIED APPROVE reviewer-of-record [W-jarvis:reviewer] head d1b43f8fb4

Reviewed PR #705 against main at exact head d1b43f8fb49073c997d449bdac9b4e6d6bf91aa8.

Evidence:

  • Exact head verified: PR ref and branch fix/703-wrapper-interactive-auth both resolve to d1b43f8fb49073c997d449bdac9b4e6d6bf91aa8.
  • Scope verified: 7 files, +198/-0; changes are limited to the Git wrapper auth/interactive path plus shell regression harnesses and scratchpad evidence. git diff --check clean.
  • issue-create.sh now supports -i / --interactive, prompts only for missing fields, and preserves explicit CLI values as precedence.
  • Gitea mutation wrappers now validate the current Tea credential through tea api --login <login> /user before using Tea mutation commands; stale authenticated-user failures route to the existing host-scoped Gitea API fallback for both issue and PR creation.
  • Fallback path remains host-scoped via remote-host/token resolution and does not print token values. No --no-verify or direct-main/deploy behavior introduced.
  • Regression coverage verified locally on exact head:
    • bash -n packages/mosaic/framework/tools/git/*.sh
    • packages/mosaic/framework/tools/git/test-issue-create-interactive-auth.sh
    • packages/mosaic/framework/tools/git/test-issue-create-body-safety.sh
    • packages/mosaic/framework/tools/git/test-gitea-login-resolution.sh
    • packages/mosaic/framework/tools/git/test-pr-metadata-gitea.sh
    • packages/mosaic/framework/tools/git/test-pr-merge-gitea-empty-uid.sh
    • bash packages/mosaic/framework/tools/git/test-lane-brief-pr-linkage.sh
  • CI verified: Woodpecker PR pipeline #1674 is terminal success on commit d1b43f8fb49073c997d449bdac9b4e6d6bf91aa8; install, sanitization, typecheck, lint, format, and test steps are success. Push pipeline #1673 is also success on the same commit. CI logs show typecheck 41 successful, 41 total, 0 cached; lint 23 successful, 23 total, 0 cached; tests 41 successful, 41 total after DB migration.

No merge performed by reviewer.

VERIFIED APPROVE reviewer-of-record [W-jarvis:reviewer] head d1b43f8fb49073c997d449bdac9b4e6d6bf91aa8 Reviewed PR #705 against `main` at exact head `d1b43f8fb49073c997d449bdac9b4e6d6bf91aa8`. Evidence: - Exact head verified: PR ref and branch `fix/703-wrapper-interactive-auth` both resolve to `d1b43f8fb49073c997d449bdac9b4e6d6bf91aa8`. - Scope verified: 7 files, `+198/-0`; changes are limited to the Git wrapper auth/interactive path plus shell regression harnesses and scratchpad evidence. `git diff --check` clean. - `issue-create.sh` now supports `-i` / `--interactive`, prompts only for missing fields, and preserves explicit CLI values as precedence. - Gitea mutation wrappers now validate the current Tea credential through `tea api --login <login> /user` before using Tea mutation commands; stale authenticated-user failures route to the existing host-scoped Gitea API fallback for both issue and PR creation. - Fallback path remains host-scoped via remote-host/token resolution and does not print token values. No `--no-verify` or direct-main/deploy behavior introduced. - Regression coverage verified locally on exact head: - `bash -n packages/mosaic/framework/tools/git/*.sh` - `packages/mosaic/framework/tools/git/test-issue-create-interactive-auth.sh` - `packages/mosaic/framework/tools/git/test-issue-create-body-safety.sh` - `packages/mosaic/framework/tools/git/test-gitea-login-resolution.sh` - `packages/mosaic/framework/tools/git/test-pr-metadata-gitea.sh` - `packages/mosaic/framework/tools/git/test-pr-merge-gitea-empty-uid.sh` - `bash packages/mosaic/framework/tools/git/test-lane-brief-pr-linkage.sh` - CI verified: Woodpecker PR pipeline #1674 is terminal `success` on commit `d1b43f8fb49073c997d449bdac9b4e6d6bf91aa8`; install, sanitization, typecheck, lint, format, and test steps are success. Push pipeline #1673 is also `success` on the same commit. CI logs show typecheck `41 successful, 41 total`, `0 cached`; lint `23 successful, 23 total`, `0 cached`; tests `41 successful, 41 total` after DB migration. No merge performed by reviewer.
jason.woltje merged commit b580d37d51 into main 2026-07-12 20:49:44 +00:00
jason.woltje deleted branch fix/703-wrapper-interactive-auth 2026-07-12 20:49:45 +00:00
jason.woltje referenced this issue from a commit 2026-07-12 20:49:46 +00:00
Fixes #703 (#705)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#705
Delete Branch "fix/703-wrapper-interactive-auth"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?