mosaicstack/stack
1
0
Fork 0
Code Issues 13 Pull Requests Actions Packages Projects Releases 11 Wiki Activity

fix: coord review remediations — path traversal, JSON parse guards, race condition #80

New Issue
Closed
opened 2026-03-13 03:43:23 +00:00 by jason.woltje · 0 comments
jason.woltje commented 2026-03-13 03:43:23 +00:00
Owner
Copy Link

Address code review findings from P2-005 coord migration:

  1. Path traversal via unvalidated projectPath query param
  2. Unguarded JSON.parse in mission.ts, status.ts, runner.ts
  3. Race condition in stale lock removal
  4. Missing @Inject() per project guideline
  5. Double loadMission in getTaskStatus
  6. Fragile prompt-inclusion check in runner.ts
  7. writeAtomic missing mkdir
Address code review findings from P2-005 coord migration: 1. Path traversal via unvalidated projectPath query param 2. Unguarded JSON.parse in mission.ts, status.ts, runner.ts 3. Race condition in stale lock removal 4. Missing @Inject() per project guideline 5. Double loadMission in getTaskStatus 6. Fragile prompt-inclusion check in runner.ts 7. writeAtomic missing mkdir
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#80
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?