mosaicstack/stack
1
0
Fork 0
Code Issues 85 Pull Requests Actions Packages Projects Releases 15 Wiki Activity

flaky-test (expedited): apply #898 wait_ready connect-probe to recovery_runtime_unittest.py (co-equal CI vector) #899

New Issue
Closed
opened 2026-07-25 22:11:16 +00:00 by jason.woltje · 0 comments
jason.woltje commented 2026-07-25 22:11:16 +00:00
Owner
Copy Link

Co-equal CI flake vector to #897/#898. recovery_runtime_unittest.py is ALSO in the CI test chain (pnpm test → turbo → packages/mosaic test = vitest run && test:framework-shell, which runs 11 py unittests incl this one) and carries the IDENTICAL wait_ready() TOCTOU race (socket_path.exists() before listen() → ECONNREFUSED under load). Full CI stability needs this fixed too (#898 fixed only recovery_b1).

Fix: cherry-pick the PROVEN form now on main from recovery_b1_adversarial_unittest.py::wait_ready() (PR #898) into recovery_runtime_unittest.py::wait_ready(). Same scalpel: readiness probe ONLY, zero assertion/logic changes, zero daemon changes. Independent review carries the assert-byte-unchanged gate. (The 2 compaction-refresh probes p5/p6 are docs/, NOT in CI — separate trailing low-priority PR per Mos.)

Co-equal CI flake vector to #897/#898. `recovery_runtime_unittest.py` is ALSO in the CI `test` chain (`pnpm test` → turbo → `packages/mosaic` `test` = `vitest run && test:framework-shell`, which runs 11 py unittests incl this one) and carries the IDENTICAL `wait_ready()` TOCTOU race (`socket_path.exists()` before `listen()` → ECONNREFUSED under load). Full CI stability needs this fixed too (#898 fixed only recovery_b1). **Fix:** cherry-pick the PROVEN form now on main from `recovery_b1_adversarial_unittest.py::wait_ready()` (PR #898) into `recovery_runtime_unittest.py::wait_ready()`. Same scalpel: readiness probe ONLY, zero assertion/logic changes, zero daemon changes. Independent review carries the assert-byte-unchanged gate. (The 2 compaction-refresh probes p5/p6 are docs/, NOT in CI — separate trailing low-priority PR per Mos.)
Mos closed this issue 2026-07-25 22:26:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#899
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?