mosaicstack/stack
1
0
Fork 1
Code Issues 109 Pull Requests 1 Actions Packages Projects Releases 15 Wiki Activity

wake: store.sh usage() has no test needle — the #952 surface that regressed silently is the one nothing asserts #971

New Issue
Open
opened 2026-07-30 21:58:36 +00:00 by mos-dt-0 · 0 comments
mos-dt-0 commented 2026-07-30 21:58:36 +00:00
Contributor
Copy Link
Copy Source

#952 was a wording defect that appeared on three surfaces in store.sh: the clean-sweep runtime message, the PROVABILITY BOUND comment, and the usage() help text. The fix (#967) landed on all three, and test-wake-store-ack.sh T17 needles the runtime message per clause. Nothing needles usage().

Measured

Grepped every test-wake-*.sh in packages/mosaic/framework/tools/wake/ for an invocation of store.sh's help/usage output at #967 head 119ed97: zero assertions. (test-wake-beacon.sh, test-wake-fn-oracle.sh and test-wake-preimage.sh match the word usage, but they are asserting their own SLO guards and an error-message comment — none of them reads store.sh's help text.)

Why this is not theoretical

usage() already regressed silently inside this PR's own history. The first head fixed the runtime message and left the help text carrying the identical one-class claim; an operator reading --help would have formed exactly the false conclusion the runtime fix removes. It was caught by the author's own eye on a re-read, not by the suite, and the suite was green for that head.

An untested wording surface is a surface where the next edit is free to reintroduce the defect and still ship green. The help text is also the surface an operator is most likely to read before acting, and the least likely to be exercised by anything else.

Suggested fix

Add an assertion group to test-wake-store-ack.sh that runs store.sh with no arguments (or --help) and greps the quarantine-audit block for both residual classes — one assertion per class, so each fails for its own clause. The acceptance criterion is that reverting only the usage() wording turns it red while the T17 runtime assertions stay green; otherwise the needle is riding on the message it did not mean to test.

Same class as #969

#969 is the same shape one layer down: a both-forms fix where only one form had a needle, so reverting the unneedled half left the suite 17/17 green. Here it is a three-surface fix where one surface has no needle at all. A multi-surface fix needs a needle per surface, and the surface a human caught by eye is precisely the one with no machine watching it.

Filed by mos-dt (sb-it-1-dt) out of the #967 review at 119ed97.

#952 was a wording defect that appeared on **three** surfaces in `store.sh`: the clean-sweep runtime message, the `PROVABILITY BOUND` comment, and the `usage()` help text. The fix (#967) landed on all three, and `test-wake-store-ack.sh` T17 needles the runtime message per clause. **Nothing needles `usage()`.** ## Measured Grepped every `test-wake-*.sh` in `packages/mosaic/framework/tools/wake/` for an invocation of `store.sh`'s help/usage output at #967 head `119ed97`: **zero assertions**. (`test-wake-beacon.sh`, `test-wake-fn-oracle.sh` and `test-wake-preimage.sh` match the word `usage`, but they are asserting their own SLO guards and an error-message comment — none of them reads `store.sh`'s help text.) ## Why this is not theoretical `usage()` **already regressed silently inside this PR's own history.** The first head fixed the runtime message and left the help text carrying the identical one-class claim; an operator reading `--help` would have formed exactly the false conclusion the runtime fix removes. It was caught by the author's own eye on a re-read, not by the suite, and the suite was green for that head. An untested wording surface is a surface where the next edit is free to reintroduce the defect and still ship green. The help text is also the surface an operator is *most* likely to read before acting, and the least likely to be exercised by anything else. ## Suggested fix Add an assertion group to `test-wake-store-ack.sh` that runs `store.sh` with no arguments (or `--help`) and greps the `quarantine-audit` block for both residual classes — one assertion per class, so each fails for its own clause. The acceptance criterion is that reverting **only** the `usage()` wording turns it red while the T17 runtime assertions stay green; otherwise the needle is riding on the message it did not mean to test. ## Same class as #969 #969 is the same shape one layer down: a both-forms fix where only one form had a needle, so reverting the unneedled half left the suite 17/17 green. Here it is a three-surface fix where one surface has no needle at all. **A multi-surface fix needs a needle per surface, and the surface a human caught by eye is precisely the one with no machine watching it.** *Filed by mos-dt (sb-it-1-dt) out of the #967 review at `119ed97`.*
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#971