94 lines
6.3 KiB
JavaScript
94 lines
6.3 KiB
JavaScript
// #1873 ride-default, re-check 3 P1-1: `mosaic org update` that takes cliproxy off an organization
|
|
// records the removal in the instance's proxy receipts before it writes, as the Console's admin save
|
|
// does, so Ride all leaves the organization off.
|
|
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import fs from 'node:fs';
|
|
import { join } from 'node:path';
|
|
import { tmpdir } from 'node:os';
|
|
import { orgUpdate } from '../src/org.mjs';
|
|
import * as orgService from '../../organization/src/org-service.mjs';
|
|
import { createProxyAdmin } from '../../model-proxy/src/admin-control.mjs';
|
|
import { receiptFile } from '../../model-proxy/src/admin.mjs';
|
|
|
|
const owner = { provider: 'local-dev', iss: 'local-dev', sub: 'local-dev-owner' };
|
|
function scratch(t) {
|
|
const root = fs.mkdtempSync(join(tmpdir(), 'org-upd-'));
|
|
t.after(() => fs.rmSync(root, { recursive: true, force: true }));
|
|
const configDir = join(root, 'config'), dataRoot = join(root, 'data');
|
|
fs.mkdirSync(configDir, { mode: 0o700 }); fs.mkdirSync(dataRoot, { mode: 0o700 });
|
|
return { configDir, dataRoot, instance: 'test', principal: owner };
|
|
}
|
|
const receipts = dataRoot => { try { return fs.readFileSync(receiptFile(dataRoot), 'utf8').trim().split('\n').filter(Boolean).map(JSON.parse); } catch { return []; } };
|
|
const withProviders = (doc, list) => ({ ...doc, plugins: { ...(doc.plugins ?? {}), 'model-provider': list } });
|
|
async function cliproxyOrg(ctx, id) {
|
|
const doc = withProviders(await orgService.templateRender(id), ['cliproxy']);
|
|
await orgService.createOrg(ctx, id, doc);
|
|
return orgService.showOrg(ctx, id);
|
|
}
|
|
|
|
test('the reviewer probe: an organization taken off cliproxy by mosaic org update is skipped by Ride all as removed', async t => {
|
|
const ctx = scratch(t);
|
|
const shown = await cliproxyOrg(ctx, 'cli');
|
|
await orgUpdate(ctx, 'cli', withProviders(shown.doc, []), { ifRevision: shown.revision });
|
|
assert.deepEqual((await orgService.showOrg(ctx, 'cli')).doc.plugins['model-provider'], []);
|
|
assert.deepEqual(receipts(ctx.dataRoot).map(r => [r.op, r.org]), [['ride-removed', 'cli']]);
|
|
const writes = [];
|
|
const call = async verb => {
|
|
if (verb === 'plugins') return { revision: 'r', plugins: { 'model-provider': [] } };
|
|
if (verb === 'proxy.accounts') return { accounts: [] };
|
|
if (verb === 'plugins.set') { writes.push('cli'); return { revision: 'r2' }; }
|
|
throw new Error(`unexpected ${verb}`);
|
|
};
|
|
const proxy = createProxyAdmin({ dataRoot: ctx.dataRoot, configDir: ctx.configDir, unit: { unit: 'u', status: async () => ({}) }, buses: async () => ({ stopped: true, running: [] }), fetch: async () => ({}),
|
|
riders: async () => [{ id: 'cli', fixture: false, cliproxy: false, changes: '', call }] });
|
|
const r = await proxy.rideAll();
|
|
assert.deepEqual(r.added, []); assert.deepEqual(r.skipped, [{ id: 'cli', reason: 'removed' }]);
|
|
assert.deepEqual(writes, []);
|
|
});
|
|
|
|
test('mosaic org update records only a removal of cliproxy, and saves nothing when the record cannot be written', async t => {
|
|
const ctx = scratch(t);
|
|
const recorded = [];
|
|
const record = async id => { recorded.push(id); };
|
|
// Keeping cliproxy, or an organization that never had it, records nothing.
|
|
let shown = await cliproxyOrg(ctx, 'keep');
|
|
await orgUpdate(ctx, 'keep', { ...shown.doc }, { ifRevision: shown.revision, record });
|
|
const plain = await orgService.templateRender('plain');
|
|
await orgService.createOrg(ctx, 'plain', withProviders(plain, []));
|
|
shown = await orgService.showOrg(ctx, 'plain');
|
|
await orgUpdate(ctx, 'plain', { ...shown.doc }, { ifRevision: shown.revision, record });
|
|
assert.deepEqual(recorded, []);
|
|
// A stale revision records nothing and is refused by the service.
|
|
shown = await cliproxyOrg(ctx, 'stale');
|
|
await assert.rejects(orgUpdate(ctx, 'stale', withProviders(shown.doc, []), { ifRevision: shown.revision + 1, record }), { code: 'revision-conflict' });
|
|
assert.deepEqual(recorded, []);
|
|
// A record that fails refuses the update: the organization keeps cliproxy, at the same revision.
|
|
await assert.rejects(orgUpdate(ctx, 'stale', withProviders(shown.doc, []), { ifRevision: shown.revision, record: async () => { throw Object.assign(new Error('disk full at /x/proxy-admin.jsonl'), { code: 'ENOSPC' }); } }),
|
|
err => err.exitCode === 3 && err.message === 'the removal of the model proxy could not be recorded, so nothing was saved');
|
|
const after = await orgService.showOrg(ctx, 'stale');
|
|
assert.deepEqual(after.doc.plugins['model-provider'], ['cliproxy']); assert.equal(after.revision, shown.revision);
|
|
// The removal itself records once, before the write.
|
|
await orgUpdate(ctx, 'stale', withProviders(shown.doc, []), { ifRevision: shown.revision, record: async id => { recorded.push(id); assert.deepEqual((await orgService.showOrg(ctx, 'stale')).doc.plugins['model-provider'], ['cliproxy'], 'recorded before the write'); } });
|
|
assert.deepEqual(recorded, ['stale']);
|
|
});
|
|
|
|
test('the mosaic org update command records the removal in the instance\'s own proxy receipts', async t => {
|
|
const { spawnSync } = await import('node:child_process');
|
|
const { resolve } = await import('node:path');
|
|
const repo = resolve(import.meta.dirname, '../../..');
|
|
const home = fs.mkdtempSync(join(tmpdir(), 'org-upd-cli-'));
|
|
t.after(() => fs.rmSync(home, { recursive: true, force: true }));
|
|
const env = { ...process.env, HOME: home, MOSAIC_CONFIG: join(home, '.config/mosaic-orgupd/config.json') };
|
|
const run = (cmd, ...args) => { const r = spawnSync(join(repo, cmd), args, { cwd: repo, env, encoding: 'utf8' }); assert.equal(r.status, 0, r.stderr); return r.stdout; };
|
|
run('scripts/bootstrap.sh', '--instance', 'orgupd');
|
|
const on = join(home, 'on.json'), off = join(home, 'off.json');
|
|
const doc = withProviders(await orgService.templateRender('cliw'), ['cliproxy']);
|
|
fs.writeFileSync(on, JSON.stringify(doc)); fs.writeFileSync(off, JSON.stringify(withProviders(doc, [])));
|
|
run('scripts/mosaic', 'org', 'create', 'cliw', '--from', on);
|
|
const { revision } = JSON.parse(run('scripts/mosaic', 'org', 'show', 'cliw', '--json'));
|
|
run('scripts/mosaic', 'org', 'update', 'cliw', '--from', off, '--if-revision', String(revision));
|
|
assert.deepEqual(JSON.parse(run('scripts/mosaic', 'org', 'show', 'cliw', '--json')).doc.plugins['model-provider'], []);
|
|
assert.deepEqual(receipts(join(home, '.mosaic-orgupd')).map(r => [r.op, r.org]), [['ride-removed', 'cliw']]);
|
|
});
|