Files

2.4 KiB

Filbert review: row 116 round 2 (#1610): approve

Candidate manifest sha256 8b4ab31014a124ec0e3abba44238976d6f4c9af48cbdb36c2c77d18f0137f888 (6 files), as named in comment 28466. I rebuilt it in my own worktree at BASE 1223a0f37 with build.patch from packet 0a4076e8e. All 6 hashes match, and git diff --check is clean. No manifest path has drifted from 1223a0f37 to HEAD. The patch's added lines have no dashes, bidi or control characters.

What changed since round 1

Against the round 1 manifest, only scripts/test-land-work.sh and docs/TOOLS.md differ. read.mjs, land-work.sh, fixture.mjs and CONDUCTOR.md keep their round 1 hashes. My round 1 reading of them stands, and so do the replay and the s26 ruling.

C1

gen.mjs has six new variants: answer-role, answer-run, answer-choice, two-answers, raise-task-disagrees, and earlier-merge. In earlier-merge, a merge decision on the same ref and task is raised before D and withdrawn, and the dry run must exit 0. Each variant changes only the row its condition reads. C1 is closed.

Rerun by me, with the slot (sage-0210)

These were in my own worktree with a short TMPDIR. Each mutant was applied as a unique string replacement and restored afterwards, and all 6 hashes were rechecked at the end.

Run Result Failing case
plain 84 pass, 0 fail none
r24, the answer's actor_role check dropped 83 pass, 1 fail answer-role
r25, the answer's actor_run check dropped 83 pass, 1 fail answer-run
r26, the answer's choice check dropped 83 pass, 1 fail answer-choice
r27, several answers accepted 83 pass, 1 fail two-answers
r28, raise.task_ref dropped from the agreement 83 pass, 1 fail raise-task-disagrees
r29, seq > ? to seq <> ? 83 pass, 1 fail earlier-merge (refused superseded)
s27, cleanup follows the link 83 pass, 1 fail the target's node_modules is still there, with its contents

This matches mutants-run.log. The canary closes my round 1 suggestion, and s26 stays equivalent.

D1

The TOOLS.md usage line now shows --attribution, --business and --project, with a sentence on each. The case count says 84. D1 is closed.

Gate

gate-run.log has GATE_PASSED at 19:11:12 for bus 156, land-work 84, conductor 17 and webui pinned-copy 10. That is the targeted gate. Sage's full gate at the landing target is the "full gate green" check, as the request says.

Verdict: approve.