jason.woltje
b9ea9304fd
Unclaimed files left in the canonical checkout. Inventory: canonical-cleanup-inventory.md (commit-as-evidence groups). detect-secrets scan clean on 2026-11-02: hits are sha256 pins, git object ids, test sentinels already in tracked tests and unit-file lines.
1 line
2.8 KiB
JSON
1 line
2.8 KiB
JSON
{"body":"## Filbert review, row 125 round 3: approve\n\nCandidate manifest `8b71c405ed2365e2cf62eab8f8863535025c5bd4f037db5870b9c59a704bfe56` (38 paths). I applied `build.patch` (`2d310327...`) with `--index` to the new base `cfde62f9f`, where row 164 landed as `008746b6e`. The manifest matched before and after the run.\n\nThis round is a rebase, and I confirm it changes nothing beyond the rebase and my round 2 doc follow-up.\n\n### The rebase\n\n- **Per path.** I compared the `+` and `-` lines of the round 2 patch (`0efb5cb6...`) and the round 3 patch path by path. 37 of 38 paths are identical. The only difference is `docs/TOOLS.md:621`, which now reads `limits reset WORD... [--business ID]`. That closes my round 2 doc-only follow-up.\n- **No 164 line taken away.** None of the lines row 164 added appears among the round 3 patch's `-` lines.\n- **`packages/plugins/tests/kinds.test.mjs:9-10`.** Against `cfde62f9f`, the only changes are row 125's: the test title, and `limit-check` at interface 2 in 164's key list, which keeps `\"channel\"`.\n- **`packages/plugins/README.md`.**\n - \"## Limit checks (row 125)\" (`:138`) is round 2's section, except for one blank line. That blank is the separator before 164's section; in round 2 the file ended after the section.\n - \"## Human project/thread channels\" (`:196` to the end) is byte-identical to `cfde62f9f`.\n - The kinds table gains only 164's `channel` row.\n\n The base line \"PRD REQ-LIMIT-4 says what the two kinds do\" predates this row and isn't part of this review.\n\n### Ran by me\n\nSlot from sage-0873. The busy check was CLEAR first. TMPDIR was in my own scratch, and DOCKER_HOST pointed at a dead socket.\n\n- **Singles, 19:54:23Z to 19:55:55Z**, one `node --test` per file, 33 files. These were my round 2 set of 21, plus 12 more test files in the areas row 164 changed:\n - bus: limit-checks 16/16, limit-stop 5/5, limits-runtime 5/5, process 8/8, usage 14/14, channel-proof 2/2;\n - business: token-limit-settings 4/4, launch-settings 8/8;\n - cli: launch-limit-checks 4/4, launch-limits 1/1, limits-tokens 4/4, limits 4/4, host 41/41, thread-launch 10/10, channel-cli 2/2, channel-recovery 1/1, project 4/4, thread-cli 11/11;\n - harness: runner 26/26, tools 20/20;\n - plugins: kinds 5/5, loader 17/17, token-limit 10/10, channel 13/13;\n - webui: limits-browser 1/1, limits-route 4/4, shell 5/5, bus-browser 2/2, browser 1/1, channel-chat 3/3, chat-browser 11/11, chat 22/22, views 3/3.\n\n The awk sum is 287/287 over 33 files, with 0 skipped.\n\nI ran no mutants and no package suites this round.\n\n### Not mine\n\nDewey's round 3 run (BUILD.md \"## Round 3\"):\n- the 17 singles at 145/145;\n- `mutants.mjs check` (anchors only, no tests) with 81 mutants and 0 problems.\n\nI did not rerun those. The full gate is Sage's at landing.\n"} |