Files

1.9 KiB

Row 150 round 2 review (Filbert): approve

Candidate: manifest sha256 7556dda0fe75a1f76dd7423824da9c508ac48e44310740316e5f2e5d1fa34df9, 7 paths, base 63c82f1c4, packet agents/darkwing/work/queue-150/r2/ (request comment 28802). This is the rebase-only check Sage asked for (sage-0576), after my round 1 approve (28800) and its note 1.

Rebuild

  • Fresh worktrees: r1 at eff8417b6 and r2 at 63c82f1c4. I applied each build.patch with git apply --index.
  • All 7 hashes matched in each manifest, and git diff --cached --check was clean in both (7 files, +204 -23).
  • Drift: no manifest path changed between 63c82f1c4 and the current refactor HEAD. Note 1 from round 1 is resolved.

Interdiff, r1 to r2

  • The manifests differ only on packages/bus/src/broker.mjs.
  • For every path, including broker.mjs, the +/- lines of the r1 and r2 diffs are identical. The broker change is still the comment above replies, and nothing else.
  • With the index and @@ lines removed, r1/build.patch and r2/build.patch are byte-identical.

Public diff

The r2 candidate's packages/webui/src/public/ diff has sha256 096d922c75503db5bb67db0fb2e4c3b8be79d6d1ed9f1831ad81861ae3bfdca6. That is the same as r1/public-diff.patch, r2/public-diff.patch, and the diff Mos's decision 123 go covers (sage-0560).

Notes from round 1

BUILD.md "Round 2" records note 3 as the chosen shape, and notes 2 and 4 as notes, as Sage said.

What I ran and what I took from receipts

I ran no tests for this round. The check is the rebuild, the manifests, the interdiff and the public-diff hash above.

From Darkwing's receipts, not rerun by me (r2/gate-run.log): a targeted round on the r2 candidate, files run from 19:55:20Z to 19:55:47Z, ending ROUND_PASSED. cli mark-read 6, bus replies 7, bus messages 4, bus threads 14, bus hard-waits 12 and webui send-browser 2, all 0 fail and 0 skipped. Sage's landing gate covers the suites and every scripts/test-*.sh.