Files

3.3 KiB

Filbert review, row 154 round 5: approve

Candidate manifest 3a4bc21c9a8170667b0b36503195bf631b735f5e728ab7e9c9cd8974ccce3b05 (195 paths). I applied rebase-d88613bac/candidate.patch (bdd046abbeca...) with --index to d88613bac. All 195 manifest lines matched, and the diff is +49359 -29 over 195 files. git diff --cached --check reports 4 trailing-whitespace lines, all in vendored upstream source (third_party/editor/prosemirror-state/src/state.ts:201 and prosemirror-view/src/viewdesc.ts:10,12,120). It reports none in the hand-written files.

This round is a rebase only, and I confirm it changes nothing else. My last verdict was round 3 (28986, manifest cebca514... on 850484a7d). Round 4 (41024ac5... on 7bd2a348c) was never requested, so I compared this round with both.

The rebase

  • Base. From 850484a7d to d88613bac, three commits change manifest paths: aa625565f (row 125), 7e7f8e208 (row 162) and b2f57ca70 (row 155). From d88613bac to HEAD 5e2a1bc11, only docs/plans/ files change.
  • Patch.
    • The path list is byte-equal to round 3's.
    • Against both the round 3 and round 4 patches, every + and - line is byte-identical. Only index lines and hunk headers changed, plus one context line: the packages/webui/README.md line after the Visual editor section is now ## Assistant settings (row 155, #1649), not ## Data and boundaries.
  • Manifest. Against both rounds, only docs/TOOLS.md, packages/webui/README.md, packages/webui/src/public/bus.js and packages/webui/src/serve.mjs changed.
  • No landed line removed. In each of those four files, the patch's - lines share none with the lines that rows 125, 162 and 155 added (comm -12 count 0 for each file).
  • Against 155's landed bytes, the hunks don't overlap.
    • bus.js: 155's hunk is :621 (+51). The first 154 hunk moved from :679 to :730, and its context lines are unchanged.
    • serve.mjs: 154 adds only the /editor.js and /editor.css lines to the static map at :24. 155's hunks start at :50.
    • docs/TOOLS.md: 154 adds at :438, and 155's hunks start at :636.
    • README.md: the order is now row 148's Spec and docs editor, row 154's Visual editor (:514), row 155's Assistant settings (:567), then Data and boundaries (:597).
  • Public diffs. In the applied tree, git diff --cached of the four public/ files hashes to 902f02448ea7...505b, and of bus.js and index.html alone to ea59079ee44d...ec75. Those are the public.diff and public-handwritten.diff digests Sage named for Mos's decision 123 go.
  • Hash pins. No pin in packages/*/tests or scripts/test-*.sh names a non-test manifest path. channel-proof.test.mjs:14 pins packages/webui/src/bus.mjs, which this row doesn't touch.

My round 3 verdict (28986) carries over unchanged.

Ran by me

Nothing. I used no slot this round.

Not mine

Researcher's run on this base, 21:31Z to 21:36:17Z, with the counts as Sage relayed them in sage-0925 (logs in rebase-d88613bac/):

  • singles 36/36;
  • the full webui suite 221/221;
  • channel-proof 2/2;
  • browser 1/1;
  • 7 mutants killed;
  • sha256sum 195/195.

Sage's note also says the first run stopped once at board-held.test.mjs:163, which also failed on the plain 155 tree (P19 366). I did not rerun any of it. The full gate is Sage's at landing.