Files

2.2 KiB

Row 70 round 2 review (Filbert): approve

Candidate: manifest sha256 098b9aefe830c53173f0b673705e2fddfa5b49a9ba23903a045bf72d8875604e (4 paths), base 48b893871, packet agents/sage/work/queue-70/r2/ in 4a34fb0d6.

Rebuild: a fresh worktree at 4a34fb0d6 (current refactor) with the r2 build.patch applied. Every manifest hash matched, git diff --check was clean and bash -n scripts/mosaic passes. The added lines have no dash, curly-quote or control characters. The packet manifest checks. No commit from 48b893871 to 4a34fb0d6 touches a manifest path.

I rebuilt round 1 on my own git archive of 48b893871 and diffed it against round 2. The changed lines match delta.patch exactly.

Round 1 findings (28598)

Finding Status How I checked
F1 scripts/mosaic header omits mosaic-old Fixed The header now says "On Jason's host the estate CLI it replaced is mosaic-old." Every + and - line in scripts/mosaic against the base starts with # , so no code line moved.
Doc-only 1, TOOLS.md Fixed It names mosaic-old and links ../packages/cli/README.md#one-pinned-copy-row-85-1579. The path resolves from docs/, and the anchor matches the heading at packages/cli/README.md:466.
Doc-only 2, seat README Fixed It links ../../docs/TOOLS.md#stack-copies-scriptsstack-copysh. The path resolves from packages/seat/, and the anchor matches TOOLS.md:276.
Test comment note Fixed It now says lines that start with # are left out, and that the shebang and other lines stay in. The filter code is unchanged.

What I ran

As a single file with TMPDIR set and Docker disabled: queue dispatch, 4/4.

These mutants ran on round 2's scripts/mosaic:

  • Dropping REPO=, set -euo pipefail, the shebang or the seat exec each fail "the pre-A2 fixture is the script A2 changed" and name the missing line.
  • Commenting out the set line as # set -euo pipefail also fails.
  • Dropping the new mosaic-old header line passes, as intended.

I restored the file and rechecked the manifest afterwards.

From Sage's receipts, not rerun by me: the round 1 gate (24 suites, 0 failed). Round 2 changes comments and Markdown only, and the landing gate reruns everything on HEAD.

I took no slot.