stack/agents/filbert/work/queue-87/r7/body.md at dev-console

0 Fork 1

Files

T

jason.woltje b9ea9304fd lead: commit filbert's untracked evidence (273 files: queue-101 queue-102 queue-105 queue-107 queue-108 queue-109 queue-110 queue-112 queue-113 queue-114 queue-115 queue-116 queue-119 queue-120 queue-122 queue-123 queue-125 queue-126 queue-128 queue-129 queue-130 queue-131 queue-132 queue-133 queue-134 queue-135 queue-136 queue-137 queue-139 queue-140 queue-141 queue-142 queue-145 queue-146 queue-147 queue-148 queue-149 queue-150 queue-151 queue-152 queue-153 queue-154 queue-155 queue-156 queue-162 queue-163 queue-165 queue-166 queue-167 queue-169 queue-170 queue-175 queue-177 queue-181 queue-182 queue-184 queue-185 queue-186 queue-187 queue-188 queue-49 queue-64 queue-66 queue-70 queue-71 queue-80 queue-84 queue-85 queue-87 queue-88)

Unclaimed files left in the canonical checkout. Inventory: canonical-cleanup-inventory.md (commit-as-evidence groups). detect-secrets scan clean on 2026-11-02: hits are sha256 pins, git object ids, test sentinels already in tracked tests and unit-file lines.

2026-11-02 15:05:14 -06:00

2.5 KiB

Raw Permalink Blame History

Filbert review, row 87 round 7: approve.

Candidate: commit 4c1fee85a (4c1fee85a5), diff from 80ebe2afc on the design docs/plans/2026-10-18_containerized-install-design.md and the rows docs/plans/2026-10-18_containerized-install-rows.md. Line numbers are at 4c1fee85a.

No test reads either file (grep -rlF containerized-install packages/*/tests scripts/test-*.sh finds nothing), so under decision 137 nothing here blocks.

My round 6 follow-up (28883): answered

design.md:156-158 names the order: host.lock, the store path, the rootless check, the leftover rule, then docker run. The rootless check it points to is in section 4 (design.md:361-402, the name=rootless element rule at :372). The store path bullet now says "right after host.lock" (:159).

The rest of the round

Wait by id (design.md:274-292). After docker stop -t, the rule waits until each listed id answers "no such container", bounded by the core stop timeout. Then it runs rm -f with the same wait, then exits 1 with the id. That closes the race where --rm is still removing and docker run hits the name. Tested at rows.md:489-492.
Exit codes. The unit retries exit 1 and doesn't retry exit 3: RestartPreventExitStatus=2 3 4 at packages/cli/systemd/mosaic-bus.service.in:33, with Restart=on-failure and RestartSec=15 at :31-32. So exit 1 for an engine still removing and exit 3 for a hand-made container match what the unit does. Since the name is a hash of the store path and host.lock excludes another host, a name holder without the store's labels can only be hand-made (or a 64-bit hash collision), as design.md:183-186 says.

Doc-only, follow-up

design.md:277-285: the list and docker stop are separate calls, so a leftover can be removed between them, and docker stop on that id then fails with "no such container". Say that answer from stop (or rm -f) counts as gone, so I6's builder doesn't turn it into a refusal.
design.md:280-285: say whether the bound is per container or for the whole list. With N leftovers waited one at a time, the worst case is about 3 x 45 s per container before docker run. That's fine under Type=simple with no start timeout (service.in:13), but it bears on StartLimitBurst=5 in StartLimitIntervalSec=600 (:9-10). Normally N is at most 1, so this is wording only.

Not run by me

Nothing executed. This is a read of the diff, the cited design lines and the unit template.

Verdict: approve, with follow-ups 1 and 2.

2.5 KiB Raw Permalink Blame History

My round 6 follow-up (28883): answered

The rest of the round

Doc-only, follow-up

Not run by me

2.5 KiB

Raw Permalink Blame History