stack/agents/filbert/work/queue-87/r8/body.md at dev-console

0 Fork 1

Files

T

jason.woltje b9ea9304fd lead: commit filbert's untracked evidence (273 files: queue-101 queue-102 queue-105 queue-107 queue-108 queue-109 queue-110 queue-112 queue-113 queue-114 queue-115 queue-116 queue-119 queue-120 queue-122 queue-123 queue-125 queue-126 queue-128 queue-129 queue-130 queue-131 queue-132 queue-133 queue-134 queue-135 queue-136 queue-137 queue-139 queue-140 queue-141 queue-142 queue-145 queue-146 queue-147 queue-148 queue-149 queue-150 queue-151 queue-152 queue-153 queue-154 queue-155 queue-156 queue-162 queue-163 queue-165 queue-166 queue-167 queue-169 queue-170 queue-175 queue-177 queue-181 queue-182 queue-184 queue-185 queue-186 queue-187 queue-188 queue-49 queue-64 queue-66 queue-70 queue-71 queue-80 queue-84 queue-85 queue-87 queue-88)

Unclaimed files left in the canonical checkout. Inventory: canonical-cleanup-inventory.md (commit-as-evidence groups). detect-secrets scan clean on 2026-11-02: hits are sha256 pins, git object ids, test sentinels already in tracked tests and unit-file lines.

2026-11-02 15:05:14 -06:00

1.7 KiB

Raw Permalink Blame History

Filbert review, row 87 round 8: approve.

Candidate: commit 917ef55e1 (917ef55e18), diff from 4c1fee85a on the design docs/plans/2026-10-18_containerized-install-design.md and the rows docs/plans/2026-10-18_containerized-install-rows.md. Line numbers are at 917ef55e1.

No test reads either file (grep -rlF containerized-install packages/*/tests scripts/test-*.sh finds nothing), so under decision 137 nothing here blocks.

My round 7 follow-ups (28889): both answered

design.md:285-287: a "no such container" answer from docker stop or docker rm -f counts as gone. Tested at rows.md:496-498.
design.md:293-299: each bound is per container, three core stop timeouts at most, 135 s today. Five exit-1 starts within 600 s reach StartLimitBurst=5, and then a human runs reset-failed. That matches StartLimitIntervalSec=600 and StartLimitBurst=5 at packages/cli/systemd/mosaic-bus.service.in:9-10. Type=simple is at :13.

Darkwing's V

design.md:289-293 makes the leftover refusal the one exit-1 refusal. rows.md:411-413 gives I6 the unit's ExecStart comment only. That is the right file: today's comment at service.in:25-29 says "refusals exit 3".

Note, not a change

A leftover that takes most of its 135 s means each failed start plus RestartSec=15 lasts up to about 150 s. Five such starts can't fit inside 600 s, so the limit trips only on fast failures. "Five exit-1 starts within 600 s" is accurate as worded. I mention it only so I6's docs don't promise that a stuck leftover always ends in reset-failed.

Not run by me

Nothing executed. I read the diff, the cited lines and the unit template.

Verdict: approve.

1.7 KiB Raw Permalink Blame History

My round 7 follow-ups (28889): both answered

Darkwing's V

Note, not a change

Not run by me

1.7 KiB

Raw Permalink Blame History