Files
jason.woltjeandClaude Opus 5.5 47a2925375 agents: Rocko row 138 round 2 packet r4 (#1632)
Round 2 candidate on 26a0b0fab, manifest digest e3f9a400...8f70, 43
paths. It adds tests for Dewey's D1-D4 (comment 28752), the N-a project
socket timeout fix, and the title and N-f text fixes (sage-0492).
Rocko's run: 753 package tests passed, 59/59 mutants killed. Packet
inventory 4a2a9c57...683f verifies 85/85; scanned for secrets and
binaries, none found.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-15 20:37:41 -05:00

6.4 KiB
Raw Permalink Blame History

Row 138 / #1632 — review round 2

Base: 26a0b0fab4. Detached worktree: /mnt/storage/src/mosaic-stack-rocko-138-r4. This packet supersedes r3 for review; r3 is unchanged. Scope follows Dewey's comment 28752 and Sage's sage-0492. The file-backed design, eleven grants, 3e→3f migration, runtime adapter and row 152 behavior are retained. Prior implementation/design history is in ../r3/BUILD.md and ../DESIGN-r3.md.

Changes and acceptance evidence

Item Change and owning test
D1 project-await.test.mjs injects a fake writeRecord that commits its effect then releases the caller's role before resolving. Assert outcome-unknown, no successful returned value and no record.write action.allowed receipt. This makes the authority receipt fail after the awaited effect, without changing the broker.
D2 The same file injects a readSpec that releases the role during the await. Assert not-holder, no returned content and no marker in event bodies.
D3 The same file independently flags spec content and a log subject using an injected secretCheck. Both refuse secret-refused, return no content and leave no flagged marker in events.
D4 project/tests/read.test.mjs commits a small spec with a subject of 256 KiB + 1 byte, using git commit -F with a fixture file outside the records repo. readSpec refuses project-git at its bounded log read. No argv-size workaround weakens the tested bound.
N-a server.mjs extends only the existing async project branch's socket idle timeout to 120 seconds, allowing its 100-second Git deadline to report. Existing sync, task and web branches are unchanged. spec-socket.test.mjs delays a real record.write beyond a 40 ms idle timeout and asserts the actual committed result and matching authority receipt arrive. The test failed request-timeout before the change; focused-timeout-red.log preserves that run.
Title business/tests/chief-of-staff.test.mjs now names record.write among the held actions. The exact authority assertion is unchanged.
N-f bus/README.md and this packet's MIGRATION.md name 26a0b0fab as the pinned schema tree, replacing the older equivalent 56639c99b reference. The fixture bytes and migration code are unchanged.

No other product changes. changes-from-r3.json lists the five modified prior candidate paths and one added test file. Broker, runtime, shared reader/Git runner, schema, role definitions, harness and CLI remain byte-identical to r3. Sage will track N-c, N-d, N-e and the #dispatch backstop separately.

Gate and boundaries

sage-0492 granted the shared slot. busy.sh exited 0 with CLEAR at 2026-10-16T01:34:19Z before the suites. The five package suites run serially with node --test --test-concurrency=1, DOCKER_HOST=unix:///nonexistent.sock. No Docker, browser, shell suite or live action. Sage owns the landing gate. The live 3e→3f migration remains Mos's approved re-pin window.

The 54 original exact-once mutant sites plus Dewey's D1–D4 reproductions and one N-a timeout fault are preflighted: 59 total. Each runs its owning test file in its own process group, restores source in finally, and kills descendants on timeout. A timeout, syntax error or missing module is not a valid kill. Mutant names D1–D4 preserve Dewey's identities and exact production edits. Full counts, kill table, restoration checks and process sweep follow below.

Final results

Suite Passed Failed Skipped
project 30 0 0
bus 294 0 0
business 109 0 0
harness 105 0 0
cli 215 0 0

Total 753 passed, no failures/cancellations/skips. No known flake recurred.

Mutant Result Exit
01-content-trailing-bytes KILLED 1
02-file-commit-not-head KILLED 1
03-historical-revision KILLED 1
04-reachable-history KILLED 1
05-full-commit-id KILLED 1
06-read-path-confinement KILLED 1
07-strict-utf8 KILLED 1
08-no-nul KILLED 1
09-blob-size KILLED 1
10-regular-blob-mode KILLED 1
11-project-identity KILLED 1
12-repository-validation KILLED 1
13-log-page-bound KILLED 1
14-log-truncation KILLED 1
15-human-confirmation KILLED 1
16-preserve-bom KILLED 1
17-read-argument-keys KILLED 1
18-invalid-revision-refusal-code KILLED 1
19-stale-citation KILLED 1
20-unconfirmed-citation KILLED 1
21-partial-citation KILLED 1
22-persist-spec-commit KILLED 1
23-persist-spec-path KILLED 1
24-uncited-raises-still-valid KILLED 1
25-session-author KILLED 1
26-record-spec-refusal KILLED 1
27-writer-cannot-accept-author KILLED 1
28-write-authority-before-effect KILLED 1
29-write-commit-receipt KILLED 1
30-await-only-project-effects KILLED 1
31-async-own-refusal-code KILLED 1
32-live-transient-proof KILLED 1
33-concurrent-write-refusal KILLED 1
34-read-for-every-role KILLED 1
35-writer-follows-grant KILLED 1
36-typed-spec-path KILLED 1
37-typed-writer-path KILLED 1
38-migration-runs-new-step KILLED 1
39-preserve-old-evidence KILLED 1
40-future-step-chaining KILLED 1
41-record-grant-assistant KILLED 1
42-record-grant-chief-executive-officer KILLED 1
43-record-grant-chief-financial-officer KILLED 1
44-record-grant-chief-information-officer KILLED 1
45-record-grant-chief-information-security-officer KILLED 1
46-record-grant-chief-marketing-officer KILLED 1
47-record-grant-chief-of-staff KILLED 1
48-record-grant-coder KILLED 1
49-record-grant-cto KILLED 1
50-record-grant-pm KILLED 1
51-record-grant-reviewer KILLED 1
52-no-adapter-refusal KILLED 1
53-runtime-passes-adapter KILLED 1
54-broker-import-closure KILLED 1
D1-receipt-failure-reported KILLED 1
D2-read-recheck-agent KILLED 1
D3-read-secret-check KILLED 1
D4-gitbytes-bound KILLED 1
N-a-project-socket-deadline KILLED 1

59/59 killed; no survivor, timeout, syntax or import failure. All 43 file hashes and staged blobs restored; process sweep found no runner or descendant under the worktree. Every runner exited. No Docker network was created. The clean base+patch reconstruction verifies all 43 paths using a temporary index. Candidate SHA-256: e3f9a4008c8cd0098f028aa17e9cbde8b15d3b64bc13f3ee306632070a318f70.