stack/agents/rocko/work/queue-94/r2/BUILD.md

Row 94 round 2 — rebase and review coverage (#1588)

Rocko, gpt-6.1-sol. Base: e918a915 (full id in base.txt), row 90 landed. Dewey reviews; Sage runs the landing gate; Mos's go is required before landing webui/src/public under decision 123. No candidate commit or push.

Changes from round 1

The r1 patch applies cleanly to e918a915. Row 90's requirements import/use in broker.mjs and README additions are preserved. Product behavior stays as r1; the only additional product edit moves the messages case above row 81's replies comment (Dewey ask 5).

Dewey comment 28075, asks 1–4:

• Bus test explicitly checks delivered-but-not-read is read:false.
• Text inbox test delivers a batch, reads one, then excludes that message and retains another delivered-but-not-read message. It still checks the existing JSON decision-array bytes with unread messages present.
• A browser test pins scheduled nav count updates on Tasks and Board, then clears the count after a Board refusal.
• That test also checks a messages-only 403 refuses Queue, Business and Settings before any local read; each recovers after the refusal ends.

Optional note 6: a bounded CLI test asserts plain talk leaves SIGINT handlers unchanged. It restores any mutant-added handler in finally. The spawnSync interruption window and non-blocking notes 7–10 remain follow-ups; no unrelated behavior change is included here.

Scope

The r1 BUILD.md scope additions still apply: Sage's 2026-10-12 22:47Z messages passthrough/read-route/follow approval, and 22:54Z ruling that inbox --json stays byte-compatible. This round adds tests in those owned packages plus the requested comment move only.

Verification

Focused run: 13 pass, no failures/skips/cancellations. mutants.py contains the original 27 plus all eight reviewer sites; it runs focused behavioral tests for each, restores source in finally and treats timeouts as failure. Final full gate and counts will be recorded below. Every test command uses DOCKER_HOST=unix:///nonexistent.sock under decision 127. Test slot assigned by Sage; release to Darkwing for row 91 r2 after all runs finish.

Reproduce

Create a detached worktree at base.txt, apply build.patch, and link the already pinned canonical node_modules into that tree. From its root, sha256sum -c the absolute candidate-manifest.sha256; its paths are relative to the patched repository root. Run node --test for packages/bus/tests, packages/cli/tests and packages/webui/tests (*.test.mjs); then run this packet's gate.py with an absolute output directory. Every command must set DOCKER_HOST=unix:///nonexistent.sock. mutants.py takes a separate output directory and must run without other tests using that tree.

All eight reviewer sites are mutations 28–35 in out/mutants/mutants.json, including the optional plain-talk SIGINT site. Each is killed by the focused package tests with a nonzero exit, not by timeout. Original 27 also killed. out/row90-preserved.txt verifies all 12 broker and two README lines from row 90 are verbatim in this candidate. out/broker-r1-to-r2.diff shows the broker rebase/comment move; out/drift.txt records no candidate-path drift.

Final gate

Bus 115, CLI 129, webui 104 pass, no failures/skips/cancellations. All nine scripts/test-*.sh exit 0. Full rebased gate uses the disabled Docker endpoint; shell run 2026-10-13T00:02:35.773883+00:00–2026-10-13T00:04:58.371375+00:00. 35/35 mutants killed, no timeout. Receipts: out/final/, out/mutants/, out/gate-summary.json. No remaining test process in this worktree.

Manifest 53b01ea9f65d8ec5812111701425e7c5c60bc31f36af2b42b541ae22a82cc1ad covers 16 repo-root paths. Source is uncommitted in the detached tree; canonical source remains untouched. Dewey's round 2 review, Sage's gate rerun and Mos's landing go remain.

Queue: rev 866 opens round 2; rev 867 records expected tokenless request failure. Sage/jarvis posts the request. Slot clear was sent to Darkwing for row 91 r2. Session and build logs are appended separately.