A refresh that drops the displayed request no longer hands its open requirement and focus to another request's requirement with the same local id: the restore key now carries the request id. Keyed disclosures also remember a closed state, so desktop provenance the user closed stays closed through a repaint. Adds Sol's two R3 probes as tests.
117 lines
8.2 KiB
JavaScript
117 lines
8.2 KiB
JavaScript
// Re-check findings on c0b2f7d86 (Sol, org-live-updates-recheck.md): a refresh that changes only an
|
|
// unselected request must still feed the retained selector, and requirement disclosure and focus
|
|
// follow the requirement identity when a row is inserted above it.
|
|
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { fixture } from './fixture.mjs';
|
|
import { browser } from './browser.mjs';
|
|
import { P, T, stub } from './helpers/projects-review-fixture.mjs';
|
|
|
|
async function setup(t, path='/projects/'+P, width=1440) {
|
|
const f=await fixture(), b=await browser({machine:false});
|
|
t.after(async()=>{await b.close();await f.close();});
|
|
await b.call('Fetch.enable',{patterns:[{urlPattern:'*'}]});
|
|
b.on('Fetch.requestPaused',p=>void b.call(p.request.url.startsWith(f.base+'/')?'Fetch.continueRequest':'Fetch.failRequest',p.request.url.startsWith(f.base+'/')?{requestId:p.requestId}:{requestId:p.requestId,errorReason:'BlockedByClient'}).catch(()=>{}));
|
|
await b.call('Page.addScriptToEvaluateOnNewDocument',{source:stub});
|
|
await b.viewport(width,900);
|
|
await b.navigate(f.base+'/#'+path);
|
|
const run=fn=>b.evaluate('('+fn.toString()+')()');
|
|
const wait=expr=>b.evaluate('(async()=>{for(let i=0;i<200;i++){if('+expr+')return;await new Promise(r=>setTimeout(r,25))}throw Error('+JSON.stringify(expr)+')})()');
|
|
const render=path=>{const canonical=path==='/projects'?'/chat':/^\/projects\/(threads|rooms)\//.test(path)?'/chat'+path.slice('/projects'.length):/^\/projects\/[^/]+$/.test(path)?'/chat/projects/'+path.slice('/projects/'.length):path;return b.evaluate('MosaicChat.render({path:'+JSON.stringify(canonical)+',container:document.querySelector("#bus-view"),canSend:true,navigated:false})');};
|
|
await wait('document.querySelector(".project-header")');
|
|
await run(async()=>{await new Promise(r=>setTimeout(r,150));});
|
|
await run(()=>{const before=MosaicProjects;window.MosaicProjects={...before,mountContent:options=>{const pending=before.mountContent(options);window.lastContentProbe=pending;return pending;}}});
|
|
return {f,b,run,wait,render};
|
|
}
|
|
|
|
|
|
test('refreshing an unselected request updates its next selection',async t=>{
|
|
const {run,render,wait}=await setup(t,'/projects/'+P+'/requirements');
|
|
await wait('document.querySelector("#project-request-select")?.value==="request-1" && document.querySelector("[data-prd]")?.textContent');
|
|
await run(()=>{
|
|
window.originalRequestSelect=document.querySelector('#project-request-select');
|
|
const beforeSecondFetch=fetch;window.fetch=async(url,init)=>{const response=await beforeSecondFetch(url,init);if(String(url)==='/api/requests/request-2/draft')window.latestSecondPrd=(await response.clone().json()).prd;return response;};
|
|
reviewDrafts['request-2'].prd='# UPDATED SECOND REQUEST PRD';
|
|
reviewDrafts['request-2'].requirements[0].text='UPDATED SECOND REQUIREMENT';
|
|
reviewStates['request-2'].revision++;
|
|
reviewStates['request-2'].candidate.prd_version='v5';
|
|
reviewStates['request-2'].snapshot='snapshot-request-2-r2';
|
|
reviewDrafts['request-2'].snapshot={id:'snapshot-request-2-r2',revision:2};
|
|
const now=Date.now();Date.now=()=>now+11000;
|
|
});
|
|
await render('/projects/'+P+'/requirements');
|
|
await run(async()=>await window.lastContentProbe);
|
|
const result=await run(()=>{
|
|
const field=document.querySelector('#project-request-select');
|
|
field.value='request-2';field.dispatchEvent(new Event('change',{bubbles:true}));
|
|
return {observedPrd:latestSecondPrd,sameSelect:originalRequestSelect===field,selected:field.value,prd:document.querySelector('[data-prd]').textContent,updatedRequirement:document.querySelector('[data-project-content]').textContent.includes('UPDATED SECOND REQUIREMENT')};
|
|
});
|
|
assert.match(result.prd,/UPDATED SECOND REQUEST PRD/);
|
|
assert.equal(result.updatedRequirement,true);
|
|
});
|
|
|
|
test('prepending a requirement restores focus and disclosure to its surviving identity',async t=>{
|
|
const {run,render,wait}=await setup(t,'/projects/'+P+'/requirements');
|
|
await wait('document.querySelectorAll("[data-project-content] section details").length===6');
|
|
await run(()=>{
|
|
const detail=document.querySelectorAll('[data-project-content] section details')[2];detail.open=true;detail.querySelector('summary').focus();
|
|
window.oldSummary=detail.querySelector('summary').textContent;
|
|
const candidate=reviewStates['request-1'].candidate;
|
|
const newRequirement={id:'R0',title:'New first requirement',path:'docs/r0-new.md',blob:'b-new'};
|
|
candidate.requirements.unshift(newRequirement);
|
|
candidate.prd_version='v4';
|
|
reviewStates['request-1'].snapshot='snapshot-request-1-r2';
|
|
reviewDrafts['request-1'].snapshot={id:'snapshot-request-1-r2',revision:2};
|
|
reviewDrafts['request-1'].requirements.unshift({...newRequirement,text:'New text'});
|
|
reviewStates['request-1'].revision++;
|
|
const now=Date.now();Date.now=()=>now+11000;
|
|
});
|
|
await render('/projects/'+P+'/requirements');
|
|
await wait('document.querySelectorAll("[data-project-content] section details").length===7');
|
|
const result=await run(()=>({wanted:oldSummary,focused:document.activeElement.textContent,open:[...document.querySelectorAll('[data-project-content] section details')].filter(e=>e.open).map(e=>e.querySelector('summary').textContent)}));
|
|
assert.equal(result.focused,result.wanted);
|
|
assert.deepEqual(result.open,[result.wanted]);
|
|
});
|
|
|
|
|
|
// R3 check (Sol, org-live-updates-r3-check.md): requirement state is scoped to its request, and
|
|
// a closed keyed disclosure stays closed through a repaint.
|
|
|
|
async function refresh(run,render) {
|
|
await run(()=>{const now=Date.now();Date.now=()=>now+11000;});
|
|
await render('/projects/'+P+'/requirements');
|
|
await run(async()=>{await window.lastContentProbe;});
|
|
}
|
|
|
|
test('removing the selected request drops its requirement state instead of transferring it to another request with the same local ids',async t=>{
|
|
const {run,render,wait}=await setup(t,'/projects/'+P+'/requirements');
|
|
await wait('document.querySelector("#project-request-select")?.value==="request-1" && document.querySelectorAll("[data-project-content] section details").length===6');
|
|
await run(()=>{
|
|
const detail=document.querySelectorAll('[data-project-content] section details')[2];detail.open=true;detail.querySelector('summary').focus();
|
|
reviewDrafts['request-2'].prd='# DISTINCT SECOND REQUEST';
|
|
reviewStates['request-2'].candidate.requirements[2].title='Second request distinct R3';
|
|
reviewDrafts['request-2'].requirements[2].title='Second request distinct R3';
|
|
reviewDrafts['request-2'].requirements[2].text='Only the second request owns this requirement';
|
|
fixtureMessages.splice(0,fixtureMessages.length,...fixtureMessages.filter(m=>m.request!=='request-1'));
|
|
});
|
|
await refresh(run,render);
|
|
const result=await run(()=>({
|
|
prd:document.querySelector('[data-prd]').textContent,
|
|
source:document.querySelector('.project-source').textContent,
|
|
open:[...document.querySelectorAll('[data-project-content] section details')].filter(el=>el.open).map(el=>el.querySelector('summary').textContent),
|
|
focused:document.activeElement.matches('[data-project-content] section details summary')?document.activeElement.textContent:null
|
|
}));
|
|
assert.match(result.prd,/DISTINCT SECOND REQUEST/);assert.match(result.source,/request-2/);
|
|
assert.deepEqual(result.open,[]);assert.equal(result.focused,null);
|
|
});
|
|
|
|
|
|
test('closed desktop provenance remains closed through a requirement content change',async t=>{
|
|
const {run,render,wait}=await setup(t,'/projects/'+P+'/requirements',1440);
|
|
await wait('document.querySelectorAll("[data-project-content] section details").length===6');
|
|
await run(()=>{const el=document.querySelector('[data-project-content] aside details');el.open=false;el.querySelector('summary').focus();reviewDrafts['request-1'].requirements[0].text='Isolated provenance repaint';});
|
|
await refresh(run,render);
|
|
const result=await run(()=>({open:document.querySelector('[data-project-content] aside details').open,focused:document.activeElement===document.querySelector('[data-project-content] aside summary'),requirementsOpen:[...document.querySelectorAll('[data-project-content] section details')].filter(el=>el.open).length}));
|
|
assert.equal(result.focused,true);assert.equal(result.requirementsOpen,0);assert.equal(result.open,false);
|
|
});
|