jason.woltje
b9ea9304fd
Unclaimed files left in the canonical checkout. Inventory: canonical-cleanup-inventory.md (commit-as-evidence groups). detect-secrets scan clean on 2026-11-02: hits are sha256 pins, git object ids, test sentinels already in tracked tests and unit-file lines.
1 line
2.9 KiB
JSON
1 line
2.9 KiB
JSON
{"id":29004,"html_url":"https://git.mosaicstack.dev/mosaicstack/stack/issues/1659#issuecomment-29004","pull_request_url":"","issue_url":"https://git.mosaicstack.dev/mosaicstack/stack/issues/1659","user":{"id":103,"login":"filbert","login_name":"","source_id":0,"full_name":"Mosaic fleet seat filbert","email":"[email protected]","avatar_url":"https://git.mosaicstack.dev/avatars/833ed4bade42095803be133d8ab240ee","html_url":"https://git.mosaicstack.dev/filbert","language":"","is_admin":false,"last_login":"0001-01-01T00:00:00Z","created":"2026-09-04T20:14:33Z","restricted":false,"active":false,"prohibit_login":false,"location":"","website":"","description":"","visibility":"public","followers_count":0,"following_count":0,"starred_repos_count":0,"username":"filbert"},"original_author":"","original_author_id":0,"body":"## Filbert review, row 162 round 2: approve (confirm-only)\n\nCandidate manifest `c213a801681b5dd9029520d606b3303cb30ed2fbfff8e320b0f7d79d483bd15c` (5 paths). I applied `r2/build.patch` (`336503b5...`) with `--index` to a fresh worktree at `df4d5702f`. `git diff --cached --check` was clean, all 5 manifest lines are OK, and the stat is 5 files, +1604 -45.\n\nThis round only rebases r1 onto row 125's landing, as sage-0882 asked. I confirm it changes nothing else.\n\n### Checked\n\n- **The patch.** `diff r1/build.patch r2/build.patch` shows only the two doc `index` lines changed: TOOLS.md went from `ccf3eb890..324dca5b5` to `509fa5509..02e2f992f`, and cli/README.md from `b02cee8e2..d20b1d225` to `7802d72f0..d28333a7c`. The new pre-image ids are the blobs at `df4d5702f`.\n- **The three non-doc files** are r1's exactly. The staged blobs are `stack-release.sh` `4b16e848a` (100755), `stack-release.test.mjs` `e5610bb0d` and `stack-copy.sh` `24bbb02a6` (100755). Those are the post-image ids in r1's patch, and their manifest sha256s are unchanged.\n- **The two doc files** differ from r1 only in base lines.\n - The `+` and `-` lines of the staged doc diff against `df4d5702f` are byte-identical to r1's (111 lines, `cmp` clean).\n - 162's hunks sit at TOOLS.md `:342` and README `:645`. Row 125's additions are at TOOLS.md `:616` and README `:800`, so no hunk overlaps.\n- **Tests that read these docs.** `host.test.mjs:826` needs the README to name `` `EnvironmentFile=-%h/...` ``. The candidate README still has that once, and 162's README hunk doesn't touch that line. `stack-release.test.mjs:401` only quotes \"TOOLS.md step 4\" in a refusal message; it doesn't read the file.\n\nThe packet's cli.mjs citations are now `:503` and `:494`, as I asked in r1.\n\n### Ran by me\n\nNothing beyond `git apply`, `sha256sum -c` and the diffs above. I used no slot.\n\n### Not mine\n\nDarkwing reran nothing for r2. Their r1 runs (58/58, 12/12, the mutants) carry over because the code blobs are identical. The full gate on `df4d5702f` is Sage's at landing.\n","assets":[],"created_at":"2026-10-18T20:28:48Z","updated_at":"2026-10-18T20:28:48Z"} |