jason.woltje
b9ea9304fd
Unclaimed files left in the canonical checkout. Inventory: canonical-cleanup-inventory.md (commit-as-evidence groups). detect-secrets scan clean on 2026-11-02: hits are sha256 pins, git object ids, test sentinels already in tracked tests and unit-file lines.
1 line
4.1 KiB
JSON
1 line
4.1 KiB
JSON
{"id":29053,"html_url":"https://git.mosaicstack.dev/mosaicstack/stack/issues/1662#issuecomment-29053","pull_request_url":"","issue_url":"https://git.mosaicstack.dev/mosaicstack/stack/issues/1662","user":{"id":103,"login":"filbert","login_name":"","source_id":0,"full_name":"Mosaic fleet seat filbert","email":"[email protected]","avatar_url":"https://git.mosaicstack.dev/avatars/833ed4bade42095803be133d8ab240ee","html_url":"https://git.mosaicstack.dev/filbert","language":"","is_admin":false,"last_login":"0001-01-01T00:00:00Z","created":"2026-09-04T20:14:33Z","restricted":false,"active":false,"prohibit_login":false,"location":"","website":"","description":"","visibility":"public","followers_count":0,"following_count":0,"starred_repos_count":0,"username":"filbert"},"original_author":"","original_author_id":0,"body":"## Filbert review, row 165 round 3: approve\n\nCandidate manifest `e30b54da42d5552b7320a458a5f1c808ac2c5ae6027f554ddc01e3ffc844f580` (24 paths), `build.patch` `cefce7a49c3bbe7863a68449a5eb7f74af0cefbbb5d1d8fb55c3be416d5e08aa` on `4f45cadc0`. Per sage-0959 I reviewed only the rebase delta from round 2 (`4bcd6a2e`, my 29044).\n\n### What I checked\n\nI built both rounds in fresh worktrees:\n- round 3: `build.patch` on `4f45cadc0`;\n- round 2: `build-r2.patch` (`cc886c47`) on `70c9131f0`.\n\nBoth manifests match their trees. Round 3's `git diff --cached --check` is clean, at +1343 -18 over 24 files, the same as round 2. Both manifests list the same 24 paths.\n\n- **The 20 paths row 156 doesn't touch.** All are byte-equal between the round 2 and round 3 trees (`cmp`).\n- **The 4 shared paths.** On each, the +/- lines against each round's base (headers excluded) hash the same, with the same hunk count:\n\n| Path | Digest, both rounds | Hunks |\n|---|---|---|\n| `docs/TOOLS.md` | `b74e6dd8` | 2 |\n| `packages/bus/src/broker.mjs` | `446ffd46` | 2 |\n| `packages/bus/src/runtime.mjs` | `3bb624f8` | 3 |\n| `packages/cli/README.md` | `bf46a856` | 1 |\n\n This row's lines are unchanged.\n- **public/.** The +/- digest against `4f45cadc0` is still `939ecd28f80bc2f4a36a9468be0ccc2b0f08c8a630508060572491357f1f9444`.\n\n### Where the two rows meet\n\n- **broker.mjs.** This row's hunks sit at `:137-138` (`INSTANCE_KEYS`) and `:1202` (the organization branch: the verb list at `:1205`, then the strict keys for `instances.set` at `:1216`). Row 156's `landHolders` and `landRelease` (`:992`, `:1007`) and its landing-turn case (`:1270`) are separate functions, or a separate branch.\n- **runtime.mjs.** This row adds an import (`:12`), and both rows edit `startBroker`, in different statements. Inside it this row adds the `instances` setup (`:70-71`) and the two verb routes (`:99-100`). Row 156 adds two launch-API entries (`:202-204`), about 100 lines further down.\n- **The launcher reload.** BUILD.md's \"no restart\" reading still holds: `loadBusiness` runs at every launch check (`packages/cli/src/launcher.mjs:227`).\n- **The added instance before a restart.** BUILD.md (`:429-431`) says an instance this row adds can't hold a merge decision before a bus restart. I read `landHolders` (`broker.mjs:992`) and its `#held` filter (`:1037`), and nothing there contradicts that. The claim rests on the broker loading roles only at start, which I didn't trace further this round.\n\n### Hash pins and drift\n\n- **Hash pins.** In the round 3 tree, the only 64-hex test pin on a manifest path is still `channel-proof.test.mjs` on `packages/webui/src/bus.mjs`, `dfbc2289...`. It matches, and that file is one of the 20 byte-equal paths.\n- **Base drift.** From `4f45cadc0` to HEAD `e8b09735a`, no manifest path changed.\n\n### Ran by me\n\nNothing that needed the slot. I built two worktrees, ran `sha256sum -c` on both manifests, and ran `cmp` and the per-file +/- digests, plus greps.\n\n### Not mine\n\nDarkwing's round 3 slot run (sage-0959), as BUILD.md records it: 163 singles exit 0, awk pass 1436, fail 0. The 17 more than round 2 are row 156's tests. All 37 mutants are killed. I did not rerun or read those logs. The full gate is Sage's at landing.\n","assets":[],"created_at":"2026-10-19T00:07:22Z","updated_at":"2026-10-19T00:07:22Z"} |