Files

2.0 KiB

Filbert review, row 162 round 2: approve (confirm-only)

Candidate manifest c213a801681b5dd9029520d606b3303cb30ed2fbfff8e320b0f7d79d483bd15c (5 paths). I applied r2/build.patch (336503b5...) with --index to a fresh worktree at df4d5702f. git diff --cached --check was clean, all 5 manifest lines are OK, and the stat is 5 files, +1604 -45.

This round only rebases r1 onto row 125's landing, as sage-0882 asked. I confirm it changes nothing else.

Checked

  • The patch. diff r1/build.patch r2/build.patch shows only the two doc index lines changed: TOOLS.md went from ccf3eb890..324dca5b5 to 509fa5509..02e2f992f, and cli/README.md from b02cee8e2..d20b1d225 to 7802d72f0..d28333a7c. The new pre-image ids are the blobs at df4d5702f.
  • The three non-doc files are r1's exactly. The staged blobs are stack-release.sh 4b16e848a (100755), stack-release.test.mjs e5610bb0d and stack-copy.sh 24bbb02a6 (100755). Those are the post-image ids in r1's patch, and their manifest sha256s are unchanged.
  • The two doc files differ from r1 only in base lines.
    • The + and - lines of the staged doc diff against df4d5702f are byte-identical to r1's (111 lines, cmp clean).
    • 162's hunks sit at TOOLS.md :342 and README :645. Row 125's additions are at TOOLS.md :616 and README :800, so no hunk overlaps.
  • Tests that read these docs. host.test.mjs:826 needs the README to name `EnvironmentFile=-%h/...`. The candidate README still has that once, and 162's README hunk doesn't touch that line. stack-release.test.mjs:401 only quotes "TOOLS.md step 4" in a refusal message; it doesn't read the file.

The packet's cli.mjs citations are now :503 and :494, as I asked in r1.

Ran by me

Nothing beyond git apply, sha256sum -c and the diffs above. I used no slot.

Not mine

Darkwing reran nothing for r2. Their r1 runs (58/58, 12/12, the mutants) carry over because the code blobs are identical. The full gate on df4d5702f is Sage's at landing.