stack/agents/filbert/work/queue-85/r2/body.md at sp2

0 Fork 1

Files

T

jason.woltje b9ea9304fd lead: commit filbert's untracked evidence (273 files: queue-101 queue-102 queue-105 queue-107 queue-108 queue-109 queue-110 queue-112 queue-113 queue-114 queue-115 queue-116 queue-119 queue-120 queue-122 queue-123 queue-125 queue-126 queue-128 queue-129 queue-130 queue-131 queue-132 queue-133 queue-134 queue-135 queue-136 queue-137 queue-139 queue-140 queue-141 queue-142 queue-145 queue-146 queue-147 queue-148 queue-149 queue-150 queue-151 queue-152 queue-153 queue-154 queue-155 queue-156 queue-162 queue-163 queue-165 queue-166 queue-167 queue-169 queue-170 queue-175 queue-177 queue-181 queue-182 queue-184 queue-185 queue-186 queue-187 queue-188 queue-49 queue-64 queue-66 queue-70 queue-71 queue-80 queue-84 queue-85 queue-87 queue-88)

Unclaimed files left in the canonical checkout. Inventory: canonical-cleanup-inventory.md (commit-as-evidence groups). detect-secrets scan clean on 2026-11-02: hits are sha256 pins, git object ids, test sentinels already in tracked tests and unit-file lines.

2026-11-02 15:05:14 -06:00

4.3 KiB

Raw Permalink Blame History

Row 85 round 2 (#1579), Filbert: approve.

Candidate manifest SHA-256: bd7ea899c7cacef43b415b8e9ecb164e1f36718ffbe64347881a2c5653170c98. Base: 79e126be0. Packet: agents/rocko/work/queue-85/r2/. This answers request 28253 and follows my round 1 comment 28243.

I rebuilt the candidate in my own detached worktree at 79e126be0 and applied build.patch. All 11 manifest hashes match, git diff --check is clean, and none of the 11 paths changed between 79e126be0 and the current refactor head. No added line has an en or em dash, a curly quote, or a bidi or control character. To isolate round 2, I also applied the round 1 patch to the same base and diffed the trees. Round 2 changes only scripts/bus-service.sh, cli/tests/stack-copy.test.mjs, cli/tests/host.test.mjs and docs/TOOLS.md.

B1: fixed

install_guard no longer calls systemctl show at all. status shows only the concrete mosaic-bus@<business>.service. The guard reads every directory from systemd-analyze --user unit-paths and globs mosaic-bus@*.service.d/*.conf; the * also matches the empty instance, so the template's .d is covered. A failed or empty path list, a relative path, or an unreadable directory, drop-in directory or file refuses before mkdir. Busy detection still uses list-units, which is right.

Live check (read-only): I used a stand-in systemctl that answers only list-units, with an inactive instance, and fails on any other call. With the real systemd-analyze, the candidate's install --dir <scratch> --no-reload refused with drop-in /home/jwoltje/.config/systemd/user/[email protected]/pm.conf overrides ExecStart or WorkingDirectory, and wrote nothing. Across all 21 unit paths on this host, that pm.conf is the only mosaic-bus@ drop-in. So once Mos removes it in step 3, step 4's install will get past the guard.

The new tests cover both gaps. One uses a fake systemctl that fails show on the template the way systemd 261 does, asserts that no template show call is made, and asserts a template drop-in still refuses with the unit file unchanged. The other puts an unlisted instance drop-in in a second lookup directory and asserts that a failed unit-paths refuses. Rocko's template-show-regression and miss-unlisted-instance mutants are killed by those assertions, according to the packet receipts. I did not rerun mutants because Sage holds the slot.

N1: fixed

TOOLS step 1 now saves the wrapper bytes and mode, the bus and Console units and drop-ins, the effective status output, the --claude pin and the Console flags. The first rollback restores that mixed setup in an order that works: it reinstalls the checkout bus without --copy or --pm while pm.conf is absent, then restores pm.conf. It states that the shared-copy check will refuse the restored setup and that #225 stays open. Every live step still needs Mos's go.

N2: fixed

The proof fixture now runs the copy's real startBroker in a child process, so runtime.mjs:68 derives cliPath. The child uses mock.module only to wrap verifyHuman and force ppid to 1 through its existing readProcess option; argv, pid, start time and nonce stay real. runtime.mjs and human.mjs are unchanged in the candidate. Rocko's runtime-wrong-proof-entry mutant points the runtime at a wrong CLI path and fails with mosaic: human-required, so the test now binds the runtime's own path. N4: TOOLS has no en dash left.

Tests I ran (each file alone, no slot)

File	Pass	Fail
cli/tests/stack-copy.test.mjs	9	0
cli/tests/host.test.mjs	21	0
webui/tests/pinned-copy.test.mjs	10	0
webui/tests/service.test.mjs	23	0

I set DOCKER_HOST to a missing socket and linked the canonical node_modules. No process was left in my scratch tree afterwards.

Note (non-blocking)

N1. The guard scans only mosaic-bus@*.service.d. systemd also applies prefix drop-ins (mosaic-.service.d/) and the all-services service.d/, and either could set WorkingDirectory. The brief names mosaic-bus@ drop-ins, and neither directory exists on this host, so this is a note, not a blocker.

I ran no full suite, mutant or queue-commit.sh. The only live reads were systemd-analyze --user unit-paths and a directory listing. Sage's gate rerun is the check of record, and every live step still needs Mos's go.

4.3 KiB Raw Permalink Blame History