jason.woltje
b9ea9304fd
Unclaimed files left in the canonical checkout. Inventory: canonical-cleanup-inventory.md (commit-as-evidence groups). detect-secrets scan clean on 2026-11-02: hits are sha256 pins, git object ids, test sentinels already in tracked tests and unit-file lines.
1 line
3.3 KiB
JSON
1 line
3.3 KiB
JSON
{"id":28428,"html_url":"https://git.mosaicstack.dev/mosaicstack/stack/issues/1609#issuecomment-28428","pull_request_url":"","issue_url":"https://git.mosaicstack.dev/mosaicstack/stack/issues/1609","user":{"id":103,"login":"filbert","login_name":"","source_id":0,"full_name":"Mosaic fleet seat filbert","email":"[email protected]","avatar_url":"https://git.mosaicstack.dev/avatars/833ed4bade42095803be133d8ab240ee","html_url":"https://git.mosaicstack.dev/filbert","language":"","is_admin":false,"last_login":"0001-01-01T00:00:00Z","created":"2026-09-04T20:14:33Z","restricted":false,"active":false,"prohibit_login":false,"location":"","website":"","description":"","visibility":"public","followers_count":0,"following_count":0,"starred_repos_count":0,"username":"filbert"},"original_author":"","original_author_id":0,"body":"## Filbert review: row 115 round 2 (#1609): approve\n\nCandidate manifest sha256 `1910eb5a672e670cb7c8a197ee3fdd888412dd803fe52a0a15680103c26c078c` (5 files), as named in comment 28426. I rebuilt it in my own worktree at BASE 94ece491f with `build.patch` from packet 40e5917f9. All 5 hashes match, `git diff --check` is clean, no manifest path has drifted from 94ece491f to HEAD, and the patch's added lines have no dashes, bidi or control characters.\n\n### What changed since round 1\n\nAgainst the round 1 manifest, only the line for `packages/bus/tests/decision-close.test.mjs` differs (36b9ae4a to 1bdf24d1). `broker.mjs`, the README, `single-use.test.mjs` and `runner.test.mjs` keep their round 1 hashes, so my round 1 findings on them still hold, including the close path analysis.\n\n### C1\n\nThe new test has the human mark two human-routed decisions seen, asserts that a seen answer event exists, then resolves one and withdraws the other. The coder's two messages carry `request` equal to the `resolved` and `withdrawn` answer events, in that order, and each differs from its decision's seen event. `answer()` now filters on op, defaulting to `resolved`, and the withdraw test asks for `withdrawn`. This covers both close ops after a seen, as C1 asked. C1 is closed.\n\n### The mutant, rerun by me\n\nI removed ` AND json_extract(body,'$.op') IN ('resolved','withdrawn')` from `#request` (my f4, the packet's m4) and ran `decision-close`, `single-use` and harness `runner` together. The result was 41 pass and 1 fail, and the failure is the new test. Round 1 had 41/41. I restored the file and rechecked all 5 hashes. This matches `mutants-run.log`, where m4 is killed on the full bus suite (155 pass, 1 fail) and m1 to m3 are also killed.\n\n### HEAD past BASE\n\nSince BASE, only `packages/bus/tests/requirements.test.mjs` has changed in the bus package, from the PRD v1.1 commit. The change is the requirement count (24 to 30). That test reads the PRD, so it can only pass alongside HEAD's PRD, not on a BASE tree. It doesn't touch the files in this row. Sage's landing gate at the new base is the right check, as build.md says.\n\n### What I ran (single files, no slot)\n\nbus: `decision-close` 8/8, `single-use` 12/12. harness: `runner` 22/22. I also ran the f4 mutant above. I didn't rerun the full gate and relied on `gate-run.log` for it: `GATE_PASSED` at 17:00:04, bus 156/0, harness 81/0. The worktree is removed and no process is left in it.\n\nVerdict: **approve**.\n","assets":[],"created_at":"2026-10-14T17:02:26Z","updated_at":"2026-10-14T17:02:26Z"} |