6.0 KiB
TERRA §3 — Probe-3 Bounded-Repair Re-Review v12
Verdict: PASS — static byte review only. No harness, broker, socket, or fixture state was launched or created.
Reviewed object (GUARD 1)
- Branch:
feat/827-gate0-probe - reviewed object =
ca7b522e7beb09fbff64485510201b372d305d34 - v11 baseline:
93a5fd018d26f16aa58a3ec1afc0c9bc83935fed - Harness:
docs/compaction-refresh/probes/p3_d4_focused_run.py - Verified harness SHA-256:
92ff11bd35a72c3bda8f9722837cd9058a711f688cc75bf5e5df106645f81553 - Pre-audit reviewed:
docs/compaction-refresh/reviews/GATE0-PROBE3-PREAUDIT-v12.mdat the reviewed object.
Fresh git fetch origin feat/827-gate0-probe -q resolved both local HEAD and origin/feat/827-gate0-probe to the reviewed full SHA before the object hash was trusted.
Null-delta gate
(a) Exact authorized diff — PASS
The exact harness diff from v11 has 1 insertion, 1 deletion, one zero-context hunk only:
@@ -484 +484 @@ def gated_launcher_precondition(
- "initialize_runtime_generation(generation_file, generation)",
+ "initialize_generation: Callable[[Path, int], None] = initialize_runtime_generation",
No other harness hunk or line changed. This is the authorized diagnostic behavior_markers entry at L484.
(b) B5–B9 / D4 security-bearing bytes — PASS
The sole hunk is old/new L484, inside the diagnostic marker tuple (L481–489), and does not intersect B5–B9 assertion/control or D4 logic ranges. Independent slice SHA-256 comparisons from v11 to the reviewed object were identical:
| Surface | Range | SHA-256 on both revisions |
|---|---|---|
| B5–B9 controls before marker tuple | L351–L480 | 85eda967698af5699593daa12f761abd4b759a11a03323dc867905d286455aec |
| B5–B9 controls after marker tuple | L490–L575 | b92bd920d896450f89a14979dd9a557a82ad590d7c9a73e900ebc89979a48986 |
| D4 generated lifecycle extension | L159–L251 | 4bdc047f7494029d951763555a797103ca25da647b255b287378771d20da209b |
D4 runtime assertions (lease_anchor_registered included) |
L579–L672 | ddaae13f0302b401ada76f1c96b9f66f2938d7afa614928f4cffb187da832856 |
D4 orchestration / --runs parser |
L749–L849 | a28c36296b2ba8fffe77912b7e25b793047393bae79a9242df1727bd21ab2f92 |
Therefore the diagnostic-only L484 hunk is non-intersecting and all B5–B9/D4 security-bearing bytes are byte-identical to v11.
Hardened-marker correctness — PASS
- The replacement is exactly
initialize_generation: Callable[[Path, int], None] = initialize_runtime_generation. - The exact string is byte-present in the pinned launcher at
f400830738998db105107a2a4c69c7f2a2a6fd5d:packages/mosaic/framework/tools/lease-broker/launch-runtime.py:49. - The same launcher imports the real function at L15 and invokes the DI-bound parameter at L90; the marker consequently proves the real helper binding, not merely a same-named call.
- Pinned launcher SHA-256 was independently verified as
e950e4224e280f16979d90cabb89aa1896c5ee28bed2df957e14d018d43cda82.
Pre-audit independently re-verified — PASS
All remaining precondition checks pass against the real pinned closure bytes:
| Requirement | Satisfying real bytes |
|---|---|
| Remaining launcher markers | registration action L77; DI binding L49; fixture socket env lookup L70; fixture generation path L89; generation-file env assignment L98; exec L101. |
| Generation markers | lease_generation.py at f4008307: read_runtime_generation L78 and bump_runtime_generation L90; SHA-256 061625402f08488eac47acd23272904e71fd1a71fd15b3bdab158632c801be4c. |
| Pinned broker closure | p3_generation_broker.py at 23c0caca: explicit generation-module load L29–41; fixture socket bind/permissions L46–63; fixture-parent generation-file guard L71–75; SHA-256 4db4fef1ac6658a8ca79ad5091cefc901d2aa26003265c3d6726c294cf895cad. |
| Harness path/socket checks | Fixture broker socket equality and no inherited generation file: L452–455; all ten fixture-relative variables: L456–471; temporary-root socket requirement: L473–474. |
| Fixture construction satisfying those checks | Fixture paths/environment L675–736; root-owned workspace/sessions, socket, logs, and extension construction L749–759. |
| Complete pinned closure and hash gates | Exact three-object selection and SHA gate L397–433; materialized pinned files L435–443. |
The six remaining launcher marker substrings and both generation-function substrings were independently checked as byte-present in the pinned objects. Thus no remaining marker or path/socket precondition has a static mismatch with the real closure.
Required unchanged / absent checks
- SHA pins: L41–L43 byte-identical (
7396f46357620118d3da27aa074d422186600e8a4320fc0f56774439af14e877). - SHA gate / before-exec rehashes / bytecode rejection: unchanged: materialize SHA gate L426; rehashes L539/L565/L568;
reject_pinned_bytecodeL498–501. - Fixture: L704 pre-create and L709
exist_ok=Trueare byte-identical to v11 (L700–L710 slice SHA-2563137ef255435ac613fe1332138bbb13111a9d3efc502a34403b3dce21287b04e). - Flags and runs: unchanged launcher
-s -S -B(L511–L517), broker-I -S -B(L551–L556), and--runs default=3, choices=(3,)(L840). - Assertions:
lease_anchor_registeredis intact at L594–L596 in the byte-identical D4 assertion slice; no B5–B9/D4 assertion is softened, removed, or repointed. - Absent from the exact one-line harness delta: P5, P6, P2-banking, retry-laundering, and live/prod-path changes.
Guard 2 — independent authorship
These review-document bytes were authored by this reviewer session. Repair author ms-p3-fix did not author this document; this reviewer did not build or alter the harness and is not Mos.
Guard 3 — separate publication
This review is committed separately on top of ca7b522e7beb09fbff64485510201b372d305d34; its publication commit must preserve the reviewed harness object SHA-256 92ff11bd35a72c3bda8f9722837cd9058a711f688cc75bf5e5df106645f81553.
TERRA §3 v12 PASS. FIRE remains separately gated on Mos.