1e6937c488
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
Worker git-worktrees under a fresh `git worktree add` have empty node_modules/.bin (pnpm workspaces do not share node_modules across worktrees), so every gate binary (tsc/eslint/prettier/vitest) fails with a raw `sh: 1: <tool>: not found` before the QA gate suite ever runs a real check. That failure is indistinguishable from a genuine test/lint failure -- a false-red gate that was responsible for 131/147 fleet tool-errors. - plugins/mosaic-framework/src/index.ts: the injected "Git Worktree Requirement" instructions now direct every worker to run `pnpm install --frozen-lockfile --prefer-offline` immediately after `git worktree add`/`cd`, before any gate is invoked. - packages/mosaic/framework/tools/qa/qa-hook-stdin.sh: the common gate-entry seam (registered as the PostToolUse hook for every Edit/Write/MultiEdit in runtime/claude/settings.json) now preflights node_modules/.bin presence for JS/TS files and fails with an explicit "deps not installed -- run pnpm install" sentinel instead of silently letting a raw not-found surface downstream. - packages/mosaic/framework/tools/qa/test-deps-preflight.sh: new regression harness (wired into test:framework-shell) covering missing node_modules/.bin, empty node_modules/.bin, populated node_modules/.bin, and non-JS/TS skip behavior. Closes #856.
75 lines
3.8 KiB
Bash
Executable File
75 lines
3.8 KiB
Bash
Executable File
#!/bin/bash
|
|
# QA Hook handler that reads from stdin
|
|
# Location: ~/.config/mosaic/tools/qa/qa-hook-stdin.sh
|
|
|
|
set -eo pipefail
|
|
|
|
PROJECT_ROOT=$(git rev-parse --show-toplevel 2>/dev/null || pwd)
|
|
LOG_FILE="$PROJECT_ROOT/logs/qa-automation.log"
|
|
mkdir -p "$(dirname "$LOG_FILE")"
|
|
|
|
# Read JSON from stdin
|
|
JSON_INPUT=$(cat)
|
|
|
|
# Log raw input for debugging
|
|
echo "[$(date '+%Y-%m-%d %H:%M:%S')] Hook triggered with JSON:" >> "$LOG_FILE"
|
|
echo "$JSON_INPUT" >> "$LOG_FILE"
|
|
|
|
# Extract file path using jq if available, otherwise use grep/sed
|
|
if command -v jq &> /dev/null; then
|
|
# Try multiple paths - tool_input.file_path is the actual structure from Claude Code
|
|
FILE_PATH=$(echo "$JSON_INPUT" | jq -r '.tool_input.file_path // .tool_response.filePath // .file_path // .path // .file // empty' 2>/dev/null || echo "")
|
|
TOOL_NAME=$(echo "$JSON_INPUT" | jq -r '.tool_name // .tool // .matcher // "Edit"' 2>/dev/null || echo "Edit")
|
|
else
|
|
# Fallback parsing without jq - search in tool_input first
|
|
FILE_PATH=$(echo "$JSON_INPUT" | grep -o '"tool_input"[^}]*}' | grep -o '"file_path"[[:space:]]*:[[:space:]]*"[^"]*"' | sed 's/.*"file_path"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/' | head -1)
|
|
if [ -z "$FILE_PATH" ]; then
|
|
FILE_PATH=$(echo "$JSON_INPUT" | grep -o '"file_path"[[:space:]]*:[[:space:]]*"[^"]*"' | sed 's/.*"file_path"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/' | head -1)
|
|
fi
|
|
if [ -z "$FILE_PATH" ]; then
|
|
FILE_PATH=$(echo "$JSON_INPUT" | grep -o '"filePath"[[:space:]]*:[[:space:]]*"[^"]*"' | sed 's/.*"filePath"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/' | head -1)
|
|
fi
|
|
TOOL_NAME=$(echo "$JSON_INPUT" | grep -o '"tool_name"[[:space:]]*:[[:space:]]*"[^"]*"' | sed 's/.*"tool_name"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/' | head -1)
|
|
if [ -z "$TOOL_NAME" ]; then
|
|
TOOL_NAME=$(echo "$JSON_INPUT" | grep -o '"tool"[[:space:]]*:[[:space:]]*"[^"]*"' | sed 's/.*"tool"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/' | head -1)
|
|
fi
|
|
[ -z "$TOOL_NAME" ] && TOOL_NAME="Edit"
|
|
fi
|
|
|
|
echo "[$(date '+%Y-%m-%d %H:%M:%S')] Extracted: tool=$TOOL_NAME file=$FILE_PATH" >> "$LOG_FILE"
|
|
|
|
# Validate we got a file path
|
|
if [ -z "$FILE_PATH" ]; then
|
|
echo "[$(date '+%Y-%m-%d %H:%M:%S')] [ERROR] Could not extract file path from JSON" >> "$LOG_FILE"
|
|
exit 0 # Exit successfully to not block Claude
|
|
fi
|
|
|
|
# Skip non-JS/TS files
|
|
if ! [[ "$FILE_PATH" =~ \.(ts|tsx|js|jsx|mjs|cjs)$ ]]; then
|
|
echo "[$(date '+%Y-%m-%d %H:%M:%S')] [INFO] Skipping non-JS/TS file: $FILE_PATH" >> "$LOG_FILE"
|
|
exit 0
|
|
fi
|
|
|
|
# Deps preflight (#856): this hook is the common gate-entry seam the delivery
|
|
# cycle invokes on every Edit/Write/MultiEdit — it fires before any pnpm-based
|
|
# gate (test/lint/typecheck/format:check) runs against the edited file. In a
|
|
# freshly created git worktree (pnpm workspaces do NOT share node_modules
|
|
# across worktrees), node_modules/.bin is empty until `pnpm install` has run,
|
|
# so gate binaries (tsc/eslint/prettier/vitest) fail with a raw, illegible
|
|
# `sh: 1: <tool>: not found` that is indistinguishable from a real failure.
|
|
# Fail legibly here instead, before that raw error has a chance to surface.
|
|
BIN_DIR="$PROJECT_ROOT/node_modules/.bin"
|
|
if [ ! -d "$BIN_DIR" ] || [ -z "$(ls -A "$BIN_DIR" 2>/dev/null)" ]; then
|
|
echo "deps not installed — run pnpm install" >&2
|
|
echo "[$(date '+%Y-%m-%d %H:%M:%S')] [ERROR] deps not installed — run pnpm install ($BIN_DIR is missing or empty)" >> "$LOG_FILE"
|
|
exit 1
|
|
fi
|
|
|
|
# Call the main QA handler with extracted parameters
|
|
if [ -f ~/.config/mosaic/tools/qa/qa-hook-handler.sh ]; then
|
|
echo "[$(date '+%Y-%m-%d %H:%M:%S')] Calling QA handler for $FILE_PATH" >> "$LOG_FILE"
|
|
~/.config/mosaic/tools/qa/qa-hook-handler.sh "$TOOL_NAME" "$FILE_PATH" 2>&1 | tee -a "$LOG_FILE"
|
|
else
|
|
echo "[$(date '+%Y-%m-%d %H:%M:%S')] [ERROR] QA handler script not found" >> "$LOG_FILE"
|
|
fi
|