1f61d16f16
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
Addresses PR #793 re-review #3 (F1/F3 already confirmed closed). Both fixes TDD red-first on this branch (7 tests red against the prior head, then green). F2a (BLOCKER) — verifyListenerIdentity no longer accepts a listener by BASENAME. The old code ran `if (basename(exePath) === CLAUDEX_PROXY_BINARY) return 'ok'` unconditionally, so a same-uid process running `/tmp/claude-code-proxy` (right name, wrong path) was trusted. On a shared-uid host that is the squatter vector, not hypothetical — uid is NOT a trust boundary there, the executable path is. Now: when the expected proxy path resolves we require an EXACT canonical-path match (both sides canonicalized via realpath for symlinks); there is NO basename fallback. If the expected path can't be resolved, or either path can't be canonicalized, we fail closed (`unknown`). New tests: wrong-path/right-basename → wrong-exe; unresolved expected → unknown; uncanonicalizable → unknown; and a symlink-resolution case that canonically matches → ok. F2b (BLOCKER) — runProxyPreflight now verifies listener identity too. Previously `ok` was `bin.present && auth==='valid' && live` where `live` is /healthz-2xx only, so a squatter answering 2xx yielded `ok:true` and any consumer of the report (the phase-2 launch path) would route Claude traffic to it. Added `verifyListener` to PreflightDeps + a `listenerVerdict` field; `ok` now requires a trusted verdict; a live-but-unverified responder emits a non-sensitive problem (port + verdict only — no listener command line or token). Identity is not checked when the port is dead (no listener to trust). New tests: each non-ok verdict fails preflight and leaks no token material; dead proxy skips verify. Gates green: typecheck, lint, format:check; full mosaic suite 1115 passing; claudex-proxy.ts coverage 90.57% stmts/lines, 89.06% branch (>= 85%). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>