2.2 KiB
from, to, utc
| from | to | utc |
|---|---|---|
| usc | all | 20260720T061944Z |
MS-LEAD to Mos (cc homelab): #812 ROUND-3 RE-REVIEW = the ANTI-SPIRAL trigger you pre-authorized. ms-812-review (DETACHED wt @571b65d3, symbolic-ref rc=1, author != reviewer). BOTH round-2 concrete blockers FIXED and independently confirmed:
- AC1 subpath-slug PASS: get_gitea_repo_slug_for_url derives the prefix from the RESOLVED configured URL (not a literal); clone https://host/gitea/owner/repo.git + base https://host/gitea -> owner/repo; POST+GET under /gitea/api/v1/repos/owner/repo, doubled /repos/gitea/owner/repo REJECTED. Committed subpath regression RED at round-2
1b190201-> GREEN at head (reproduced). - Non-default HTTP port case PASS (http://host:3000 host-match now succeeds).
- SSH + root-mount NON-REGRESSED; AC2-6 non-regressed; C1-5 PASS (C5 manifest-runtime deferred-to-CI, no node_modules). Codex 0.96.
NEW ROUND-4 SAME-SURFACE EDGE (reviewer flagged + STOPPED per directive, did NOT chase): detect-platform.sh:88-102 conflates an SSH transport port with the HTTP(S) provider port and normalizes default web ports asymmetrically. Two concrete repros: ssh://git@host:2222/owner/repo.git fails host-match vs base https://host; https://host:443/owner/repo.git (explicit default) fails vs https://host. Codex independently found the same at 0.96.
CRITICAL SCOPE NOTE: this round-4 edge does NOT affect our deployment — our remote is https://git.mosaicstack.dev/mosaicstack/stack.git (root-mounted, IMPLICIT 443, HTTPS not SSH), so neither the SSH-port nor the explicit-:443 shape matches our config. Zero ship-pressure. The two edges with actual concrete wrong-repo impact (subpath + non-default-port) are FIXED with committed repros.
RE-SCOPE DECISION IS YOURS (you reserved it). RECOMMEND: carve the round-4 SSH-port/explicit-443 host-match edge to a #812-followup issue and SHIP THE CORE (merge 571b65d3). On your go I file the #812-followup (curl), then post the durable exact-head APPROVE-context binding via curl (pr-review still broken on main), confirm exact-head CI green, and hand you the merge. RoR sha256 2c35f5e394e8f8abc44e922a1c41ff832a09b78d340ac5cd9f53b31715de24b6 (5969B). Holding for your re-scope ruling; REQUEST CHANGES stands until you convert it to carve+ship.