fred
15644d81d4
get_gitea_login_for_host() returned the FIRST tea login matching the host. With 43 logins on this host, roughly half match one server, so a seat whose own login was missing silently acted as whichever identity happened to sort first. That satisfies gate 16 mechanically (an author and a reviewer exist) while violating it (both are the same actor under two names). A seat now declares itself via MOSAIC_GIT_IDENTITY or `git config mosaic.gitIdentity`, and resolution derives the canonical login name from that identity plus the instance (`<instance>-<seat>`). If that login is absent it fails closed with a named error and the command to create it. It never borrows. Same rule on the --repo override path, which had it worse: it fell through to get_default_tea_login(), i.e. the default-marked login or, failing that, the first login of ANY host -- an identity chosen by config file order. The four callers now pass the owner so the instance can be derived. With no identity set (a human at a terminal) the old fallback is unchanged, which is the same point at which the token path stops enforcing. lane-brief.sh mapped owners straight to the SHARED `usc` / `mosaicstack` logins. The ladder now goes first there, and a seat that cannot resolve its own login exits rather than falling through to a shared one. Also adds tools/fleet/seat-logins.sh: projects seat credentials into tea logins under canonical names, so the name this code requires is one an operator can mechanically produce rather than hand-maintain. Test notes: - The suite had TWO sandbox helpers, run_in_repo and a near-copy run_in_repo2. The copy drifted: it never got the identity unset, so the suite kept failing on a provisioned seat after the original was already fixed. run_in_repo2 now delegates, so the guarantee lives in one place. - New coverage for both ladder branches (login present -> used; absent -> named error and NOTHING on stdout, proving it did not borrow the matching login sitting right there), both identity rungs, the --repo path, and explicit GITEA_LOGIN outranking the ladder. Each verified by injecting the regression it claims to catch and confirming it goes red. - test-issue-create-body-safety.sh now pins the no-identity case; its subject is body quoting, and an ambient seat identity made it fail for an unrelated reason. - test-issue-close-fail-closed.sh derives its fixture login from the runner's identity. This does not make it hermetic and does not claim to: its API-path cases need a real credential for the runner's own identity, so it passes only where the runner owns one, on this branch and on its base alike. Pre-existing, documented in the PR rather than papered over.
77 lines
2.1 KiB
Bash
Executable File
77 lines
2.1 KiB
Bash
Executable File
#!/bin/bash
|
|
# pr-view.sh - View pull request details on GitHub or Gitea
|
|
# Usage: pr-view.sh -n <pr_number> [-r owner/repo]
|
|
|
|
set -e
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
source "$SCRIPT_DIR/detect-platform.sh"
|
|
|
|
# Parse arguments
|
|
PR_NUMBER=""
|
|
REPO_OVERRIDE=""
|
|
|
|
while [[ $# -gt 0 ]]; do
|
|
case $1 in
|
|
-n|--number)
|
|
PR_NUMBER="$2"
|
|
shift 2
|
|
;;
|
|
-r|--repo)
|
|
REPO_OVERRIDE="$2"
|
|
shift 2
|
|
;;
|
|
-h|--help)
|
|
echo "Usage: pr-view.sh -n <pr_number> [-r owner/repo]"
|
|
echo ""
|
|
echo "Options:"
|
|
echo " -n, --number PR number (required)"
|
|
echo " -r, --repo Repository slug (default: infer from git origin)"
|
|
echo " -h, --help Show this help"
|
|
exit 0
|
|
;;
|
|
*)
|
|
echo "Unknown option: $1"
|
|
exit 1
|
|
;;
|
|
esac
|
|
done
|
|
|
|
if [[ -z "$PR_NUMBER" ]]; then
|
|
echo "Error: PR number is required (-n)"
|
|
exit 1
|
|
fi
|
|
|
|
if [[ -n "$REPO_OVERRIDE" ]]; then
|
|
REPO_INFO="$REPO_OVERRIDE"
|
|
PLATFORM=$(detect_platform 2>/dev/null || echo gitea)
|
|
else
|
|
PLATFORM=$(detect_platform)
|
|
REPO_INFO=$(get_repo_info)
|
|
fi
|
|
|
|
if [[ -z "$REPO_INFO" || "$REPO_INFO" == error:* ]]; then
|
|
echo "Error: Could not determine repository from git origin. Run from a repo or pass --repo." >&2
|
|
exit 1
|
|
fi
|
|
|
|
if [[ "$PLATFORM" == "github" ]]; then
|
|
gh pr view "$PR_NUMBER" --repo "$REPO_INFO"
|
|
elif [[ "$PLATFORM" == "gitea" ]]; then
|
|
if [[ -n "$REPO_OVERRIDE" ]]; then
|
|
GITEA_LOGIN_NAME=$(get_gitea_login_for_repo_override "$REPO_OVERRIDE") || {
|
|
echo "Error: Could not resolve Gitea login for --repo override. Set GITEA_LOGIN or configure a default tea login." >&2
|
|
exit 1
|
|
}
|
|
else
|
|
GITEA_LOGIN_NAME=$(get_gitea_login) || {
|
|
echo "Error: Could not resolve Gitea login for remote host" >&2
|
|
exit 1
|
|
}
|
|
fi
|
|
tea pr "$PR_NUMBER" --repo "$REPO_INFO" --login "$GITEA_LOGIN_NAME"
|
|
else
|
|
echo "Error: Unknown platform"
|
|
exit 1
|
|
fi
|