jason.woltjeandClaude Opus 5.5
4acadaae4e
BUILD.md records Sage's 2026-10-11 ruling that packages/queue/tests/ dispatch.test.mjs is in scope. FOLLOWUP-transport-code.md writes up the transport's did-not-finish error with no .code, for the 10-12 batch. The candidate (manifest 93fa48c1cdfe) is unchanged. Co-Authored-By: Claude Opus 5.5 <[email protected]>
2.0 KiB
Follow-up: the transport's "did not finish" error has no code
Found while building row 55 (#1544). It is not part of row 55. Sage will
queue it with the 2026-10-12 batch. The code was already like this at
fe5c68fa.
What happens
humanTransport in packages/cli/src/transport.mjs (line 60 at
fe5c68fa) throws this when the bus CLI child errors or times out (30 s)
and no exit status comes back:
throw new CliError("outcome-unknown: the bus transport did not finish", 1);
Every other error it throws sets error.code. This one doesn't.
resolveDecision in packages/cli/src/cli.mjs checks
e.code === "outcome-unknown" to choose its sentence:
outcome unknown: the broker may have recorded it. Check mosaic inbox or mosaic trail <id> before trying again
That check misses the transport error. So if decision.resolve times out,
mosaic decide prints mosaic: outcome-unknown: the bus transport did not finish and exits 1. The exit code is right. The text is wrong: it doesn't
tell the user the decision may already be recorded, or where to look. A
retry could resolve a decision that already went through. The bus should
refuse a second resolve, but the user hasn't been told to check first.
The row 55 app is not affected. It matches the message text
(/^outcome[ -]unknown/) and shows its outcome-unknown overlay, which has
no retry.
No other check in packages/cli/src compares .code against
outcome-unknown. The launcher and notifier errors have their own codes.
Suggested fix
- Set
error.code = "outcome-unknown"on the transport's did-not-finish error, the same way the other two throws do. - Add a test in
packages/cli/tests/cli.test.mjs: a transport whosedecision.resolvethrows that error makesmosaic decideprint the "may have recorded it" sentence, exit 1. - Extend the
hangcase inpackages/cli/tests/transport.test.mjsto checke.code === "outcome-unknown".
Files: packages/cli/src/transport.mjs, packages/cli/tests/cli.test.mjs,
packages/cli/tests/transport.test.mjs.