fred
15644d81d4
get_gitea_login_for_host() returned the FIRST tea login matching the host. With 43 logins on this host, roughly half match one server, so a seat whose own login was missing silently acted as whichever identity happened to sort first. That satisfies gate 16 mechanically (an author and a reviewer exist) while violating it (both are the same actor under two names). A seat now declares itself via MOSAIC_GIT_IDENTITY or `git config mosaic.gitIdentity`, and resolution derives the canonical login name from that identity plus the instance (`<instance>-<seat>`). If that login is absent it fails closed with a named error and the command to create it. It never borrows. Same rule on the --repo override path, which had it worse: it fell through to get_default_tea_login(), i.e. the default-marked login or, failing that, the first login of ANY host -- an identity chosen by config file order. The four callers now pass the owner so the instance can be derived. With no identity set (a human at a terminal) the old fallback is unchanged, which is the same point at which the token path stops enforcing. lane-brief.sh mapped owners straight to the SHARED `usc` / `mosaicstack` logins. The ladder now goes first there, and a seat that cannot resolve its own login exits rather than falling through to a shared one. Also adds tools/fleet/seat-logins.sh: projects seat credentials into tea logins under canonical names, so the name this code requires is one an operator can mechanically produce rather than hand-maintain. Test notes: - The suite had TWO sandbox helpers, run_in_repo and a near-copy run_in_repo2. The copy drifted: it never got the identity unset, so the suite kept failing on a provisioned seat after the original was already fixed. run_in_repo2 now delegates, so the guarantee lives in one place. - New coverage for both ladder branches (login present -> used; absent -> named error and NOTHING on stdout, proving it did not borrow the matching login sitting right there), both identity rungs, the --repo path, and explicit GITEA_LOGIN outranking the ladder. Each verified by injecting the regression it claims to catch and confirming it goes red. - test-issue-create-body-safety.sh now pins the no-identity case; its subject is body quoting, and an ambient seat identity made it fail for an unrelated reason. - test-issue-close-fail-closed.sh derives its fixture login from the runner's identity. This does not make it hermetic and does not claim to: its API-path cases need a real credential for the runner's own identity, so it passes only where the runner owns one, on this branch and on its base alike. Pre-existing, documented in the PR rather than papered over.
124 lines
3.5 KiB
Bash
Executable File
124 lines
3.5 KiB
Bash
Executable File
#!/bin/bash
|
|
# pr-list.sh - List pull requests on Gitea or GitHub
|
|
# Usage: pr-list.sh [-r owner/repo] [-s state] [-l label] [-a author]
|
|
|
|
set -e
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
source "$SCRIPT_DIR/detect-platform.sh"
|
|
|
|
# Default values
|
|
STATE="open"
|
|
LABEL=""
|
|
AUTHOR=""
|
|
LIMIT=100
|
|
REPO_OVERRIDE=""
|
|
|
|
usage() {
|
|
cat <<EOF
|
|
Usage: $(basename "$0") [OPTIONS]
|
|
|
|
List pull requests from the current repository (Gitea or GitHub).
|
|
|
|
Options:
|
|
-s, --state STATE Filter by state: open, closed, merged, all (default: open)
|
|
-l, --label LABEL Filter by label
|
|
-a, --author USER Filter by author
|
|
-n, --limit N Maximum PRs to show (default: 100)
|
|
-r, --repo OWNER/REPO Repository slug (default: infer from git origin)
|
|
-h, --help Show this help message
|
|
|
|
Examples:
|
|
$(basename "$0") # List open PRs
|
|
$(basename "$0") -s all # All PRs
|
|
$(basename "$0") -s merged -a username # Merged PRs by user
|
|
$(basename "$0") --repo ddk/ai-bma # List PRs from anywhere
|
|
EOF
|
|
exit "${1:-1}"
|
|
}
|
|
|
|
# Parse arguments
|
|
while [[ $# -gt 0 ]]; do
|
|
case $1 in
|
|
-s|--state)
|
|
STATE="$2"
|
|
shift 2
|
|
;;
|
|
-l|--label)
|
|
LABEL="$2"
|
|
shift 2
|
|
;;
|
|
-a|--author)
|
|
AUTHOR="$2"
|
|
shift 2
|
|
;;
|
|
-n|--limit)
|
|
LIMIT="$2"
|
|
shift 2
|
|
;;
|
|
-r|--repo)
|
|
REPO_OVERRIDE="$2"
|
|
shift 2
|
|
;;
|
|
-h|--help)
|
|
usage 0
|
|
;;
|
|
*)
|
|
echo "Unknown option: $1" >&2
|
|
usage
|
|
;;
|
|
esac
|
|
done
|
|
|
|
if [[ -n "$REPO_OVERRIDE" ]]; then
|
|
REPO_INFO="$REPO_OVERRIDE"
|
|
# Explicit --repo is primarily for Gitea wrappers; if a git origin is present,
|
|
# still honor GitHub detection for cross-platform behavior.
|
|
PLATFORM=$(detect_platform 2>/dev/null || echo gitea)
|
|
else
|
|
PLATFORM=$(detect_platform)
|
|
REPO_INFO=$(get_repo_info)
|
|
fi
|
|
|
|
if [[ -z "$REPO_INFO" || "$REPO_INFO" == error:* ]]; then
|
|
echo "Error: Could not determine repository from git origin. Run from a repo or pass --repo." >&2
|
|
exit 1
|
|
fi
|
|
|
|
case "$PLATFORM" in
|
|
github)
|
|
CMD=(gh pr list --repo "$REPO_INFO" --state "$STATE" --limit "$LIMIT")
|
|
[[ -n "$LABEL" ]] && CMD+=(--label "$LABEL")
|
|
[[ -n "$AUTHOR" ]] && CMD+=(--author "$AUTHOR")
|
|
"${CMD[@]}"
|
|
;;
|
|
gitea)
|
|
if [[ -n "$REPO_OVERRIDE" ]]; then
|
|
GITEA_LOGIN_NAME=$(get_gitea_login_for_repo_override "$REPO_OVERRIDE") || {
|
|
echo "Error: Could not resolve Gitea login for --repo override. Set GITEA_LOGIN or configure a default tea login." >&2
|
|
exit 1
|
|
}
|
|
else
|
|
GITEA_LOGIN_NAME=$(get_gitea_login) || {
|
|
echo "Error: Could not resolve Gitea login for remote host" >&2
|
|
exit 1
|
|
}
|
|
fi
|
|
CMD=(tea pr list --repo "$REPO_INFO" --login "$GITEA_LOGIN_NAME" --state "$STATE" --limit "$LIMIT")
|
|
|
|
# tea filtering may be limited
|
|
if [[ -n "$LABEL" ]]; then
|
|
echo "Note: Label filtering may require manual review for Gitea" >&2
|
|
fi
|
|
if [[ -n "$AUTHOR" ]]; then
|
|
echo "Note: Author filtering may require manual review for Gitea" >&2
|
|
fi
|
|
|
|
"${CMD[@]}"
|
|
;;
|
|
*)
|
|
echo "Error: Could not detect git platform" >&2
|
|
exit 1
|
|
;;
|
|
esac
|