34e55d4a2e
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
Invert the framework updater from a denylist ("framework owns everything unless
preserved") to an explicit allow-list manifest ("operator owns everything unless
framework"). A path the manifest never anticipated resolves to operator-owned by
the fail-safe default, so it is structurally unreachable by any write or prune.
Root cause (#791): `mosaic update` re-seeds via `install.sh` keep-mode, whose
`rsync -a --delete` + hand-maintained PRESERVE_PATHS denylist wiped operator
paths the denylist forgot (agents/*.conf, policy/*.md, *.local.md, harvester
SOP, tools/_lib/credentials.json, unanticipated fleet files).
- framework-manifest.txt: single SSOT ([framework]/[operator], deny-wins,
UNKNOWN=>operator fail-safe), read by BOTH installers.
- src/framework/manifest.ts: pure resolver (parse/matchGlob/resolveOwnership/
frameworkSubtreeRoots/planPrune) — the testable seam.
- tools/_lib/manifest.sh: bash resolver (compiled globs, fork-free hot path),
sourced by install.sh; parity-tested against the TS resolver.
- install.sh keep mode is now manifest-driven (no --delete): overlay-copy
framework files, scoped-prune only retired framework files inside shipped
subtrees. Operator + unknown paths are never written or deleted.
- file-ops.syncDirectory gains an isOperatorOwned guard; file-adapter derives it
from the shared manifest, replacing the drifted hardcoded preservePaths.
Tests (TDD, red->green):
- HARD GATE test-upgrade-manifest-guard.sh: 10 operator sentinels (incl. an
unanticipated one) survive a keep-mode reseed byte-identical + mtime-unchanged;
retired framework file pruned; secret value absent from output. RED 31 fail on
the old installer -> GREEN 48 pass. Wired merge-blocking into CI.
- manifest-parity.spec.ts (§6.1): bash<->TS agree on 34 paths + subtree roots.
- manifest.spec.ts: 18 tests incl. planPrune property test + shipped-tree
completeness (§6.2).
- test-install-migration.sh F6 flipped: an unanticipated operator fleet file now
MUST survive keep-mode reseed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
97 lines
5.8 KiB
Bash
Executable File
97 lines
5.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# test-install-migration.sh — fixture matrix for the v2→v3 (Constitution) upgrade
|
|
# migration in install.sh. Runs the installer against throwaway MOSAIC_HOME dirs
|
|
# with MOSAIC_SYNC_ONLY=1 (file phase only — no environment-touching post-install)
|
|
# and asserts the framework-owned-overwrite + user-preserve + backup semantics.
|
|
#
|
|
# Mirrors the TS fixture suite in packages/mosaic/src/config/file-adapter.test.ts;
|
|
# both installers MUST behave identically.
|
|
#
|
|
# Usage: bash test-install-migration.sh
|
|
set -uo pipefail
|
|
|
|
FW="$(cd "$(dirname "${BASH_SOURCE[0]}")/../../.." && pwd)" # packages/mosaic/framework
|
|
INSTALL="$FW/install.sh"
|
|
DEFA="$FW/defaults"
|
|
|
|
pass=0; fail=0
|
|
chk() { if eval "$2"; then echo " ✓ $1"; pass=$((pass + 1)); else echo " ✗ $1"; fail=$((fail + 1)); fi; }
|
|
run() { MOSAIC_HOME="$1" MOSAIC_INSTALL_MODE="$2" MOSAIC_SYNC_ONLY=1 bash "$INSTALL" >/dev/null 2>&1; }
|
|
|
|
echo "install.sh v2→v3 migration fixture matrix:"
|
|
|
|
# F1 — fresh install
|
|
T1=$(mktemp -d); run "$T1" overwrite
|
|
chk "F1 fresh: CONSTITUTION/AGENTS/STANDARDS/TOOLS seeded" \
|
|
"[ -f '$T1/CONSTITUTION.md' ] && [ -f '$T1/AGENTS.md' ] && [ -f '$T1/STANDARDS.md' ] && [ -f '$T1/TOOLS.md' ]"
|
|
chk "F1 fresh: AGENTS == shipped default" "cmp -s '$T1/AGENTS.md' '$DEFA/AGENTS.md'"
|
|
chk "F1 fresh: framework-version stamped 3" "[ \"\$(cat '$T1/.framework-version' 2>/dev/null)\" = 3 ]"
|
|
|
|
# F2 — legacy install with a user-edited AGENTS.md (the sanctioned pre-constitution customization)
|
|
T2=$(mktemp -d); mkdir -p "$T2/credentials"
|
|
printf '# user-edited AGENTS pre-constitution\n' > "$T2/AGENTS.md"
|
|
printf '# my persona\n' > "$T2/SOUL.md"
|
|
printf 'token\n' > "$T2/credentials/c.json"
|
|
echo 2 > "$T2/.framework-version"
|
|
run "$T2" keep
|
|
chk "F2 legacy-edited: AGENTS overwritten to framework version" "cmp -s '$T2/AGENTS.md' '$DEFA/AGENTS.md'"
|
|
chk "F2 legacy-edited: prior AGENTS saved to .pre-constitution.bak" \
|
|
"grep -q 'user-edited AGENTS pre-constitution' '$T2/AGENTS.md.pre-constitution.bak'"
|
|
chk "F2 legacy-edited: SOUL.md preserved" "grep -q 'my persona' '$T2/SOUL.md'"
|
|
chk "F2 legacy-edited: credentials preserved" "grep -q token '$T2/credentials/c.json'"
|
|
chk "F2 legacy-edited: CONSTITUTION.md installed" "[ -f '$T2/CONSTITUTION.md' ]"
|
|
run "$T2" keep
|
|
chk "F2 idempotent: .pre-constitution.bak preserved across a 2nd upgrade" \
|
|
"grep -q 'user-edited AGENTS pre-constitution' '$T2/AGENTS.md.pre-constitution.bak'"
|
|
|
|
# F3 — user-tuned STANDARDS.md
|
|
T3=$(mktemp -d); printf '# tuned standards\n' > "$T3/STANDARDS.md"; printf '# persona\n' > "$T3/SOUL.md"; echo 2 > "$T3/.framework-version"
|
|
run "$T3" keep
|
|
chk "F3 tuned-standard: STANDARDS overwritten" "cmp -s '$T3/STANDARDS.md' '$DEFA/STANDARDS.md'"
|
|
chk "F3 tuned-standard: tuned copy backed up" "grep -q 'tuned standards' '$T3/STANDARDS.md.pre-constitution.bak'"
|
|
|
|
# F4 — unattended / no TTY (stdin closed): must complete without hanging, default to keep
|
|
T4=$(mktemp -d); printf '# persona\n' > "$T4/SOUL.md"; printf '# old\n' > "$T4/AGENTS.md"; echo 2 > "$T4/.framework-version"
|
|
MOSAIC_HOME="$T4" MOSAIC_SYNC_ONLY=1 bash "$INSTALL" </dev/null >/dev/null 2>&1
|
|
chk "F4 no-TTY: completed, AGENTS updated" "cmp -s '$T4/AGENTS.md' '$DEFA/AGENTS.md'"
|
|
|
|
# F5 — failure path must not corrupt existing data (invalid mode rejected before any file op)
|
|
T5=$(mktemp -d); mkdir -p "$T5/credentials"; printf '# orig\n' > "$T5/SOUL.md"; printf 'keepme\n' > "$T5/credentials/c.json"; echo 2 > "$T5/.framework-version"
|
|
MOSAIC_HOME="$T5" MOSAIC_INSTALL_MODE=bogus MOSAIC_SYNC_ONLY=1 bash "$INSTALL" >/dev/null 2>&1; rc=$?
|
|
chk "F5 failure: invalid mode rejected (nonzero exit)" "[ $rc -ne 0 ]"
|
|
chk "F5 failure: SOUL + credentials intact" "grep -q orig '$T5/SOUL.md' && grep -q keepme '$T5/credentials/c.json'"
|
|
|
|
# F6 — keep-mode re-seed (the `mosaic update` path) MUST preserve ALL user-owned
|
|
# fleet state — including an unanticipated file the manifest never names, which
|
|
# resolves to operator-owned by the #791 fail-safe — while refreshing the
|
|
# framework-owned schema/examples.
|
|
T6=$(mktemp -d); mkdir -p "$T6/fleet/examples" "$T6/fleet/run" "$T6/fleet/agents"
|
|
printf '# persona\n' > "$T6/SOUL.md" # makes it a recognized existing install (→ keep mode)
|
|
printf 'version: 1\nagents:\n - name: coder0\n' > "$T6/fleet/roster.yaml"
|
|
printf '{"version":1,"agents":[{"name":"json-user"}]}\n' > "$T6/fleet/roster.json"
|
|
printf 'version: 1\nagents:\n - name: not-active-roster\n' > "$T6/fleet/my-fleet.yaml"
|
|
printf 'ts=x\n' > "$T6/fleet/run/coder0.hb"
|
|
printf 'MOSAIC_AGENT_NAME=coder0\n' > "$T6/fleet/agents/coder0.env"
|
|
printf '# stale preset\n' > "$T6/fleet/examples/general.yaml"
|
|
printf '{"stale":true}\n' > "$T6/fleet/roster.schema.json"
|
|
E6=$(mktemp -d)
|
|
cp "$T6/fleet/roster.yaml" "$E6/roster-yaml.expected"
|
|
cp "$T6/fleet/roster.json" "$E6/roster-json.expected"
|
|
cp "$T6/fleet/my-fleet.yaml" "$E6/my-fleet.expected"
|
|
cp "$T6/fleet/run/coder0.hb" "$E6/run.expected"
|
|
cp "$T6/fleet/agents/coder0.env" "$E6/agent.expected"
|
|
echo 3 > "$T6/.framework-version"
|
|
run "$T6" keep
|
|
chk "F6 reseed: exact roster.yaml bytes survive keep-mode sync" "cmp -s '$T6/fleet/roster.yaml' '$E6/roster-yaml.expected'"
|
|
chk "F6 reseed: exact roster.json bytes survive keep-mode sync" "cmp -s '$T6/fleet/roster.json' '$E6/roster-json.expected'"
|
|
chk "F6 reseed: unanticipated operator fleet file survives (fail-safe, #791)" "cmp -s '$T6/fleet/my-fleet.yaml' '$E6/my-fleet.expected'"
|
|
chk "F6 reseed: per-agent env bytes survive" "cmp -s '$T6/fleet/agents/coder0.env' '$E6/agent.expected'"
|
|
chk "F6 reseed: heartbeat bytes survive" "cmp -s '$T6/fleet/run/coder0.hb' '$E6/run.expected'"
|
|
chk "F6 reseed: framework examples are refreshed" "grep -q orchestrator '$T6/fleet/examples/general.yaml'"
|
|
chk "F6 reseed: framework roster schema is refreshed" "cmp -s '$T6/fleet/roster.schema.json' '$FW/fleet/roster.schema.json'"
|
|
|
|
rm -rf "$T1" "$T2" "$T3" "$T4" "$T5" "$T6" "$E6"
|
|
echo
|
|
echo "RESULT: $pass passed, $fail failed"
|
|
[ "$fail" -eq 0 ]
|