Mos
b4b70675b6
ci/woodpecker/pr/ci Pipeline was canceled
detect_platform() and get_repo_info() both already contained the correct error path:
remote_url=$(git remote get-url origin 2>/dev/null)
if [[ -z "$remote_url" ]]; then
echo "error: not a git repository or no origin remote" >&2
return 1
fi
but that message was UNREACHABLE. Every wrapper in this directory runs `set -e`, and
outside a git repo the assignment itself returns git's 128, terminating the caller
before the -z check. The diagnostic was written and could never print.
Observed cost: `pr-review.sh -n N -r owner/repo -H host -a comment -c "..."` invoked
from a non-repo cwd exits 128 with NO stdout and NO stderr -- including when -r and -H
are supplied, the flags whose help text says "skips git-remote inference". The inference
runs first regardless. Two reviewer seats hit this tonight and correctly reported
`blocked` with no diagnostic available to report; one of them lost a full review.
Reproduced:
cd /tmp && pr-review.sh -n 1086 -r mosaicstack/stack -H git.mosaicstack.dev \
-a comment -c "x" -> rc=128, 0 bytes of output
same command from inside a repo -> rc=1, "Error: Comment required"
`|| true` matches the idiom already used at the other two call sites in this same file
(one `|| return 1`, one `|| true`), so the file was internally inconsistent: two guarded
sites, two unguarded.
test-detect-platform-outside-repo.sh asserts the MESSAGE, not merely a non-zero rc --
"rc != 0" passes on the broken build too, since 128 is also non-zero. RED on main
(128:no for both functions), GREEN here (1:yes), with an in-repo control proving the
functions still resolve normally. Enumerated on test:framework-shell.
Found-by: be-coder-08, rev0 (both reported `blocked` per Gate 8 rather than working around it)
46 lines
2.4 KiB
Bash
Executable File
46 lines
2.4 KiB
Bash
Executable File
#!/bin/bash
|
|
# Regression: detect_platform / get_repo_info must FAIL LOUDLY outside a git repo,
|
|
# not kill the caller silently.
|
|
#
|
|
# Both functions already contained the right error path:
|
|
# if [[ -z "$remote_url" ]]; then echo "error: not a git repository..." >&2; return 1; fi
|
|
# but under `set -e` -- which every wrapper in this directory uses -- the preceding
|
|
# assignment `remote_url=$(git remote get-url origin 2>/dev/null)` returns git's 128
|
|
# outside a repo and terminates the CALLER first. The message was unreachable.
|
|
#
|
|
# Observed cost: pr-review.sh invoked from a non-repo cwd exits 128 with NO stdout and
|
|
# NO stderr, even when -r/--repo and -H/--host are supplied -- the flags documented as
|
|
# "skips git-remote inference". Two reviewer seats hit this and correctly reported
|
|
# `blocked` with no diagnostic to report.
|
|
#
|
|
# The control that matters is the LOUD one: asserting "rc != 0" passes on the broken
|
|
# build too, because 128 is also non-zero. The test must assert the MESSAGE.
|
|
set -uo pipefail
|
|
fail=0
|
|
HERE="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
TMP="$(mktemp -d)"; trap 'rm -rf "$TMP"' EXIT
|
|
|
|
run_outside() { # $1=function name -> "rc:sawmessage"
|
|
local fn="$1" out rc
|
|
out=$( cd "$TMP" && bash -c "set -e; source '$HERE/detect-platform.sh'; $fn" 2>&1 ); rc=$?
|
|
printf '%s:%s' "$rc" "$(grep -qi 'not a git repository' <<<"$out" && echo yes || echo no)"
|
|
}
|
|
check() { if [ "$2" = "$3" ]; then echo " PASS $1 ($2)"; else echo " FAIL $1: got $2, want $3"; fail=1; fi; }
|
|
|
|
# $TMP is deliberately not a git repo, and must not be inside one.
|
|
( cd "$TMP" && git rev-parse --git-dir >/dev/null 2>&1 ) && { echo " SKIP scratch dir is inside a repo"; exit 0; }
|
|
|
|
echo "== outside a git repo: rc=1 AND the diagnostic is emitted =="
|
|
check "detect_platform" "$(run_outside detect_platform)" "1:yes"
|
|
check "get_repo_info" "$(run_outside get_repo_info)" "1:yes"
|
|
|
|
echo "== inside a git repo the functions still work =="
|
|
git init -q "$TMP/repo" 2>/dev/null
|
|
git -C "$TMP/repo" remote add origin https://git.mosaicstack.dev/mosaicstack/stack.git 2>/dev/null
|
|
out=$( cd "$TMP/repo" && bash -c "set -e; source '$HERE/detect-platform.sh'; detect_platform" 2>&1 ); rc=$?
|
|
if [ "$rc" -eq 0 ] && grep -qi 'gitea' <<<"$out"; then echo " PASS detect_platform in-repo (rc=0, $out)"
|
|
else echo " FAIL detect_platform in-repo: rc=$rc out=$out"; fail=1; fi
|
|
|
|
[ "$fail" -eq 0 ] && echo "OK detect-platform fails loudly outside a repo" || echo "FAILED"
|
|
exit "$fail"
|