c5a2bcc516
All checks were successful
ci/woodpecker/pr/ci Pipeline was successful
Round-2 review found the positive-path test's writeFileSync() staged a
stub cli.js/index.js at the package's REAL resolved dist/ path, and
afterEach only removed files that had NOT pre-existed — never restoring
original CONTENT for files that had. On a host with a real pre-built
dist/cli.js (ordinary `pnpm build && pnpm test`, and CI: this package's
turbo.json overrides the `test` task to depend on `build`, so CI always
builds a real dist/cli.js before running vitest), the test would silently
overwrite the real ~26KB compiled CLI with an 87-byte stub and still
report PASS. Confirmed as the exact root cause of CI1972's red `test`
step: src/cli-smoke.spec.ts execs the real dist/cli.js in the same vitest
process/run, so the clobber surfaced there.
Fix (dependency injection, not snapshot/restore):
- defaultCapabilityProbe() now takes an injectable CapabilityProbeDeps
({ resolveCliEntry }), defaulting to the real defaultResolveCliEntry()
in production — no change to the real-artifact-read guarantee.
- defaultResolveCliEntry() itself now takes an injectable ModuleResolver
(defaults to the real require.resolve), so its resolution CHOICE (bare
"@mosaicstack/mosaic" specifier vs the buggy "./package.json" subpath)
can be tested in complete isolation from real package/build state.
- The positive-path test now stages its stub cli.js in an mkdtempSync()
scratch directory and injects resolveCliEntry to point there — it never
calls the default resolver, so it structurally cannot touch the real
package's dist/. It also asserts the real dist/ path's existence is
unchanged by the test.
- The "returns null when unbuilt" test now injects a resolver pointing at
a path that cannot exist, instead of relying on this checkout happening
to be unbuilt (deterministic regardless of ambient host build state).
Verified:
- Reintroduced the R1 bug in defaultResolveCliEntry() and confirmed the
new resolver-choice test fails red against it; restored the fix (byte-
identical diff against the pre-revert file) and confirmed green.
- Built a real dist/cli.js (~26KB) via `turbo run build`, ran the targeted
specs against it, then ran the FULL `turbo run test --filter=@mosaicstack/mosaic`
CI-parity path (which builds dist/ itself per this package's turbo.json
override before vitest runs, exactly matching Woodpecker's `test` step):
77/77 test files, 1451/1451 tests passed, including cli-smoke.spec.ts
(22/22) and lease-activation-probe.spec.ts (15/15) in the SAME run.
sha256 of dist/cli.js before and after that full run: identical
(e61d8de7a2223b6578a2b733edd927707830e011f44b9d20901194c23c4a5272,
26317 bytes) — the real build artifact is untouched byte-for-byte.
- python3 -m unittest runtime_tools_unittest: 25/25 pass, including both
C-REGRESS-locked fail-closed cases.
- typecheck/lint/format:check all pass via turbo --filter=@mosaicstack/mosaic.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>