stack/agents/darkwing/work/queue-67-review/review-r2.md

Row 67, decisions read follow-up, round 2 review (Darkwing)

Issue #1560, request comment 27644, packet agents/filbert/work/queue-67/ (commit 7d032da5). Base f38b7f46. Candidate manifest sha256 4387c8d56df452f6ceeda2669bb53c141da2c8be204f32789a83b7d968a27044, 4 files, matching the request. Scope: the rebase my round 1 note 2 asked for.

Verdict: approve. The changed lines are the ones I approved in round 1 (comment 27627). Only their offsets and context moved, and each hunk sits where it should next to rows 58, 59 and 60. Nothing blocks.

Method

• A detached worktree at f38b7f46 with git apply --index build.patch (plain, no --3way needed now), then sha256sum -c on the manifest from 7d032da5: 4 OK, and again after the mutants. git diff --cached f38b7f46 there hashes the same as build.patch. No commit from f38b7f46 to c716cb7f touches the 4 paths.
• The + and - lines of round 1's build.patch (69761f73) and round 2's are identical, 106 lines, by diff.
• I read each hunk's context in the tree, then ran four test files and my five round 1 mutants (queue-67-review/r1/mutants.sh) on it.

Node v26.8.1, TMPDIR=~/darkwing-scratch/rv67r2/tmp.

The hunks

• README, line 235. The sentence is the last of the decisions paragraph, and row 60's credentials paragraph follows it. That matches my round 1 --3way preview, which put it at 238 on an older HEAD.
• broker.mjs, line 861. The comment sits after row 58's if (verb === 'tasks') line and the trail return, right above case 'decisions', as before.
• webui/tests/bus.test.mjs, line 191. The three requests follow the no-bus agents 503 check, at the end of the refusals test.
• decisions.test.mjs keeps its round 1 digest, 9477cfa7.

Row 59's new blocking: !!d.blocking (line 930) is inline in a .map, so my view-business-null target, which is indented by six spaces, still matches only line 297.

Tests and mutants

01:55:32Z to 01:55:56Z on 2026-10-12 (r2/tests-light.txt): decisions 7, agents 6, credential-status 4 and WebUI bus 9, all pass, 0 fail. Filbert's full gate on this tree is green and Sage reruns it.

My five mutants, 01:55:56Z to 01:56:12Z (r2/mutants.txt): all five fail, each on the same tests as round 1. The only count that moved is web-list-recent-only, 7 pass instead of 6, because row 60 added a test to the WebUI bus file.

Round 1 notes

Note 1 (Dewey's N1, assert that test 4's new decisions are listed) stays open; this round is a rebase only. Note 2 is resolved by this round.