Files

T

ci/woodpecker/pr/ci Pipeline failed

Details

fix(merge): round-2 CI failures — pipefail sites, verify:release mirror, format

Pipeline 2534 (018d96a), two test-step failures plus the format failure
root-caused by rev-code-01 (id 202):

1. pipefail-early-exit.test.mjs: main's window wrote the test but never
   wired scripts/*.test.mjs into its own CI, so its tools/install.sh pipes
   were never executed against it; next's test wiring runs them and flags
   two load-bearing pipes. Both rewritten pipefail-safe via process
   substitution (newest_matching_file ls|head, check_fleet_transport
   sed|head|tr|awk). Test now 7/7 locally.

2. verify-release.test.mjs: merge kept main's 9-command ci.yml sanitization
   but next's 4-command canonical stage. Canonical updated to mirror ci.yml
   exactly (9=9, order verified). upgrade-guard checked equal (4=4).

3. format: docs/reports/quality/1099-pipefail-sweep.md (from main f158be8)
   prettier-formatted under pinned 3.8.1.

Enumeration guard re-verified: population 60, enumerated 45, excluded 16.

2026-08-19 17:27:30 -05:00

12 KiB

Raw Blame History

#1099 pipefail + early-exit sweep

Baseline: df4c591ab42aa1ae62c12935fdc0e772684864a0

This is a site inventory, not a risk count. FIXED means the early-exiting consumer no longer has a piped upstream process whose SIGPIPE can become the result under pipefail. NOT-LOAD-BEARING means the pipeline status is explicitly discarded. UNREACHABLE-AND-WHY describes designed input, not a payload-size safety claim.

Tranche 1 — runtime and general scripts

Baseline site	Verdict	Construction / reason
`tools/matrix-presence-harness/run.sh:38`	FIXED	nullglob array selects the first path; no pipeline
`tools/e2e-install-test.sh:139`	FIXED	capture help completely, then grep via redirection
`tools/install.sh:312`	FIXED	NUL `mapfile` reads all roots; count != 1 reaches the named malformed-archive diagnostic
`scripts/analysis/reflect-board-history.sh:76`	FIXED	capture Git history completely, then grep via redirection
`scripts/analysis/reflect-git-history.sh:67`	FIXED	grep reads from a here-string
`scripts/analysis/reflect-git-history.sh:69`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/authentik/user-create.sh:72`	FIXED	jq `first(...)` reads the response directly
`packages/mosaic/framework/tools/git/mutate-push-guard.sh:87`	FIXED	grep `-m1` reads the file directly; downstream `cut` consumes its complete scalar output
`packages/mosaic/framework/tools/orchestrator/session-resume.sh:94`	FIXED	`mapfile` plus bounded indexed loop replaces `head` pipeline
`packages/mosaic/framework/tools/prdy/prdy-status.sh:69`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/qa/reflect-stop-hook.sh:172`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/qa/reflect-stop-hook.sh:173`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/qa/reflect-stop-hook.sh:174`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/qa/reflect-stop-hook.sh:175`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/qa/reflect-stop-hook.sh:176`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/qa/reflect-stop-hook.sh:177`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/qa/reflect-stop-hook.sh:178`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/qa/typecheck-hook.sh:16`	FIXED	Bash regex extracts the first field without a pipeline
`packages/mosaic/framework/tools/qa/typecheck-hook.sh:56`	FIXED	grep and bounded sed each read from a here-string
`packages/mosaic/framework/tools/tmux/send-message.sh:113`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/tmux/send-message.sh:124`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/wake/detector.sh:126`	FIXED	one awk reads the manifest directly and exits after the first exact key
`packages/mosaic/framework/tools/wake/detector.sh:270`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/wake/detector.sh:278`	FIXED	grep reads from a here-string
`packages/mosaic/framework/tools/wake/digest.sh:647`	FIXED	capture complete locator output, then select first line by parameter expansion
`packages/mosaic/framework/tools/wake/reconcile.sh:149`	FIXED	one awk reads the manifest directly and exits after the first exact key

Explicit withdrawn / non-load-bearing sites

Baseline site	Verdict	Reason
`tools/install.sh:182`	NOT-LOAD-BEARING	`	true` explicitly discards lookup status
`tools/install.sh:356`	UNREACHABLE-AND-WHY	`pnpm pack` writes one matching CLI tarball into a fresh directory immediately before lookup; citation withdrawn in #1099
`tools/install.sh:357`	UNREACHABLE-AND-WHY	same fresh-directory invariant for gateway tarball; citation withdrawn in #1099
`tools/install.sh:627`	NOT-LOAD-BEARING	`	true` explicitly discards lookup status
`scripts/agent/session-start.sh:70`	NOT-LOAD-BEARING	optional scratchpad lookup has `	true`
`packages/mosaic/framework/templates/repo/scripts/agent/session-start.sh:58`	NOT-LOAD-BEARING	optional scratchpad lookup has `	true`
`packages/mosaic/framework/tools/qa/qa-hook-stdin.sh:25`	UNREACHABLE-AND-WHY	withdrawn in #1099 after designed-input reachability measurement; preserved without re-litigation
`packages/mosaic/framework/tools/qa/qa-hook-stdin.sh:27`	UNREACHABLE-AND-WHY	same withdrawn designed-input finding
`packages/mosaic/framework/tools/qa/qa-hook-stdin.sh:30`	UNREACHABLE-AND-WHY	same withdrawn designed-input finding
`packages/mosaic/framework/tools/qa/qa-hook-stdin.sh:32`	UNREACHABLE-AND-WHY	same withdrawn designed-input finding
`packages/mosaic/framework/tools/qa/qa-hook-stdin.sh:34`	UNREACHABLE-AND-WHY	same withdrawn designed-input finding

Tranche 2 — non-wake test harnesses

All 22 baseline sites below are FIXED; the checked-in tranche fixture is passed through the same scanner and asserts all 22 occurrences and 21 normalized identities (the same response-split line occurs twice).

Baseline site(s)	Verdict	Construction
`systemd/user/test-fleet-units.sh:148`	FIXED	capture tmux output, then grep via redirection
`git/test-issue-comment-readback.sh:283,302`	FIXED	parameter expansion splits status/body without `head`
`git/test-pr-review-gitea-comment.sh:228`	FIXED	parameter expansion splits status/body
`git/test-lane-brief-pr-linkage.sh:72`	FIXED	grep reads from a here-string
`git/test-pr-review-repo-host-override.sh:225-226`	FIXED	grep reads from a here-string
`orchestrator/smoke-test.sh:67,72`	FIXED	parameter expansion selects first line
`orchestrator/test-board-roll.sh:99-100`	FIXED	grep reads from a here-string
`quality/scripts/test-upgrade-durable-snapshot.sh:180`	FIXED	complete sorted output is read with `mapfile`, then indexed
`quality/scripts/test-upgrade-rollback.sh:339,356`	FIXED	direct `grep -m1` file reads; cleanup captures before testing
`tmux/test-send-message-socket.sh:37,38,44-46,68,72`	FIXED	capture commands complete before redirected grep assertions
`tmux/test-send-message-verdict.sh:34`	FIXED	grep reads from a here-string

Tranche 3 — wake validation harnesses

All 26 baseline occurrences (25 normalized identities; one preimage selector occurs twice) are FIXED and mechanically bound through the wake fixture and shared scanner.

Baseline site(s)	Verdict	Construction
`wake/test-wake-digest-quarantine.sh:567`	FIXED	complete match populations are captured, then first line selected by parameter expansion
`wake/test-wake-preimage.sh:182-183,346-347`	FIXED	jq `first(...)` reads each JSONL file directly
`wake/validate-973/microtest-wake-assert.sh:153,170-171,176,204-209,233-234,251-252,286-287`	FIXED	scalar assertions use here-strings; diagnostics use non-early sed ranges; source line captured before matching
`wake/validate-973/validate-973.sh:110,119,180,182,187`	FIXED	scalar assertions use here-strings; diagnostic truncation uses consuming sed ranges

The scoped inventory is complete: 26 runtime/general + 22 non-wake tests + 26 wake tests fixed; 11 explicitly withdrawn or non-load-bearing sites retain their documented verdicts.

12 KiB Raw Blame History