d9bcdc4a8d
Skills included: - pr-reviewer: Adapted for Gitea/GitHub via platform-aware scripts (dropped fetch_pr_data.py and add_inline_comment.py, kept generate_review_files.py) - code-review-excellence: Methodology and checklists (React, TS, Python, etc.) - vercel-react-best-practices: 57 rules for React/Next.js performance - tailwind-design-system: Tailwind CSS v4 patterns, CVA, design tokens New shell scripts added to ~/.claude/scripts/git/: - pr-diff.sh: Get PR diff (GitHub gh / Gitea API) - pr-metadata.sh: Get PR metadata as normalized JSON Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
56 lines
1.4 KiB
Markdown
56 lines
1.4 KiB
Markdown
---
|
|
title: Store Event Handlers in Refs
|
|
impact: LOW
|
|
impactDescription: stable subscriptions
|
|
tags: advanced, hooks, refs, event-handlers, optimization
|
|
---
|
|
|
|
## Store Event Handlers in Refs
|
|
|
|
Store callbacks in refs when used in effects that shouldn't re-subscribe on callback changes.
|
|
|
|
**Incorrect (re-subscribes on every render):**
|
|
|
|
```tsx
|
|
function useWindowEvent(event: string, handler: (e) => void) {
|
|
useEffect(() => {
|
|
window.addEventListener(event, handler)
|
|
return () => window.removeEventListener(event, handler)
|
|
}, [event, handler])
|
|
}
|
|
```
|
|
|
|
**Correct (stable subscription):**
|
|
|
|
```tsx
|
|
function useWindowEvent(event: string, handler: (e) => void) {
|
|
const handlerRef = useRef(handler)
|
|
useEffect(() => {
|
|
handlerRef.current = handler
|
|
}, [handler])
|
|
|
|
useEffect(() => {
|
|
const listener = (e) => handlerRef.current(e)
|
|
window.addEventListener(event, listener)
|
|
return () => window.removeEventListener(event, listener)
|
|
}, [event])
|
|
}
|
|
```
|
|
|
|
**Alternative: use `useEffectEvent` if you're on latest React:**
|
|
|
|
```tsx
|
|
import { useEffectEvent } from 'react'
|
|
|
|
function useWindowEvent(event: string, handler: (e) => void) {
|
|
const onEvent = useEffectEvent(handler)
|
|
|
|
useEffect(() => {
|
|
window.addEventListener(event, onEvent)
|
|
return () => window.removeEventListener(event, onEvent)
|
|
}, [event])
|
|
}
|
|
```
|
|
|
|
`useEffectEvent` provides a cleaner API for the same pattern: it creates a stable function reference that always calls the latest version of the handler.
|