Skills included: - pr-reviewer: Adapted for Gitea/GitHub via platform-aware scripts (dropped fetch_pr_data.py and add_inline_comment.py, kept generate_review_files.py) - code-review-excellence: Methodology and checklists (React, TS, Python, etc.) - vercel-react-best-practices: 57 rules for React/Next.js performance - tailwind-design-system: Tailwind CSS v4 patterns, CVA, design tokens New shell scripts added to ~/.claude/scripts/git/: - pr-diff.sh: Get PR diff (GitHub gh / Gitea API) - pr-metadata.sh: Get PR metadata as normalized JSON Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
25 lines
532 B
Markdown
25 lines
532 B
Markdown
---
|
|
title: Use Set/Map for O(1) Lookups
|
|
impact: LOW-MEDIUM
|
|
impactDescription: O(n) to O(1)
|
|
tags: javascript, set, map, data-structures, performance
|
|
---
|
|
|
|
## Use Set/Map for O(1) Lookups
|
|
|
|
Convert arrays to Set/Map for repeated membership checks.
|
|
|
|
**Incorrect (O(n) per check):**
|
|
|
|
```typescript
|
|
const allowedIds = ['a', 'b', 'c', ...]
|
|
items.filter(item => allowedIds.includes(item.id))
|
|
```
|
|
|
|
**Correct (O(1) per check):**
|
|
|
|
```typescript
|
|
const allowedIds = new Set(['a', 'b', 'c', ...])
|
|
items.filter(item => allowedIds.has(item.id))
|
|
```
|