Skills included: - pr-reviewer: Adapted for Gitea/GitHub via platform-aware scripts (dropped fetch_pr_data.py and add_inline_comment.py, kept generate_review_files.py) - code-review-excellence: Methodology and checklists (React, TS, Python, etc.) - vercel-react-best-practices: 57 rules for React/Next.js performance - tailwind-design-system: Tailwind CSS v4 patterns, CVA, design tokens New shell scripts added to ~/.claude/scripts/git/: - pr-diff.sh: Get PR diff (GitHub gh / Gitea API) - pr-metadata.sh: Get PR metadata as normalized JSON Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
81 lines
2.0 KiB
Markdown
81 lines
2.0 KiB
Markdown
---
|
|
title: Defer Await Until Needed
|
|
impact: HIGH
|
|
impactDescription: avoids blocking unused code paths
|
|
tags: async, await, conditional, optimization
|
|
---
|
|
|
|
## Defer Await Until Needed
|
|
|
|
Move `await` operations into the branches where they're actually used to avoid blocking code paths that don't need them.
|
|
|
|
**Incorrect (blocks both branches):**
|
|
|
|
```typescript
|
|
async function handleRequest(userId: string, skipProcessing: boolean) {
|
|
const userData = await fetchUserData(userId)
|
|
|
|
if (skipProcessing) {
|
|
// Returns immediately but still waited for userData
|
|
return { skipped: true }
|
|
}
|
|
|
|
// Only this branch uses userData
|
|
return processUserData(userData)
|
|
}
|
|
```
|
|
|
|
**Correct (only blocks when needed):**
|
|
|
|
```typescript
|
|
async function handleRequest(userId: string, skipProcessing: boolean) {
|
|
if (skipProcessing) {
|
|
// Returns immediately without waiting
|
|
return { skipped: true }
|
|
}
|
|
|
|
// Fetch only when needed
|
|
const userData = await fetchUserData(userId)
|
|
return processUserData(userData)
|
|
}
|
|
```
|
|
|
|
**Another example (early return optimization):**
|
|
|
|
```typescript
|
|
// Incorrect: always fetches permissions
|
|
async function updateResource(resourceId: string, userId: string) {
|
|
const permissions = await fetchPermissions(userId)
|
|
const resource = await getResource(resourceId)
|
|
|
|
if (!resource) {
|
|
return { error: 'Not found' }
|
|
}
|
|
|
|
if (!permissions.canEdit) {
|
|
return { error: 'Forbidden' }
|
|
}
|
|
|
|
return await updateResourceData(resource, permissions)
|
|
}
|
|
|
|
// Correct: fetches only when needed
|
|
async function updateResource(resourceId: string, userId: string) {
|
|
const resource = await getResource(resourceId)
|
|
|
|
if (!resource) {
|
|
return { error: 'Not found' }
|
|
}
|
|
|
|
const permissions = await fetchPermissions(userId)
|
|
|
|
if (!permissions.canEdit) {
|
|
return { error: 'Forbidden' }
|
|
}
|
|
|
|
return await updateResourceData(resource, permissions)
|
|
}
|
|
```
|
|
|
|
This optimization is especially valuable when the skipped branch is frequently taken, or when the deferred operation is expensive.
|