Skills included: - pr-reviewer: Adapted for Gitea/GitHub via platform-aware scripts (dropped fetch_pr_data.py and add_inline_comment.py, kept generate_review_files.py) - code-review-excellence: Methodology and checklists (React, TS, Python, etc.) - vercel-react-best-practices: 57 rules for React/Next.js performance - tailwind-design-system: Tailwind CSS v4 patterns, CVA, design tokens New shell scripts added to ~/.claude/scripts/git/: - pr-diff.sh: Get PR diff (GitHub gh / Gitea API) - pr-metadata.sh: Get PR metadata as normalized JSON Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
40 lines
973 B
Markdown
40 lines
973 B
Markdown
---
|
|
title: Defer State Reads to Usage Point
|
|
impact: MEDIUM
|
|
impactDescription: avoids unnecessary subscriptions
|
|
tags: rerender, searchParams, localStorage, optimization
|
|
---
|
|
|
|
## Defer State Reads to Usage Point
|
|
|
|
Don't subscribe to dynamic state (searchParams, localStorage) if you only read it inside callbacks.
|
|
|
|
**Incorrect (subscribes to all searchParams changes):**
|
|
|
|
```tsx
|
|
function ShareButton({ chatId }: { chatId: string }) {
|
|
const searchParams = useSearchParams()
|
|
|
|
const handleShare = () => {
|
|
const ref = searchParams.get('ref')
|
|
shareChat(chatId, { ref })
|
|
}
|
|
|
|
return <button onClick={handleShare}>Share</button>
|
|
}
|
|
```
|
|
|
|
**Correct (reads on demand, no subscription):**
|
|
|
|
```tsx
|
|
function ShareButton({ chatId }: { chatId: string }) {
|
|
const handleShare = () => {
|
|
const params = new URLSearchParams(window.location.search)
|
|
const ref = params.get('ref')
|
|
shareChat(chatId, { ref })
|
|
}
|
|
|
|
return <button onClick={handleShare}>Share</button>
|
|
}
|
|
```
|