Skills included: - pr-reviewer: Adapted for Gitea/GitHub via platform-aware scripts (dropped fetch_pr_data.py and add_inline_comment.py, kept generate_review_files.py) - code-review-excellence: Methodology and checklists (React, TS, Python, etc.) - vercel-react-best-practices: 57 rules for React/Next.js performance - tailwind-design-system: Tailwind CSS v4 patterns, CVA, design tokens New shell scripts added to ~/.claude/scripts/git/: - pr-diff.sh: Get PR diff (GitHub gh / Gitea API) - pr-metadata.sh: Get PR metadata as normalized JSON Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
33 lines
753 B
Markdown
33 lines
753 B
Markdown
---
|
|
title: Combine Multiple Array Iterations
|
|
impact: LOW-MEDIUM
|
|
impactDescription: reduces iterations
|
|
tags: javascript, arrays, loops, performance
|
|
---
|
|
|
|
## Combine Multiple Array Iterations
|
|
|
|
Multiple `.filter()` or `.map()` calls iterate the array multiple times. Combine into one loop.
|
|
|
|
**Incorrect (3 iterations):**
|
|
|
|
```typescript
|
|
const admins = users.filter(u => u.isAdmin)
|
|
const testers = users.filter(u => u.isTester)
|
|
const inactive = users.filter(u => !u.isActive)
|
|
```
|
|
|
|
**Correct (1 iteration):**
|
|
|
|
```typescript
|
|
const admins: User[] = []
|
|
const testers: User[] = []
|
|
const inactive: User[] = []
|
|
|
|
for (const user of users) {
|
|
if (user.isAdmin) admins.push(user)
|
|
if (user.isTester) testers.push(user)
|
|
if (!user.isActive) inactive.push(user)
|
|
}
|
|
```
|