mosaic/stack
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

[Migration #121.6] Implement FastAPI and agent tracing instrumentation #313

New Issue
Closed
opened 2026-02-04 02:35:59 +00:00 by jason.woltje · 1 comment
jason.woltje commented 2026-02-04 02:35:59 +00:00
Owner
Copy Link

Parent EPIC: #121 - Backend Migration from Jarvis r1
Phase: 3 - OpenTelemetry Infrastructure
Estimate: 1-2 days
Dependencies: Requires #121.5 (OpenTelemetry core)

Description

Migrate automatic instrumentation for FastAPI and custom agent/tool tracing.

Source Files

  • jarvis/core/telemetry.py (FastAPI instrumentation)
  • jarvis/core/agent_tracing.py
  • jarvis/core/tool_tracing.py

Target Implementation

  • Add FastAPI auto-instrumentation
  • Implement agent operation tracing
  • Implement tool execution tracing
  • Add custom span attributes
  • Create trace decorators

Acceptance Criteria

  • FastAPI requests automatically traced
  • Agent operations traced
  • Tool executions traced
  • Custom decorators for tracing
  • Span enrichment with context
  • Unit tests (85% coverage)
**Parent EPIC:** #121 - Backend Migration from Jarvis r1 **Phase:** 3 - OpenTelemetry Infrastructure **Estimate:** 1-2 days **Dependencies:** Requires #121.5 (OpenTelemetry core) ## Description Migrate automatic instrumentation for FastAPI and custom agent/tool tracing. ## Source Files - `jarvis/core/telemetry.py` (FastAPI instrumentation) - `jarvis/core/agent_tracing.py` - `jarvis/core/tool_tracing.py` ## Target Implementation - Add FastAPI auto-instrumentation - Implement agent operation tracing - Implement tool execution tracing - Add custom span attributes - Create trace decorators ## Acceptance Criteria - [ ] FastAPI requests automatically traced - [ ] Agent operations traced - [ ] Tool executions traced - [ ] Custom decorators for tracing - [ ] Span enrichment with context - [ ] Unit tests (85% coverage)
jason.woltje added this to the M4-LLM (0.0.4) milestone 2026-02-04 02:35:59 +00:00
jason.woltje commented 2026-02-04 20:26:19 +00:00
Author
Owner
Copy Link

Issue #313 successfully implemented and merged to develop (commit 6de631c).

Implementation Summary

Added comprehensive OpenTelemetry distributed tracing to the coordinator FastAPI service.

Features Delivered:
✅ FastAPI requests automatically traced via FastAPIInstrumentor
✅ Agent operations traced (@trace_agent_operation decorator)
✅ Tool executions traced (@trace_tool_execution decorator)
✅ Custom decorators supporting both sync and async functions
✅ Span enrichment with context (issue_id, agent_type, agent_id)
✅ Unit tests: 25 tests, 90-91% coverage

Files Added:

  • src/telemetry.py (184 lines) - OTEL SDK initialization
  • src/tracing_decorators.py (158 lines) - Custom decorators
  • tests/test_telemetry.py (181 lines) - Telemetry tests
  • tests/test_tracing_decorators.py (204 lines) - Decorator tests
  • docs/security-review-issue-313.md - Security assessment
  • docs/security-review-issue-313-summary.md - Security summary

Files Modified:

  • src/main.py - Added telemetry initialization and FastAPI instrumentation
  • src/coordinator.py - Added @trace_agent_operation to 3 key methods
  • .env.example - Added OTEL configuration variables
  • pyproject.toml - Added OpenTelemetry dependencies

Quality Gates:
✅ All tests passing (25/25)
✅ Coverage: 90-91% (exceeds 85% requirement)
✅ Zero linting errors (ruff)
✅ Zero type checking errors (mypy)
✅ Security review: APPROVED (no vulnerabilities)
✅ Code review: APPROVED
✅ QA testing: PASS

Configuration:

  • OTEL_ENABLED (default: true)
  • OTEL_SERVICE_NAME (default: mosaic-coordinator)
  • OTEL_EXPORTER_OTLP_ENDPOINT (default: http://localhost:4318/v1/traces)
  • OTEL_DEPLOYMENT_ENVIRONMENT (default: development)
  • OTEL_TRACES_SAMPLER_ARG (default: 1.0)

Tracing is now production-ready and compatible with Jaeger, Tempo, and other OTLP backends.

Issue #313 successfully implemented and merged to develop (commit 6de631c). ## Implementation Summary Added comprehensive OpenTelemetry distributed tracing to the coordinator FastAPI service. **Features Delivered:** ✅ FastAPI requests automatically traced via FastAPIInstrumentor ✅ Agent operations traced (@trace_agent_operation decorator) ✅ Tool executions traced (@trace_tool_execution decorator) ✅ Custom decorators supporting both sync and async functions ✅ Span enrichment with context (issue_id, agent_type, agent_id) ✅ Unit tests: 25 tests, 90-91% coverage **Files Added:** - src/telemetry.py (184 lines) - OTEL SDK initialization - src/tracing_decorators.py (158 lines) - Custom decorators - tests/test_telemetry.py (181 lines) - Telemetry tests - tests/test_tracing_decorators.py (204 lines) - Decorator tests - docs/security-review-issue-313.md - Security assessment - docs/security-review-issue-313-summary.md - Security summary **Files Modified:** - src/main.py - Added telemetry initialization and FastAPI instrumentation - src/coordinator.py - Added @trace_agent_operation to 3 key methods - .env.example - Added OTEL configuration variables - pyproject.toml - Added OpenTelemetry dependencies **Quality Gates:** ✅ All tests passing (25/25) ✅ Coverage: 90-91% (exceeds 85% requirement) ✅ Zero linting errors (ruff) ✅ Zero type checking errors (mypy) ✅ Security review: APPROVED (no vulnerabilities) ✅ Code review: APPROVED ✅ QA testing: PASS **Configuration:** - OTEL_ENABLED (default: true) - OTEL_SERVICE_NAME (default: mosaic-coordinator) - OTEL_EXPORTER_OTLP_ENDPOINT (default: http://localhost:4318/v1/traces) - OTEL_DEPLOYMENT_ENVIRONMENT (default: development) - OTEL_TRACES_SAMPLER_ARG (default: 1.0) Tracing is now production-ready and compatible with Jaeger, Tempo, and other OTLP backends.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai
AI/LLM integration
 api
Backend/API work
 api
auth
Authentication
 database
database
Database/schema work
 devops
Docker/deployment
 docs
Documentation
 frontend
graph
knowledge-module
migration
Data migration
 orchestrator
Orchestrator service (apps/orchestrator/)
 p0
Critical priority
 p1
High priority
 p2
Medium priority
 p3
Low priority
 performance
Performance work
 phase-1
phase-2
phase-3
phase-4
phase-5
plugin
MoltBot plugin work
 search
security
Security-related
 setup
Initial setup
 testing
Testing/QA
 web
Frontend work
No Label
Milestone
No items
No Milestone M4-LLM (0.0.4)
Projects
Clear projects
No project
Assignees
Clear assignees
jason.woltje
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaic/stack#313
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?