12abdfe81d
Implements FED-010: Agent Spawn via Federation feature that enables spawning and managing Claude agents on remote federated Mosaic Stack instances via COMMAND message type. Features: - Federation agent command types (spawn, status, kill) - FederationAgentService for handling agent operations - Integration with orchestrator's agent spawner/lifecycle services - API endpoints for spawning, querying status, and killing agents - Full command routing through federation COMMAND infrastructure - Comprehensive test coverage (12/12 tests passing) Architecture: - Hub → Spoke: Spawn agents on remote instances - Command flow: FederationController → FederationAgentService → CommandService → Remote Orchestrator - Response handling: Remote orchestrator returns agent status/results - Security: Connection validation, signature verification Files created: - apps/api/src/federation/types/federation-agent.types.ts - apps/api/src/federation/federation-agent.service.ts - apps/api/src/federation/federation-agent.service.spec.ts Files modified: - apps/api/src/federation/command.service.ts (agent command routing) - apps/api/src/federation/federation.controller.ts (agent endpoints) - apps/api/src/federation/federation.module.ts (service registration) - apps/orchestrator/src/api/agents/agents.controller.ts (status endpoint) - apps/orchestrator/src/api/agents/agents.module.ts (lifecycle integration) Testing: - 12/12 tests passing for FederationAgentService - All command service tests passing - TypeScript compilation successful - Linting passed Refs #93 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
94 lines
3.1 KiB
Markdown
94 lines
3.1 KiB
Markdown
# Issue #67: [KNOW-015] Search UI
|
|
|
|
## Objective
|
|
|
|
Build a comprehensive search interface in the Next.js web UI with search-as-you-type, filters, keyboard shortcuts, and highlighted snippets.
|
|
|
|
## Approach
|
|
|
|
1. Review existing web UI structure and components
|
|
2. Design component architecture for search functionality
|
|
3. Implement TDD workflow (RED-GREEN-REFACTOR):
|
|
- Write tests for search input component
|
|
- Implement search input with Cmd+K shortcut
|
|
- Write tests for search results page
|
|
- Implement search results with highlighting
|
|
- Write tests for filter sidebar
|
|
- Implement filter functionality
|
|
- Add no results state
|
|
4. Ensure all tests pass and coverage meets 85% minimum
|
|
5. Run quality gates and code review
|
|
6. Commit and close issue
|
|
|
|
## Component Architecture
|
|
|
|
- `SearchInput` - Header search component with Cmd+K shortcut
|
|
- `SearchResults` - Main results page/component
|
|
- `SearchResultItem` - Individual result with highlighted snippets
|
|
- `SearchFilters` - Sidebar for tag and status filtering
|
|
- `NoResults` - Empty state component
|
|
|
|
## Progress
|
|
|
|
- [x] Create scratchpad
|
|
- [x] Review existing web UI structure
|
|
- [x] Write tests for SearchInput component
|
|
- [x] Implement SearchInput with keyboard shortcut
|
|
- [x] Write tests for SearchResults page
|
|
- [x] Implement SearchResults page
|
|
- [x] Write tests for SearchResultItem with highlighting
|
|
- [x] Implement result item with snippet highlighting
|
|
- [x] Write tests for SearchFilters
|
|
- [x] Implement filter sidebar
|
|
- [x] Write tests for NoResults state
|
|
- [x] Implement no results state
|
|
- [x] Add debounced search-as-you-type
|
|
- [x] Create search page at /knowledge/search
|
|
- [x] Add search button to Navigation header
|
|
- [x] Fix Input component to support forwardRef
|
|
- [x] All tests passing (100% coverage)
|
|
- [x] Typecheck passing
|
|
- [x] Lint passing
|
|
- [x] Commit changes (3cb6eb7)
|
|
- [ ] Close issue #67
|
|
|
|
## Summary
|
|
|
|
Successfully implemented comprehensive search UI for knowledge base with:
|
|
|
|
- Full TDD approach (tests written first)
|
|
- 100% code coverage on main components
|
|
- All acceptance criteria met
|
|
- PDA-friendly design principles followed
|
|
- Quality gates passed (typecheck, lint, tests)
|
|
|
|
Components created:
|
|
|
|
- SearchInput (debounced, Cmd+K shortcut)
|
|
- SearchFilters (tags and status filtering)
|
|
- SearchResults (main results view with highlighting)
|
|
- Search page at /knowledge/search
|
|
- Updated Navigation with search button
|
|
|
|
All files pass pre-commit hooks and quality checks.
|
|
|
|
## Testing Strategy
|
|
|
|
- Unit tests for all components
|
|
- Test keyboard shortcuts (Cmd+K, Escape)
|
|
- Test debouncing behavior
|
|
- Test filter interactions
|
|
- Test safe HTML rendering for highlights
|
|
- Test no results state
|
|
- Aim for 85%+ coverage
|
|
|
|
## Notes
|
|
|
|
- Use Shadcn/ui components (Input, Card, Badge, etc.)
|
|
- Follow PDA-friendly language (no "URGENT", "MUST", etc.)
|
|
- Use visual indicators: 🟢 Active, 🔵 Scheduled, ⏸️ Paused, 💤 Dormant, ⚪ Not started
|
|
- Safely render HTML snippets from API (use dangerouslySetInnerHTML with sanitization or a library)
|
|
- Debounce search input to avoid excessive API calls
|
|
- Cmd+K should open search modal/focus search input
|
|
- Escape should close search modal if open
|