Jason Woltje
dc5ec68e02
All checks were successful
ci/woodpecker/push/web Pipeline was successful
Mark acceptance criteria 14-28 as DONE, add MS16+MS17 to Completed Work section, update resolved risks/open questions, close issue #469, finalize manifest and scratchpad with smoke test confirmation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
40 lines
1.3 KiB
Markdown
40 lines
1.3 KiB
Markdown
# Scratchpad: #446 — AuthDivider Padding
|
|
|
|
## Objective
|
|
|
|
Add padding above and below the "OR CONTINUE WITH" divider on the login page.
|
|
|
|
## Component Location
|
|
|
|
`packages/ui/src/components/AuthSurface.tsx` — `AuthDivider` component
|
|
|
|
## Current State
|
|
|
|
- `AuthDivider` has `my-8` (32px margin top/bottom) on the outer div
|
|
- Used in `apps/web/src/app/(auth)/login/page.tsx` line 287
|
|
- Parent container uses `space-y-0`
|
|
|
|
## Change
|
|
|
|
Increase `my-8` to `my-10` (40px) to add more visual breathing room around the divider.
|
|
|
|
ASSUMPTION: `my-10` (40px) is sufficient extra breathing room. If visual review shows otherwise, can adjust.
|
|
|
|
## Steps
|
|
|
|
- [x] Issue #446 created
|
|
- [x] Scratchpad created
|
|
- [x] Make change (py-8 instead of my-8)
|
|
- [x] Code review (passed — independent agent review confirmed fix is correct)
|
|
- [x] Commit/push (d7a8ebc → PR #447)
|
|
- [x] CI green (all 3 pipelines: web=success, api=success, orchestrator=success)
|
|
- [x] PR merged (9b5c15c on main)
|
|
- [x] Coolify redeploy (pre-pulled images, service running:healthy)
|
|
- [x] Playwright verify (paddingTop=32px, paddingBottom=32px confirmed)
|
|
- [x] Issue closed (#446)
|
|
|
|
## Result
|
|
|
|
COMPLETE. Root cause: `space-y-0` parent overrides `margin-top` on AuthDivider via CSS sibling
|
|
selector. Fix: changed `my-8` to `py-8` so spacing is internal padding, not external margin.
|