docs: queue revs 1185-1191, row 114 started and moved in-review by Rocko (1185-1187, Rocko's), review requested (1188-1189), approved by Filbert (1190, Filbert's) and done (landed a1ddeabdf, #1608)

2026-10-14 15:44:42 -05:00
parent a1ddeabdfc
commit 1a323c28f2
2 changed files with 233 additions and 6 deletions
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.

 <!-- mosaic-queue:begin -->

-Generated from `docs/plans/queue.json` revision 1184 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
+Generated from `docs/plans/queue.json` revision 1191 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.

 | # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
 |---|---|---|---|---|---|---|---|---|
@@ -150,7 +150,7 @@ Generated from `docs/plans/queue.json` revision 1184 by `queue render`. Do not e
 | 111 | Bus host start: release host.lock after the broker's reply and handle the child error event (Dewey 28319 a, Darkwing's async error) | darkwing; reviewers dewey | #1605 | done | — | dewey approves on #1605 naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before and after landing; live only with a new copy, re-pin and bus restart under Mos's go (sage) | `docs/plans/2026-10-13_landing-follow-ups.md` § Bus host start: release after the broker's reply, and the child `error` event | Landed 9774d70db, pushed. verify-commit ok (2 paths). Sage gate: every package suite green; test-queue failed review.test.mjs:123 once under load, passed 28/28 on rerun (Vikunja #261). Dewey note a recorded for the next host.mjs row. #1605 comment 28342, closed. Live only after the re-pin. |
 | 112 | Decision raise takes one recommendation key and says which field failed | darkwing; reviewers filbert, sage | #1606 | done | — | Filbert and Sage approve on #1606 naming the candidate manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy and bus restart under Mos's go, shared with row 110; Mos re-raises Q139/Q140 through the PM and sees it in the Inbox (sage) | `docs/plans/2026-10-14_decision-raise-recommendation.md` § Decision raise takes one recommendation key and says which field failed | Round 1: Sage's recorded approve (rev 1106, comment 28377) is superseded by changes in comment 28378. The README invalid-options row misstates the shape cases: keys() refuses a malformed option invalid-request. The queue allows one verdict per round, so round 1 must not land; round 2 carries the README fix. |
 | 113 | The weekly ledger runs on current T3 and a week with more than 50 updated issues | darkwing; reviewers filbert | #1607 | done | 112 done | Filbert approves on #1607 naming the candidate manifest; Sage's full gate rerun at the landing target; after landing Sage runs 2026-10-04..10-10 with issues and T3 and exits 0 (sage) | `docs/plans/2026-10-14_ledger-reasoning-and-issue-pages.md` § The weekly ledger runs on current T3 and a week with more than 50 updated issues | — |
-| 114 | Discord connector unit runs from a pinned copy | rocko; reviewers filbert | #1608 | briefed | 108 done | Filbert approves on #1608 naming the candidate manifest; Sage's full gate rerun at the landing target; Mos notices before and after (packages/discord flagged); install and restart are Mos's step after the SetSpark freeze lifts (sage) | `docs/plans/2026-10-14_discord-pinned-copy.md` § Discord connector unit runs from a pinned copy | — |
+| 114 | Discord connector unit runs from a pinned copy | rocko; reviewers filbert | #1608 | done | 108 done | Filbert approves on #1608 naming the candidate manifest; Sage's full gate rerun at the landing target; Mos notices before and after (packages/discord flagged); install and restart are Mos's step after the SetSpark freeze lifts (sage) | `docs/plans/2026-10-14_discord-pinned-copy.md` § Discord connector unit runs from a pinned copy | — |
 | 115 | A closed decision sends the raising role a message | darkwing; reviewers filbert, sage | #1609 | done | 113 done | Filbert and Sage approve on #1609 naming the candidate manifest; Sage's full gate rerun at the landing target; Mos notices before and after (decision 109); live only via copy, re-pin and bus restart on Mos's go (sage) | `docs/plans/2026-10-14_decision-close-message.md` § A closed decision sends the raising role a message | — |
 | 116 | A resolved merge decision lands as a gated local commit | darkwing; reviewers filbert | #1610 | done | 115 done, 117 done | Filbert approves on #1610 naming the candidate manifest; Sage's full gate rerun at the landing target; the 19/265 replay matches f7c8537b3's tree and 010d30cbe refuses root-file (sage) | `docs/plans/2026-10-14_merge-path-for-approved-work.md` § A resolved merge decision lands as a gated local commit | — |
 | 117 | Fetch a role clone that is on another branch or dirty | darkwing; reviewers dewey | #1611 | done | — | Dewey approves on #1611 naming the candidate manifest; Sage's full gate rerun at the landing target; a dirty or off-branch clone fetches origin and nothing else moves (sage) | `docs/plans/2026-10-14_clone-fetch-off-branch.md` § Fetch a role clone that is on another branch or dirty | — |
@@ -1,7 +1,7 @@
 {
  "version": 1,
  "canonicalRoot": "/mnt/storage/src/mosaic-stack",
-  "revision": 1184,
+  "revision": 1191,
  "rows": [
    {
      "id": 1,
@@ -10378,7 +10378,7 @@
      "closes": [
        1608
      ],
-      "state": "briefed",
+      "state": "done",
      "previousState": null,
      "required": false,
      "requiredSince": null,
@@ -10398,12 +10398,69 @@
      "reviewers": [
        "filbert"
      ],
-      "review": null,
+      "review": {
+        "rounds": [
+          {
+            "n": 1,
+            "op": "rocko-114-review-1",
+            "by": "rocko",
+            "at": "2026-10-14T20:33:13.177Z",
+            "issue": 1608,
+            "candidate": {
+              "kind": "manifest",
+              "digest": "68c60a79914692f3f6d4923f7bcff41de109ccca33bf6fba687fb88efa24bcac",
+              "text": "1cd5abf22a24b985e262a7d0baed7c5bf66e7a3cbafb47c06dd51eace4afe9f6  docs/TOOLS.md\n5949914eb943139d18cac183755319e96830ea92be3b33f3bd056536467655d2  packages/discord/README.md\n8f18ee5bb7e0c2a049670caf20438cc35c44bcd5333943e9084f0abb6c9e2234  packages/discord/src/cli.mjs\n75a84d470cc5cb77f0a9252f8828dfbe29645958f423884846a0ac39d9e51ced  packages/discord/tests/copy-service.test.mjs\nc56f4f93e66bc979f0e95e52c2ab2a09b149191071de09b8d739b0a0592df8fe  packages/discord/tests/offline-check.test.mjs\nbc290fcf852930f398b44689f0731d00412c475781b3eae51c0a01beaf5d1102  scripts/discord-service.sh\nf5b42da59265a3195fa5c87053dbc3dcdcec9ecc9d5468cbadeb683346e62e34  scripts/test-discord.sh\n"
+            },
+            "request": "comment",
+            "attempts": [
+              {
+                "op": "rocko-114-review-1",
+                "by": "rocko",
+                "at": "2026-10-14T20:33:13.177Z",
+                "state": "failed",
+                "comment": null,
+                "transport": {
+                  "outcome": "failed",
+                  "status": null,
+                  "comment": null,
+                  "detail": "pre-send: the credential or account check failed"
+                },
+                "resolutions": []
+              },
+              {
+                "op": "sage-114-review-1",
+                "by": "sage",
+                "at": "2026-10-14T20:34:49.532Z",
+                "state": "posted",
+                "comment": 28496,
+                "transport": {
+                  "outcome": "posted",
+                  "status": 201,
+                  "comment": 28496,
+                  "detail": "created"
+                },
+                "resolutions": []
+              }
+            ],
+            "duplicateRisk": false,
+            "receipts": [
+              {
+                "reviewer": "filbert",
+                "op": "filbert-114-r1",
+                "at": "2026-10-14T20:38:22.833Z",
+                "verdict": "approve",
+                "comment": 28497,
+                "candidate": "68c60a79914692f3f6d4923f7bcff41de109ccca33bf6fba687fb88efa24bcac"
+              }
+            ]
+          }
+        ]
+      },
      "claim": null,
      "note": null,
      "blockedReason": null,
      "createdAt": "2026-10-14T16:13:48.822Z",
-      "updatedAt": "2026-10-14T16:13:56.367Z",
+      "updatedAt": "2026-10-14T20:44:03.074Z",
      "updatedBy": "sage"
    },
    {
@@ -42701,6 +42758,176 @@
        "receipt": "ok sage-108-land rev 1184 row 108 in-review→done round 1"
      },
      "viewSha": "aa6b013a9d581880a1d1b176b3ee6134b7d5dd82e653b5830aadf5c972f83c55"
+    },
+    {
+      "rev": 1185,
+      "op": "rocko-114-start-20261014",
+      "verb": "move",
+      "args": {
+        "id": 114,
+        "to": "in-progress",
+        "reason": null,
+        "candidate": null,
+        "evidence": null,
+        "issue": null
+      },
+      "by": "rocko",
+      "at": "2026-10-14T20:25:04.186Z",
+      "semantics": 2,
+      "result": {
+        "row": 114,
+        "from": "briefed",
+        "to": "in-progress",
+        "round": null,
+        "issue": null,
+        "candidate": null,
+        "receipt": "ok rocko-114-start-20261014 rev 1185 row 114 briefed→in-progress"
+      },
+      "viewSha": "9c7d1209203e8b5d6fc3bad3f5d605ae09eac0c52416bdf169defe535581c2a7"
+    },
+    {
+      "rev": 1186,
+      "op": "rocko-114-review-1",
+      "verb": "move",
+      "args": {
+        "id": 114,
+        "to": "in-review",
+        "reason": null,
+        "candidate": "agents/rocko/work/queue-114/r1/candidate-manifest.sha256",
+        "evidence": null,
+        "issue": null
+      },
+      "by": "rocko",
+      "at": "2026-10-14T20:33:13.177Z",
+      "semantics": 2,
+      "result": {
+        "row": 114,
+        "from": "in-progress",
+        "to": "in-review",
+        "round": 1,
+        "issue": 1608,
+        "candidate": {
+          "kind": "manifest",
+          "digest": "68c60a79914692f3f6d4923f7bcff41de109ccca33bf6fba687fb88efa24bcac",
+          "text": "1cd5abf22a24b985e262a7d0baed7c5bf66e7a3cbafb47c06dd51eace4afe9f6  docs/TOOLS.md\n5949914eb943139d18cac183755319e96830ea92be3b33f3bd056536467655d2  packages/discord/README.md\n8f18ee5bb7e0c2a049670caf20438cc35c44bcd5333943e9084f0abb6c9e2234  packages/discord/src/cli.mjs\n75a84d470cc5cb77f0a9252f8828dfbe29645958f423884846a0ac39d9e51ced  packages/discord/tests/copy-service.test.mjs\nc56f4f93e66bc979f0e95e52c2ab2a09b149191071de09b8d739b0a0592df8fe  packages/discord/tests/offline-check.test.mjs\nbc290fcf852930f398b44689f0731d00412c475781b3eae51c0a01beaf5d1102  scripts/discord-service.sh\nf5b42da59265a3195fa5c87053dbc3dcdcec9ecc9d5468cbadeb683346e62e34  scripts/test-discord.sh\n"
+        },
+        "receipt": "ok rocko-114-review-1 rev 1186 row 114 in-progress→in-review round 1 on #1608; request rocko-114-review-1 requesting"
+      },
+      "viewSha": "4eddb85395ed0a08cbcbf6085f9efe23614cba4682a595830f80a69d0fa6b581"
+    },
+    {
+      "rev": 1187,
+      "op": "rocko-114-review-1.outcome",
+      "verb": "review-outcome",
+      "args": {
+        "id": 114,
+        "attempt": "rocko-114-review-1",
+        "outcome": "failed",
+        "status": null,
+        "comment": null,
+        "detail": "pre-send: the credential or account check failed"
+      },
+      "by": "rocko",
+      "at": "2026-10-14T20:33:18.069Z",
+      "semantics": 2,
+      "result": {
+        "row": 114,
+        "round": 1,
+        "attempt": "rocko-114-review-1",
+        "state": "failed",
+        "receipt": "ok rocko-114-review-1.outcome rev 1187 row 114 round 1 request rocko-114-review-1 failed"
+      },
+      "viewSha": "83cbb1210f521fc2952d28015e873fc407d0ce9446faa5d0c4a11046aee00cd6"
+    },
+    {
+      "rev": 1188,
+      "op": "sage-114-review-1",
+      "verb": "review-request",
+      "args": {
+        "id": 114
+      },
+      "by": "sage",
+      "at": "2026-10-14T20:34:49.532Z",
+      "semantics": 2,
+      "result": {
+        "row": 114,
+        "round": 1,
+        "attempt": "sage-114-review-1",
+        "state": "requesting",
+        "receipt": "ok sage-114-review-1 rev 1188 row 114 round 1 request sage-114-review-1 requesting"
+      },
+      "viewSha": "32141c30c6d46954e250667269adc9c960be2c1f4fce3b41d74ca95eef761dcc"
+    },
+    {
+      "rev": 1189,
+      "op": "sage-114-review-1.outcome",
+      "verb": "review-outcome",
+      "args": {
+        "id": 114,
+        "attempt": "sage-114-review-1",
+        "outcome": "posted",
+        "status": 201,
+        "comment": 28496,
+        "detail": "created"
+      },
+      "by": "sage",
+      "at": "2026-10-14T20:34:55.355Z",
+      "semantics": 2,
+      "result": {
+        "row": 114,
+        "round": 1,
+        "attempt": "sage-114-review-1",
+        "state": "posted",
+        "receipt": "ok sage-114-review-1.outcome rev 1189 row 114 round 1 request sage-114-review-1 posted comment 28496"
+      },
+      "viewSha": "7aece703566895d209b0ee66c53d0d3b483107d86234bfd6a0edf262ddcd9808"
+    },
+    {
+      "rev": 1190,
+      "op": "filbert-114-r1",
+      "verb": "review-record",
+      "args": {
+        "id": 114,
+        "verdict": "approve",
+        "comment": 28497,
+        "candidate": "68c60a79914692f3f6d4923f7bcff41de109ccca33bf6fba687fb88efa24bcac"
+      },
+      "by": "filbert",
+      "at": "2026-10-14T20:38:22.833Z",
+      "semantics": 2,
+      "result": {
+        "row": 114,
+        "round": 1,
+        "verdict": "approve",
+        "receipt": "ok filbert-114-r1 rev 1190 row 114 round 1 approve by filbert (comment 28497)"
+      },
+      "viewSha": "7b7b2065a1d48f1291a5e4b2304ab1c63d6c9f745582d6ea8f9a7cb40bce5f6e"
+    },
+    {
+      "rev": 1191,
+      "op": "sage-114-land",
+      "verb": "move",
+      "args": {
+        "id": 114,
+        "to": "done",
+        "reason": null,
+        "candidate": null,
+        "evidence": null,
+        "issue": null
+      },
+      "by": "sage",
+      "at": "2026-10-14T20:44:03.074Z",
+      "semantics": 2,
+      "result": {
+        "row": 114,
+        "from": "in-review",
+        "to": "done",
+        "round": 1,
+        "issue": null,
+        "candidate": null,
+        "receipt": "ok sage-114-land rev 1191 row 114 in-review→done round 1"
+      },
+      "viewSha": "6c803ac08a621c7b5a15a4cb677f24c6d0c9ade8d92a97928c276946510286ba"
    }
  ]
 }