row 237 candidate on 816d48b03 (gate tree)

This commit is contained in:
sage committed 2026-10-20 20:27:37 -05:00
1 parent 816d48b03e
commit 23529aab2a
4 files changed
+123

No files matched your search

+3
View File
@@ -1035,6 +1035,9 @@ export class Broker {
const decision = args.decision ?? null;
const result = this.#checkAuthority(s, 'git.push.remote', { decision, target: task_ref });
const facts = this.#publishFacts(s, task_ref, project, result);
// Row 237 (#1743): one decision, one open publish. The decision is spent only at
// recordPublish, after the push, so a second ticket on it would push too, maybe to another ref.
if (result.decision && [...this.#publishes.values()].some((p) => p.s.business === s.business && p.decision === result.decision)) fail('publish-busy');
const ticket = randomUUID();
const dst = `refs/heads/${facts.user}/${branch}`;
this.#publishes.set(ticket, { s, task_ref, project, decision, dst, ...facts });
+26
View File
@@ -181,6 +181,32 @@ test('the request cannot name the fork, the user or the destination', (t) => {
assert.throws(() => f.publish(d, 'coder', extra), /invalid-request/);
});
// Row 237 (#1743, duckworth-0068 N1): the decision is spent at recordPublish, after the push, so
// checkPublish refuses a second ticket on a decision that already has one open.
test('one decision, one open publish: a second ticket refuses publish-busy, whatever its branch', (t) => {
const f = setup(t);
f.push(A);
const d = f.approve();
const r = f.publish(d);
assert.throws(() => f.publish(d), /publish-busy/);
assert.throws(() => f.publish(d, 'coder', { branch: 'other' }), /publish-busy/);
// A refused publish frees the decision, which is still unspent; the retry gets a ticket.
f.b.publishRefused(r.ticket, { code: 'fork-unavailable' });
const retry = f.publish(d, 'coder', { branch: 'other' });
assert.throws(() => f.publish(d), /publish-busy/);
f.b.recordPublish(retry.ticket, { ref: retry.dst, commit: A, previous: null });
assert.equal(f.events('action.allowed').filter((e) => e.body.action === 'git.push.remote' && e.body.operation !== 'decision.raise').length, 1);
assert.throws(() => f.publish(d), /decision-consumed/);
// Another agent's decision on the same task isn't held by this one's ticket.
const f2 = setup(t);
f2.push(A);
const mine = f2.approve();
f2.publish(mine);
f2.push(B, A, 'second');
const theirs = f2.approve('second');
assert.equal(typeof f2.publish(theirs, 'second').ticket, 'string');
});
test('publishRefused files the code on the task\'s trail and drops the ticket', (t) => {
const f = setup(t);
f.push(A);