mosaicstack/stack
25
0
Fork 1
Code Issues 360 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

queue: revs 524-528, row 72 in review round 1, comment 27454 (#1566) (rocko's 524-526, incl. row 73 started; sage's request as jarvis 527-528)

Browse Source
This commit is contained in:
jason.woltje
2026-10-11 18:06:36 -05:00
parent 036afdb686
commit 324c064b2a
2 changed files with 186 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/QUEUE.md
+3 -3
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 523 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 528 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -108,8 +108,8 @@ Generated from `docs/plans/queue.json` revision 523 by `queue render`. Do not ed
| 69 | Terminal app follow-up: narrow-terminal guard test, hidden-box way out and width tests | darkwing; reviewers dewey, filbert | #1562 | blocked (from briefed): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94) | 55 done | dewey and filbert approve on the issue naming the candidate manifest; cli and queue node suites plus every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_terminal-app-follow-up.md` § Terminal app follow-up: narrow-terminal guard test, hidden-box way out and width tests | — |
| 70 | Docs say mosaic on PATH is the estate CLI; after Q81 it can be this one | sage; reviewers filbert | #1564 | blocked (from briefed): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94) | — | filbert approves on the issue naming the candidate manifest; cli, queue and seat node suites and every scripts/test-*.sh green on Sage's gate run (sage) | `docs/plans/2026-10-11_mosaic-on-path-docs.md` § Docs say mosaic on PATH is the estate CLI; after Q81 it can be this one | — |
| 71 | Tree read follow-up: confirm-read tests and the fake's view 404 | darkwing; reviewers dewey, filbert | #1565 | blocked (from briefed): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94) | — | dewey and filbert approve on the issue naming the candidate manifest; tasks and bus node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_tree-read-follow-up.md` § Tree read follow-up: confirm-read tests and the fake's view 404 | — |
| 72 | Claude pin tests: a directory pin, a symlink default, a pin with a space | rocko; reviewers filbert | #1566 | in-progress | 68 done | filbert approves on the issue naming the candidate manifest; cli and harness node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin tests: a directory pin, a symlink default, a pin with a space | — |
| 73 | Coder role: drop the task.reassign grant the broker always refuses | rocko; reviewers dewey | #1567 | briefed | — | dewey approves on the issue naming the candidate manifest; tasks, bus, business and harness node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder role: drop the task.reassign grant the broker always refuses | — |
| 72 | Claude pin tests: a directory pin, a symlink default, a pin with a space | rocko; reviewers filbert | #1566 | in-review, round 1, request posted | 68 done | filbert approves on the issue naming the candidate manifest; cli and harness node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin tests: a directory pin, a symlink default, a pin with a space | — |
| 73 | Coder role: drop the task.reassign grant the broker always refuses | rocko; reviewers dewey | #1567 | in-progress | — | dewey approves on the issue naming the candidate manifest; tasks, bus, business and harness node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder role: drop the task.reassign grant the broker always refuses | — |
| 74 | WebUI preview: a signed-in, read-only Console behind the edge proxy | dewey; reviewers darkwing, filbert | #1568 | in-review, round 1, request posted | — | darkwing and filbert approve on the issue naming the candidate manifest; webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Sage starts it after landing once rev-sol-01 passes ops-01's route (decision 93) (sage) | `docs/plans/2026-10-11_webui-preview.md` § WebUI preview: a signed-in, read-only Console behind the edge proxy | Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged. |
| 75 | Console as a user service: render, install and status, Jason starts it | rocko; reviewers filbert | #1569 | done | — | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console as a user service | — |
| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | briefed | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | From row 74 round 1 (Dewey, point 5): the page shows 'Delivery may be unknown; check the seat before sending again.' for a 403 read-only refusal. That's wrong for a refusal. src/public/app.js is row 76's file, so row 76 fixes the message: a refusal says it was refused, and only outcome-unknown says delivery may be unknown. |
docs/plans/queue.json
+183 -9
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 523,
"revision": 528,
"rows": [
{
"id": 1,
@@ -5290,7 +5290,7 @@
"closes": [
1566
],
"state": "in-progress",
"state": "in-review",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -5310,7 +5310,55 @@
"reviewers": [
"filbert"
],
"review": null,
"review": {
"rounds": [
{
"n": 1,
"op": "rocko-72-review-1",
"by": "rocko",
"at": "2026-10-11T23:05:27.004Z",
"issue": 1566,
"candidate": {
"kind": "manifest",
"digest": "e6531a5311f17ea147700e417dfdbd766a9c38acf3c3b44755267c285b78e006",
"text": "88adfa55efb6da9ea575b2074ed788f69b5cfc73b637dad8f3943c48e7c1f83d agents/rocko/work/queue-72/mutants.sh\n534ef435a3fab82616079000dc7c357e3630380e47ce2fb1384e294d388c98dd packages/cli/tests/host.test.mjs\n9e8b5465f27665832f6c6c3872117f6d773b1ba6e699cd65da66ccda96297e94 packages/harness/tests/claude-session.test.mjs\n"
},
"request": "comment",
"attempts": [
{
"op": "rocko-72-review-1",
"by": "rocko",
"at": "2026-10-11T23:05:27.004Z",
"state": "failed",
"comment": null,
"transport": {
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"resolutions": []
},
{
"op": "sage-72-review-request-1",
"by": "sage",
"at": "2026-10-11T23:05:54.795Z",
"state": "posted",
"comment": 27454,
"transport": {
"outcome": "posted",
"status": 201,
"comment": 27454,
"detail": "created"
},
"resolutions": []
}
],
"duplicateRisk": false,
"receipts": []
}
]
},
"claim": {
"seat": "rocko",
"op": "rocko-72-start-1"
@@ -5318,8 +5366,8 @@
"note": null,
"blockedReason": null,
"createdAt": "2026-10-11T21:47:53.131Z",
"updatedAt": "2026-10-11T22:56:08.638Z",
"updatedBy": "rocko"
"updatedAt": "2026-10-11T23:05:56.922Z",
"updatedBy": "sage"
},
{
"id": 73,
@@ -5331,7 +5379,7 @@
"closes": [
1567
],
"state": "briefed",
"state": "in-progress",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -5347,12 +5395,15 @@
"dewey"
],
"review": null,
"claim": null,
"claim": {
"seat": "rocko",
"op": "rocko-73-start"
},
"note": null,
"blockedReason": null,
"createdAt": "2026-10-11T21:47:55.159Z",
"updatedAt": "2026-10-11T21:48:02.541Z",
"updatedBy": "sage"
"updatedAt": "2026-10-11T23:05:50.481Z",
"updatedBy": "rocko"
},
{
"id": 74,
@@ -20267,6 +20318,129 @@
"receipt": "ok sage-74-note-r2b rev 523 row 74 note"
},
"viewSha": "a6ef9e26e3935468392a6a22c0bf381a5a66dae29329f94b9a1100302e5ff918"
},
{
"rev": 524,
"op": "rocko-72-review-1",
"verb": "move",
"args": {
"id": 72,
"to": "in-review",
"reason": null,
"candidate": "agents/rocko/work/queue-72/candidate-manifest.sha256",
"evidence": null,
"issue": 1566
},
"by": "rocko",
"at": "2026-10-11T23:05:27.004Z",
"semantics": 2,
"result": {
"row": 72,
"from": "in-progress",
"to": "in-review",
"round": 1,
"issue": 1566,
"candidate": {
"kind": "manifest",
"digest": "e6531a5311f17ea147700e417dfdbd766a9c38acf3c3b44755267c285b78e006",
"text": "88adfa55efb6da9ea575b2074ed788f69b5cfc73b637dad8f3943c48e7c1f83d agents/rocko/work/queue-72/mutants.sh\n534ef435a3fab82616079000dc7c357e3630380e47ce2fb1384e294d388c98dd packages/cli/tests/host.test.mjs\n9e8b5465f27665832f6c6c3872117f6d773b1ba6e699cd65da66ccda96297e94 packages/harness/tests/claude-session.test.mjs\n"
},
"receipt": "ok rocko-72-review-1 rev 524 row 72 in-progress→in-review round 1 on #1566; request rocko-72-review-1 requesting"
},
"viewSha": "14ff614c8c5396dc6c6e192e007af75b5d1cead2d31d331c934117a040efc781"
},
{
"rev": 525,
"op": "rocko-72-review-1.outcome",
"verb": "review-outcome",
"args": {
"id": 72,
"attempt": "rocko-72-review-1",
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"by": "rocko",
"at": "2026-10-11T23:05:28.558Z",
"semantics": 2,
"result": {
"row": 72,
"round": 1,
"attempt": "rocko-72-review-1",
"state": "failed",
"receipt": "ok rocko-72-review-1.outcome rev 525 row 72 round 1 request rocko-72-review-1 failed"
},
"viewSha": "29c3ab1c382f83624c0096a2845bd37d364c865548e78bd4031ff36d4d4a5498"
},
{
"rev": 526,
"op": "rocko-73-start",
"verb": "move",
"args": {
"id": 73,
"to": "in-progress",
"reason": null,
"candidate": null,
"evidence": null,
"issue": null
},
"by": "rocko",
"at": "2026-10-11T23:05:50.481Z",
"semantics": 2,
"result": {
"row": 73,
"from": "briefed",
"to": "in-progress",
"round": null,
"issue": null,
"candidate": null,
"receipt": "ok rocko-73-start rev 526 row 73 briefed→in-progress"
},
"viewSha": "34bd32c6eeb8675cf281c5b63194409eb4dc35f90bc9f8f4d8bcac3b6016f6f8"
},
{
"rev": 527,
"op": "sage-72-review-request-1",
"verb": "review-request",
"args": {
"id": 72
},
"by": "sage",
"at": "2026-10-11T23:05:54.795Z",
"semantics": 2,
"result": {
"row": 72,
"round": 1,
"attempt": "sage-72-review-request-1",
"state": "requesting",
"receipt": "ok sage-72-review-request-1 rev 527 row 72 round 1 request sage-72-review-request-1 requesting"
},
"viewSha": "e7ef178c5d5dc7ff285e0c1159967b7dd3b2af2162838c33b968641d3ebdf0b8"
},
{
"rev": 528,
"op": "sage-72-review-request-1.outcome",
"verb": "review-outcome",
"args": {
"id": 72,
"attempt": "sage-72-review-request-1",
"outcome": "posted",
"status": 201,
"comment": 27454,
"detail": "created"
},
"by": "sage",
"at": "2026-10-11T23:05:56.922Z",
"semantics": 2,
"result": {
"row": 72,
"round": 1,
"attempt": "sage-72-review-request-1",
"state": "posted",
"receipt": "ok sage-72-review-request-1.outcome rev 528 row 72 round 1 request sage-72-review-request-1 posted comment 27454"
},
"viewSha": "23aa97cbb58685e8ff20686e352284a2307809e6bc37733fcb4415ddce51f5f2"
}
]
}