mosaicstack/stack
25
0
Fork 1
Code Issues 360 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

queue: revs 540-542, row 74 in review round 2, comment 27484 (#1568) (dewey)

Browse Source 
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
jason.woltje
2026-10-11 18:24:49 -05:00
co-authored by Claude Opus 5.5
parent fce04c1556
commit 821e183d19
2 changed files with 116 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/QUEUE.md
+2 -2
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 539 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 542 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -110,7 +110,7 @@ Generated from `docs/plans/queue.json` revision 539 by `queue render`. Do not ed
| 71 | Tree read follow-up: confirm-read tests and the fake's view 404 | darkwing; reviewers dewey, filbert | #1565 | blocked (from briefed): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94) | — | dewey and filbert approve on the issue naming the candidate manifest; tasks and bus node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_tree-read-follow-up.md` § Tree read follow-up: confirm-read tests and the fake's view 404 | — |
| 72 | Claude pin tests: a directory pin, a symlink default, a pin with a space | rocko; reviewers filbert | #1566 | done | 68 done | filbert approves on the issue naming the candidate manifest; cli and harness node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin tests: a directory pin, a symlink default, a pin with a space | — |
| 73 | Coder role: drop the task.reassign grant the broker always refuses | rocko; reviewers dewey | #1567 | in-review, round 1, request posted | — | dewey approves on the issue naming the candidate manifest; tasks, bus, business and harness node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder role: drop the task.reassign grant the broker always refuses | — |
| 74 | WebUI preview: a signed-in, read-only Console behind the edge proxy | dewey; reviewers darkwing, filbert | #1568 | in-review, round 1, request posted | — | darkwing and filbert approve on the issue naming the candidate manifest; webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Sage starts it after landing once rev-sol-01 passes ops-01's route (decision 93) (sage) | `docs/plans/2026-10-11_webui-preview.md` § WebUI preview: a signed-in, read-only Console behind the edge proxy | Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged. |
| 74 | WebUI preview: a signed-in, read-only Console behind the edge proxy | dewey; reviewers darkwing, filbert | #1568 | in-review, round 2, request posted | — | darkwing and filbert approve on the issue naming the candidate manifest; webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Sage starts it after landing once rev-sol-01 passes ops-01's route (decision 93) (sage) | `docs/plans/2026-10-11_webui-preview.md` § WebUI preview: a signed-in, read-only Console behind the edge proxy | Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged. |
| 75 | Console as a user service: render, install and status, Jason starts it | rocko; reviewers filbert | #1569 | done | — | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console as a user service | — |
| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | briefed | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | From row 74 round 1 (Dewey, point 5): the page shows 'Delivery may be unknown; check the seat before sending again.' for a 403 read-only refusal. That's wrong for a refusal. src/public/app.js is row 76's file, so row 76 fixes the message: a refusal says it was refused, and only outcome-unknown says delivery may be unknown. |
| 77 | Console service hardening: row 75 review follow-ups N1-N5 | rocko; reviewers filbert | #1571 | queued | 75 done | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_console-service-followups.md` § Console service hardening | After the cutover (2026-10-12T21:30Z). Source: Filbert comment 27430 on #1569. |
docs/plans/queue.json
+114 -3
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 539,
"revision": 542,
"rows": [
{
"id": 1,
@@ -5534,6 +5534,37 @@
"candidate": "67515db514f5df5d2d4947f27656f63e32541947042918d78d30ac31a84d76a0"
}
]
},
{
"n": 2,
"op": "dewey-74-review-r2-20261011",
"by": "dewey",
"at": "2026-10-11T23:23:43.125Z",
"issue": 1568,
"candidate": {
"kind": "manifest",
"digest": "17b6d7f62d106a23d99441eefa46e34ab2e9bd1442a1d02e219f126a82a8668d",
"text": "c3b9e04e44e4beb1736d90191b0c72cbedabfdedea039e447e17b3e3b8e707eb packages/webui/README.md\ne0970dfdb3c930b622ec40d5fb60ca3ca0d95f05f604f561a1a97b1192a84d2a packages/webui/src/cli.mjs\n8cd31c3fc95dc966a0252f7a45776d016ffd34578099263c649d41a0209dbdd5 packages/webui/src/serve.mjs\n52885a39224cfba006a691765bafae42a035c02e19445a377ec875bb47ade8e0 packages/webui/tests/preview.test.mjs\n"
},
"request": "comment",
"attempts": [
{
"op": "dewey-74-review-r2-20261011",
"by": "dewey",
"at": "2026-10-11T23:23:43.125Z",
"state": "posted",
"comment": 27484,
"transport": {
"outcome": "posted",
"status": 201,
"comment": 27484,
"detail": "created"
},
"resolutions": []
}
],
"duplicateRisk": false,
"receipts": []
}
]
},
@@ -5544,8 +5575,8 @@
"note": "Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged.",
"blockedReason": null,
"createdAt": "2026-10-11T21:53:29.970Z",
"updatedAt": "2026-10-11T23:04:15.746Z",
"updatedBy": "sage"
"updatedAt": "2026-10-11T23:23:45.949Z",
"updatedBy": "dewey"
},
{
"id": 75,
@@ -20862,6 +20893,86 @@
"receipt": "ok sage-add-coder-stale-text rev 539 row 79 none→queued"
},
"viewSha": "30322d7887283402951089bf719018e387782f5511654b978882b365cf7fa0aa"
},
{
"rev": 540,
"op": "dewey-74-r2-reopen-20261011",
"verb": "move",
"args": {
"id": 74,
"to": "in-progress",
"reason": null,
"candidate": null,
"evidence": null,
"issue": null
},
"by": "dewey",
"at": "2026-10-11T23:23:41.229Z",
"semantics": 2,
"result": {
"row": 74,
"from": "in-review",
"to": "in-progress",
"round": null,
"issue": null,
"candidate": null,
"receipt": "ok dewey-74-r2-reopen-20261011 rev 540 row 74 in-review→in-progress"
},
"viewSha": "8e3f9c2c525de553d22d2f89ea5bd0fda7dd316b6bc39db5985b193e5ba48e62"
},
{
"rev": 541,
"op": "dewey-74-review-r2-20261011",
"verb": "move",
"args": {
"id": 74,
"to": "in-review",
"reason": null,
"candidate": "agents/dewey/work/queue-74/candidate-manifest.sha256",
"evidence": null,
"issue": null
},
"by": "dewey",
"at": "2026-10-11T23:23:43.125Z",
"semantics": 2,
"result": {
"row": 74,
"from": "in-progress",
"to": "in-review",
"round": 2,
"issue": 1568,
"candidate": {
"kind": "manifest",
"digest": "17b6d7f62d106a23d99441eefa46e34ab2e9bd1442a1d02e219f126a82a8668d",
"text": "c3b9e04e44e4beb1736d90191b0c72cbedabfdedea039e447e17b3e3b8e707eb packages/webui/README.md\ne0970dfdb3c930b622ec40d5fb60ca3ca0d95f05f604f561a1a97b1192a84d2a packages/webui/src/cli.mjs\n8cd31c3fc95dc966a0252f7a45776d016ffd34578099263c649d41a0209dbdd5 packages/webui/src/serve.mjs\n52885a39224cfba006a691765bafae42a035c02e19445a377ec875bb47ade8e0 packages/webui/tests/preview.test.mjs\n"
},
"receipt": "ok dewey-74-review-r2-20261011 rev 541 row 74 in-progress→in-review round 2 on #1568; request dewey-74-review-r2-20261011 requesting"
},
"viewSha": "d36c36ef237f79167f1f78a4bb71c4c7bffa70b73d90367c80b9f188193ed36a"
},
{
"rev": 542,
"op": "dewey-74-review-r2-20261011.outcome",
"verb": "review-outcome",
"args": {
"id": 74,
"attempt": "dewey-74-review-r2-20261011",
"outcome": "posted",
"status": 201,
"comment": 27484,
"detail": "created"
},
"by": "dewey",
"at": "2026-10-11T23:23:45.949Z",
"semantics": 2,
"result": {
"row": 74,
"round": 2,
"attempt": "dewey-74-review-r2-20261011",
"state": "posted",
"receipt": "ok dewey-74-review-r2-20261011.outcome rev 542 row 74 round 2 request dewey-74-review-r2-20261011 posted comment 27484"
},
"viewSha": "539481b29d24811eca61c821cb7d69b56fa875efeb8eac09aa7a23ee90f80f34"
}
]
}