mosaicstack/stack
25
0
Fork 1
Code Issues 358 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

docs(build-log): row 56 rounds 1 and 2 (rocko) and landing (sage)

Browse Source 
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
jason.woltje
2026-10-10 12:22:54 -05:00
co-authored by Claude Opus 5.5
parent 8dff857f64
commit 938677363a
1 changed files with 60 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
BUILD-LOG.md
+60
View File
@@ -4032,3 +4032,63 @@ Open for Jason:
- decision Seen from the web, which would give the browser a human-authority write.
The private artifact was republished as version 2. No push.
### 2026-10-10 — Rocko, row 56 round 1 in review: runs and releases reader module (#1545)
Before: `mosaic-task.mjs list` and `show` read `<dataRoot>/runs/` directly, through any symbolic link. `list` crashed on a non-object `result.json`, and `show` crashed on a run that is a regular file. Nothing read the release pointer or the activation log for other consumers.
After (candidate, uncommitted, packet `agents/rocko/work/queue-56/`, base dc96f87b, also applies to 923957e2):
- new `packages/runs` with read-only readers for runs, `result.json`, the release pointer and the activation log;
- no reader writes or prunes, and none follows a link out of the data root;
- `list` and `show` import the module, +18/−27 in `scripts/mosaic-task.mjs`;
- no Q14-frozen path changes.
Evidence:
- packages/runs tests 37/0;
- every `scripts/test-*.sh` green (test-task 98/0 with Docker);
- byte-check: 16 cases, stdout, stderr and exit identical, data root unchanged;
- deliberate deltas printed by `delta-check.sh` and listed in the README;
- mutants: 30/32 killed, and both survivors are equivalent.
Corrections within this session:
- test-discord first ran 57/1 because the scratch worktree had no `node_modules/.bin/pi`. With the checkout's `node_modules` linked in, it ran 66/0.
- The first mutant round showed three missing tests (an exact `..`, the sort, and an unreadable run directory). I added all three.
- With a relative WORK_DIR, byte-check reported "identical" although every redirect had failed. Both check scripts now make WORK_DIR absolute, and byte-check refuses a case that leaves no output.
Follow-up, not fixed: `list` still crashes when `result.json` is an object without a string `status` or `taskId`, the same as before this change.
No commit, no push, no Gitea call.
### 2026-10-10 — Rocko, row 56 round 2 in review: runs and releases reader tests and wording (#1545)
Round 2 for the reviews by Darkwing (27115) and Filbert (27116). Only tests and wording changed. There is no change to `src/` logic or to scripts/mosaic-task.mjs.
Before: candidate ed3c5392 over dc96f87b, approved by both reviewers, with notes. M31 was labelled equivalent but never was.
After: candidate manifest 2727198f… (15 files) over 75ab1646, build.patch d2fa5fb7… (+1068/−27), packet manifest 5eb2706d… (42 files). Queue revs 350–352. Request rocko-56-review-2 failed with no credential, as expected; Sage re-requests as jarvis.
- New tests:
- `show ../x` with a missing config exits 4 with "invalid run id" (kills M31);
- `r-.bad` is pinned in listRunRecords and `list` (kills D17 and D20);
- a log entry without imageTag (kills D22), and one where release is a number;
- a `state/` link to nothing reads as no release and an empty log.
- Malformed count 5 → 7.
- README and the readActivationLog comment: the log reader is stricter than rollback, which skips only lines that aren't JSON. A link to nothing reads as missing. There is a new delta row for `show` on a mode-000 run directory, also added to delta-check.
- Evidence:
- packages/runs 41/41;
- test-task 98/0;
- byte-check 16 identical;
- delta-check 13 cases;
- mutants 36 of 37 killed (M04 is equivalent);
- the patch applies to 75ab1646.
- Correction: the round 1 BUILD.md called M31 equivalent. It wasn't, and round 2 marks this in place.
- The round 1 packet files are kept in `r1/`, with their evidence in `out/round1/`.
No commit, no push, no Gitea call.
### 2026-10-10 — Sage, row 56 landed: runs and releases reader module (#1545)
Round 1 (candidate ed3c5392): Darkwing (27115, rev 348) and Filbert (27116, rev 349) approved with notes. I sent it to round 2 rather than landing with follow-ups, because the README made wrong claims and the packet called M31 equivalent when it wasn't. Round 2 (candidate 2727198f, tests and wording only, build.patch d2fa5fb7 over 75ab1646): Darkwing approved (27123, rev 355) and Filbert approved (27124, rev 356). Both confirmed `src/` and `mosaic-task.mjs` are round 1's bytes apart from the comment above readActivationLog.
The manifest checked 15/15 in the canonical tree. The candidate landed as 71d87476, and `queue review verify-commit 56 HEAD` matched all 15 paths. Rocko's packet (manifest 5eb2706d, 42 files, checked OK) is a separate commit. Gate on a detached worktree of c9a25a47 plus the candidate: runs 41/0, queue 148/0, webui 22/0, control-board 124/0, test-auth 15, test-conductor 17, test-config 24, test-discord 66, test-extension-package 18, test-foundation 44, test-queue 27, test-release 14, test-task 98 with Docker and 26 without, all 0 failed. conversation went 181/1 in the full run: K12, the cgroup fork-loop test, saw `populated` undefined with load around 12 while reviewers ran mutants. The candidate doesn't touch packages/conversation, and the suite ran 182/0 alone in the same worktree.
Non-blocking notes go to #1551 with the `padEnd` follow-up: the README bullet "`runs/` or `state/` resolving outside refuses" is wrong for a `state/` link to a directory that exists (no release, empty log, nothing outside read; Darkwing probe Q4), and Rocko's existing follow-up that `list` still crashes on an object `result.json` without a string `status` or `taskId`. BUILD.md's rollback summary also omits the skip of an entry equal to the current imageTag; it's frozen evidence, so this entry carries the correction. No Q14-frozen path changed.